Mesa (main): nir: Initialize evaluate_cube_face_index_amd dst.x.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Aug 13 07:00:12 UTC 2021
Module: Mesa
Branch: main
Commit: 8d679f4f4e8d33402f11ab3da93ff815e4c44538
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d679f4f4e8d33402f11ab3da93ff815e4c44538
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Aug 9 14:24:07 2021 -0700
nir: Initialize evaluate_cube_face_index_amd dst.x.
Fix defect reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value dst.x.
Fixes: a1a2a8dfda7 ("nir: add AMD_gcn_shader extended instructions")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12290>
---
src/compiler/nir/nir_opcodes.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py
index 17a1508c4d5..4a5241a2104 100644
--- a/src/compiler/nir/nir_opcodes.py
+++ b/src/compiler/nir/nir_opcodes.py
@@ -537,6 +537,7 @@ dst.y = dst.y * (1.0f / ma) + 0.5f;
""")
unop_horiz("cube_face_index_amd", 1, tfloat32, 3, tfloat32, """
+dst.x = 0.0;
float absX = fabsf(src0.x);
float absY = fabsf(src0.y);
float absZ = fabsf(src0.z);
More information about the mesa-commit
mailing list