Mesa (main): vulkan/wsi/wayland: do not perform roundtrip when not querying formats

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: db2635020f97d3bdd9bf62bf8c3bb08c791647d0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=db2635020f97d3bdd9bf62bf8c3bb08c791647d0

Author: Leandro Ribeiro <leandro.ribeiro at collabora.com>
Date:   Wed Jul 28 18:03:28 2021 -0300

vulkan/wsi/wayland: do not perform roundtrip when not querying formats

When we call wsi_wl_display_init() with get_format_list set to false
there's no need to dispatch the events from the interfaces. This allow
us to remove a check in the event handlers to verify if we're querying
the formats or not, what makes the code easier to read.

Signed-off-by: Leandro Ribeiro <leandro.ribeiro at collabora.com>
Reviewed-by: Simon Ser <contact at emersion.fr>
Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Daniel Stone <daniels at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12117>

---

 src/vulkan/wsi/wsi_common_wayland.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c
index d89982eaca1..bc0aad9cfac 100644
--- a/src/vulkan/wsi/wsi_common_wayland.c
+++ b/src/vulkan/wsi/wsi_common_wayland.c
@@ -336,10 +336,6 @@ dmabuf_handle_modifier(void *data, struct zwp_linux_dmabuf_v1 *dmabuf,
    struct u_vector *modifiers;
    uint64_t *mod = NULL;
 
-   /* If we're not fetching formats, don't fetch modifiers either. */
-   if (display->dmabuf.formats.element_size == 0)
-      return;
-
    switch (format) {
    case DRM_FORMAT_ARGB8888:
       modifiers = &display->dmabuf.modifiers.argb8888;
@@ -374,8 +370,6 @@ static void
 shm_handle_format(void *data, struct wl_shm *shm, uint32_t format)
 {
    struct wsi_wl_display *display = data;
-   if (display->swrast.formats.element_size == 0)
-      return;
 
    wsi_wl_display_add_wl_shm_format(display, &display->swrast.formats, format);
 }
@@ -491,6 +485,10 @@ wsi_wl_display_init(struct wsi_wayland *wsi_wl,
       goto fail_registry;
    }
 
+   /* Caller doesn't expect us to query formats/modifiers, so return */
+   if (!get_format_list)
+      goto out;
+
    /* Round-trip again to get formats and modifiers */
    wl_display_roundtrip_queue(display->wl_display, display->queue);
 
@@ -514,6 +512,7 @@ wsi_wl_display_init(struct wsi_wayland *wsi_wl,
    else if (display->dmabuf.wl_dmabuf)
       display->formats = &display->dmabuf.formats;
 
+out:
    /* We don't need this anymore */
    wl_registry_destroy(registry);