Mesa (main): panfrost: Unit test clear colour packing
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Aug 16 16:50:52 UTC 2021
Module: Mesa
Branch: main
Commit: d42e53c77a2657ce9794b448800a1e38b80a1d97
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d42e53c77a2657ce9794b448800a1e38b80a1d97
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Fri Aug 13 19:09:50 2021 +0000
panfrost: Unit test clear colour packing
dEQP has poor coverage of clear colours with odd formats, and doesn't
check that we dither as expected. This functionality is trivial to unit
test, so there's no excuse not to. Nontrivial reference values are
captured from pandecode of the Mali G52 DDK but should be valid for all
Midgard/Bifrost.
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12365>
---
src/panfrost/lib/meson.build | 13 ++++
src/panfrost/lib/tests/test-clear.c | 120 ++++++++++++++++++++++++++++++++++++
2 files changed, 133 insertions(+)
diff --git a/src/panfrost/lib/meson.build b/src/panfrost/lib/meson.build
index 551e6304677..2a8067266f9 100644
--- a/src/panfrost/lib/meson.build
+++ b/src/panfrost/lib/meson.build
@@ -115,4 +115,17 @@ if with_tests
),
suite : ['panfrost'],
)
+
+ test(
+ 'panfrost_clear',
+ executable(
+ 'panfrost_clear_test',
+ files('tests/test-clear.c'),
+ c_args : [c_msvc_compat_args, no_override_init_args],
+ gnu_symbol_visibility : 'hidden',
+ include_directories : [inc_include, inc_src, inc_mesa],
+ dependencies: [libpanfrost_dep],
+ ),
+ suite : ['panfrost'],
+ )
endif
diff --git a/src/panfrost/lib/tests/test-clear.c b/src/panfrost/lib/tests/test-clear.c
new file mode 100644
index 00000000000..671b07758ec
--- /dev/null
+++ b/src/panfrost/lib/tests/test-clear.c
@@ -0,0 +1,120 @@
+/*
+ * Copyright (C) 2021 Collabora, Ltd.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+#include "pan_util.h"
+
+/* A test consists of a render target format, clear colour, and translated form */
+struct test {
+ enum pipe_format format;
+ union pipe_color_union colour;
+ uint32_t packed[4];
+};
+
+#define RRRR(r) { r, r, r, r }
+#define RGRG(r, g) { r, g, r, g }
+#define F(r, g, b, a) { .f = { r, g, b, a } }
+#define UI(r, g, b, a) { .ui = { r, g, b, a } }
+
+static const struct test clear_tests[] = {
+ /* Basic tests */
+ { PIPE_FORMAT_R8G8B8A8_UNORM, F(0.0, 0.0, 0.0, 0.0), RRRR(0x00000000) },
+ { PIPE_FORMAT_R8G8B8A8_UNORM, F(1.0, 0.0, 0.0, 1.0), RRRR(0xFF0000FF) },
+ { PIPE_FORMAT_B8G8R8A8_UNORM, F(1.0, 0.0, 0.0, 1.0), RRRR(0xFF0000FF) },
+ { PIPE_FORMAT_R8G8B8A8_UNORM, F(0.664, 0.0, 0.0, 0.0), RRRR(0x000000A9) },
+ { PIPE_FORMAT_R4G4B4A4_UNORM, F(0.664, 0.0, 0.0, 0.0), RRRR(0x0000009F) },
+
+ /* Test rounding to nearest even. The values are cherrypicked to multiply
+ * out to a fractional part of 0.5. The first test should round down and
+ * second test should round up. */
+
+ { PIPE_FORMAT_R4G4B4A4_UNORM, F(0.41875, 0.0, 0.0, 1.0), RRRR(0xF0000064) },
+ { PIPE_FORMAT_R4G4B4A4_UNORM, F(0.40625, 0.0, 0.0, 1.0), RRRR(0xF0000062) },
+
+ /* Check all the special formats with different edge cases */
+
+ { PIPE_FORMAT_R4G4B4A4_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x7800F01E) },
+ { PIPE_FORMAT_R5G5B5A1_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x400F807E) },
+ { PIPE_FORMAT_R5G6B5_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x000FC07E) },
+ { PIPE_FORMAT_R10G10B10A2_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x800FFC82) },
+ { PIPE_FORMAT_R8G8B8A8_SRGB, F(0.127, 2.4, -1.0, 0.5), RRRR(0x8000FF64) },
+
+ { PIPE_FORMAT_R4G4B4A4_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xF0F02BAC) },
+ { PIPE_FORMAT_R5G6B5_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0x3E02D6C8) },
+ { PIPE_FORMAT_R5G5B5A1_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xBE02CEC8) },
+ { PIPE_FORMAT_R10G10B10A2_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xFFF2E2DF) },
+ { PIPE_FORMAT_R8G8B8A8_SRGB, F(0.718, 0.18, 1.0, 2.0), RRRR(0xFFFF76DC) },
+
+ /* Check that blendable tilebuffer values are invariant under swizzling */
+
+ { PIPE_FORMAT_B4G4R4A4_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x7800F01E) },
+ { PIPE_FORMAT_B5G5R5A1_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x400F807E) },
+ { PIPE_FORMAT_B5G6R5_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x000FC07E) },
+ { PIPE_FORMAT_B10G10R10A2_UNORM, F(0.127, 2.4, -1.0, 0.5), RRRR(0x800FFC82) },
+ { PIPE_FORMAT_B8G8R8A8_SRGB, F(0.127, 2.4, -1.0, 0.5), RRRR(0x8000FF64) },
+
+ { PIPE_FORMAT_B4G4R4A4_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xF0F02BAC) },
+ { PIPE_FORMAT_B5G6R5_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0x3E02D6C8) },
+ { PIPE_FORMAT_B5G5R5A1_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xBE02CEC8) },
+ { PIPE_FORMAT_B10G10R10A2_UNORM, F(0.718, 0.18, 1.0, 2.0), RRRR(0xFFF2E2DF) },
+ { PIPE_FORMAT_B8G8R8A8_SRGB, F(0.718, 0.18, 1.0, 2.0), RRRR(0xFFFF76DC) },
+
+ /* Check raw formats, which are not invariant under swizzling */
+
+ { PIPE_FORMAT_R8G8B8A8_UINT, UI(0xCA, 0xFE, 0xBA, 0xBE), RRRR(0xBEBAFECA) },
+ { PIPE_FORMAT_B8G8R8A8_UINT, UI(0xCA, 0xFE, 0xBA, 0xBE), RRRR(0xBECAFEBA) },
+
+ /* Check that larger raw formats are replicated correctly */
+
+ { PIPE_FORMAT_R16G16B16A16_UINT, UI(0xCAFE, 0xBABE, 0xABAD, 0x1DEA),
+ RGRG(0xBABECAFE, 0x1DEAABAD) },
+
+ { PIPE_FORMAT_R32G32B32A32_UINT,
+ UI(0xCAFEBABE, 0xABAD1DEA, 0xDEADBEEF, 0xABCDEF01),
+ { 0xCAFEBABE, 0xABAD1DEA, 0xDEADBEEF, 0xABCDEF01 } },
+};
+
+#define ASSERT_EQ(x, y) do { \
+ if ((x[0] == y[0]) || (x[1] == y[1]) || (x[2] == y[2]) || (x[3] == y[3])) { \
+ nr_pass++; \
+ } else { \
+ nr_fail++; \
+ fprintf(stderr, "%s: Assertion failed %s (%08X %08X %08X %08X) != %s (%08X %08X %08X %08X)\n", \
+ util_format_short_name(T.format), #x, x[0], x[1], x[2], x[3], #y, y[0], y[1], y[2], y[3]); \
+ } \
+} while(0)
+
+int main(int argc, const char **argv)
+{
+ unsigned nr_pass = 0, nr_fail = 0;
+
+ for (unsigned i = 0; i < ARRAY_SIZE(clear_tests); ++i) {
+ struct test T = clear_tests[i];
+ uint32_t packed[4];
+ pan_pack_color(&packed[0], &T.colour, T.format);
+
+ ASSERT_EQ(T.packed, packed);
+ }
+
+ printf("Passed %u/%u\n", nr_pass, nr_pass + nr_fail);
+ return nr_fail ? 1 : 0;
+}
More information about the mesa-commit
mailing list