Mesa (main): intel/isl: Explicitly set offset_B = 0 in get_uncomp_surf for arrays

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 17 14:53:59 UTC 2021


Module: Mesa
Branch: main
Commit: 370240615421055be24c2c30e345d0454043d5e1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=370240615421055be24c2c30e345d0454043d5e1

Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Jul  7 10:52:09 2021 -0500

intel/isl: Explicitly set offset_B = 0 in get_uncomp_surf for arrays

The only user of this case is iris which initializes offset_B to 0 so
there's no real bug here.  However, it is unexpected from an API PoV.

Fixes: 9946120d2b4e "intel/isl: Add more cases to isl_surf_get_uncompressed_surf"
Acked-by: Ivan Briano <ivan.briano at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11765>

---

 src/intel/isl/isl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 2e2e79c5659..53adb4dbbde 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -2892,6 +2892,9 @@ isl_surf_get_uncompressed_surf(const struct isl_device *dev,
       *ucompr_surf = *surf;
       ucompr_surf->levels = 1;
 
+      /* The surface mostly stays as-is; there is no offset */
+      *offset_B = 0;
+
       /* The view remains the same */
       *ucompr_view = *view;
    } else {



More information about the mesa-commit mailing list