Mesa (main): radv: fix fast clearing depth images with mips on GFX10+

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Aug 18 07:15:37 UTC 2021


Module: Mesa
Branch: main
Commit: b16f3261a71c6fa22e300ba2b65d7e4128d8d05a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b16f3261a71c6fa22e300ba2b65d7e4128d8d05a

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Aug 11 14:06:09 2021 +0200

radv: fix fast clearing depth images with mips on GFX10+

Found by inspection.

Cc: 21.2 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12325>

---

 src/amd/vulkan/radv_meta_clear.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
index e41ac7b122d..0e783101270 100644
--- a/src/amd/vulkan/radv_meta_clear.c
+++ b/src/amd/vulkan/radv_meta_clear.c
@@ -1000,6 +1000,14 @@ radv_can_fast_clear_depth(struct radv_cmd_buffer *cmd_buffer, const struct radv_
          !radv_is_fast_clear_stencil_allowed(clear_value))))
       return false;
 
+   if (iview->image->info.levels > 1) {
+      uint32_t last_level = iview->base_mip + iview->level_count - 1;
+      if (last_level >= iview->image->planes[0].surface.num_meta_levels) {
+         /* Do not fast clears if one level can't be fast cleared. */
+         return false;
+      }
+   }
+
    return true;
 }
 



More information about the mesa-commit mailing list