Mesa (main): radv: remove unnecessary check in radv_layout_is_htile_compressed()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Aug 20 16:12:50 UTC 2021


Module: Mesa
Branch: main
Commit: 1c2675196906ad6551a5fd1fe4f3aa5b16a21b36
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c2675196906ad6551a5fd1fe4f3aa5b16a21b36

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Aug 18 15:58:09 2021 +0200

radv: remove unnecessary check in radv_layout_is_htile_compressed()

The driver doesn't enable TC-compat HTILE for storage images, so this
was actually always TRUE.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12450>

---

 src/amd/vulkan/radv_image.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 9d00efe0841..a465bdbddf0 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -2048,8 +2048,7 @@ radv_layout_is_htile_compressed(const struct radv_device *device, const struct r
       if (radv_image_is_tc_compat_htile(image) && queue_mask & (1u << RADV_QUEUE_GENERAL) &&
           !in_render_loop && !device->instance->disable_tc_compat_htile_in_general) {
          /* GFX10+ supports compressed writes to HTILE. */
-         return device->physical_device->rad_info.chip_class >= GFX10 ||
-                !(image->usage & VK_IMAGE_USAGE_STORAGE_BIT);
+         return true;
       } else {
          return false;
       }



More information about the mesa-commit mailing list