Mesa (main): freedreno: Require C++17.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 24 04:49:54 UTC 2021


Module: Mesa
Branch: main
Commit: 4fc2a6cbdb6fab868a2ee4ee753caa2e83cf6666
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fc2a6cbdb6fab868a2ee4ee753caa2e83cf6666

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Aug  9 15:48:25 2021 -0700

freedreno: Require C++17.

Commit 3a772be026c ("freedreno: Add perfetto renderpass support")
uses C++17 init-statement feature.

GCC
../src/gallium/drivers/freedreno/freedreno_perfetto.cc: In lambda function:
../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning: init-statement in selection statements only available with ‘-std=c++17’ or ‘-std=gnu++17’
  148 |       if (auto state = tctx.GetIncrementalState(); state->was_cleared) {
      |           ^~~~

Clang
../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning: 'if' initialization statements are a C++17 extension [-Wc++17-extensions]
      if (auto state = tctx.GetIncrementalState(); state->was_cleared) {
          ^

Intel C++ Compiler
../src/gallium/drivers/freedreno/freedreno_perfetto.cc(148): error: expected a ")"
        if (auto state = tctx.GetIncrementalState(); state->was_cleared) {
                                                   ^

Fixes: 3a772be026c ("freedreno: Add perfetto renderpass support")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5193
Suggested-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Acked-by: Rob Clark <robdclark at chromium.org>
Acked-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12293>

---

 src/gallium/drivers/freedreno/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/gallium/drivers/freedreno/meson.build b/src/gallium/drivers/freedreno/meson.build
index dac51b1c3c7..6cf833d335b 100644
--- a/src/gallium/drivers/freedreno/meson.build
+++ b/src/gallium/drivers/freedreno/meson.build
@@ -273,6 +273,7 @@ libfreedreno = static_library(
   cpp_args : [freedreno_cpp_args],
   gnu_symbol_visibility : 'hidden',
   dependencies : libfreedreno_dependencies,
+  override_options : ['cpp_std=c++17'],
 )
 
 driver_freedreno = declare_dependency(



More information about the mesa-commit mailing list