Mesa (main): broadcom/compiler: Fix qpu.flags.muf typo.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Aug 24 08:44:20 UTC 2021
Module: Mesa
Branch: main
Commit: 0a4c4f4459b7d99485372b15689aa25d175765b3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a4c4f4459b7d99485372b15689aa25d175765b3
Author: Vinson Lee <vlee at freedesktop.org>
Date: Mon Aug 16 00:47:26 2021 -0700
broadcom/compiler: Fix qpu.flags.muf typo.
Fix defect reported by Coverity Scan.
Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression: The expression inst->qpu.flags.auf !=
V3D_QPU_UF_NONE || inst->qpu.flags.auf != V3D_QPU_UF_NONE does not
accomplish anything because it evaluates to either of its identical
operands, inst->qpu.flags.auf != V3D_QPU_UF_NONE.
Fixes: 3f2c54a27ff ("broadcom/compiler: rewrite partial update liveness tracking")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12385>
---
src/broadcom/compiler/vir_live_variables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/broadcom/compiler/vir_live_variables.c b/src/broadcom/compiler/vir_live_variables.c
index 6a849dc7fc9..2fd6430a0f4 100644
--- a/src/broadcom/compiler/vir_live_variables.c
+++ b/src/broadcom/compiler/vir_live_variables.c
@@ -175,7 +175,7 @@ vir_setup_def_use(struct v3d_compile *c)
}
if (inst->qpu.flags.auf != V3D_QPU_UF_NONE ||
- inst->qpu.flags.auf != V3D_QPU_UF_NONE) {
+ inst->qpu.flags.muf != V3D_QPU_UF_NONE) {
flags_inst = NULL;
}
More information about the mesa-commit
mailing list