Mesa (main): broadcom/qpu: remove duplicated opcode variable

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Aug 26 10:25:25 UTC 2021


Module: Mesa
Branch: main
Commit: b22ba696153577c95eb88d03549eed1e37ed8986
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b22ba696153577c95eb88d03549eed1e37ed8986

Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Thu Aug 26 10:36:48 2021 +0200

broadcom/qpu: remove duplicated opcode variable

`opcode` is wrote twice.

Fixes CID 1490798:  Incorrect expression  (EVALUATION_ORDER).

Fixes: 8a5f2228dbb ("broadcom/qpu: add new lookup opcode description helper")
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12554>

---

 src/broadcom/qpu/qpu_pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/qpu/qpu_pack.c b/src/broadcom/qpu/qpu_pack.c
index d70e9b77e1b..eee1e9f95a5 100644
--- a/src/broadcom/qpu/qpu_pack.c
+++ b/src/broadcom/qpu/qpu_pack.c
@@ -1001,7 +1001,7 @@ v3d_qpu_add_pack(const struct v3d_device_info *devinfo,
         if (!desc)
                 return false;
 
-        uint32_t opcode = opcode = desc->opcode_first;
+        uint32_t opcode = desc->opcode_first;
 
         /* If an operation doesn't use an arg, its mux values may be used to
          * identify the operation type.



More information about the mesa-commit mailing list