Mesa (main): radv: remove useless check about number of samples in the HW resolve path
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Aug 27 07:46:33 UTC 2021
Module: Mesa
Branch: main
Commit: df90bb3f8856f21357119700d541e3caadd55166
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=df90bb3f8856f21357119700d541e3caadd55166
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Aug 26 10:56:04 2021 +0200
radv: remove useless check about number of samples in the HW resolve path
Although this can likely hang, this is invalid and should be caught
by the validation layers. There is many ways to hang the GPU with VK,
this check alone is useless.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12556>
---
src/amd/vulkan/radv_meta_resolve.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c
index 091c0b3edb9..c9ac73eb336 100644
--- a/src/amd/vulkan/radv_meta_resolve.c
+++ b/src/amd/vulkan/radv_meta_resolve.c
@@ -451,11 +451,6 @@ radv_meta_resolve_hardware_image(struct radv_cmd_buffer *cmd_buffer, struct radv
radv_meta_save(&saved_state, cmd_buffer, RADV_META_SAVE_GRAPHICS_PIPELINE);
assert(src_image->info.samples > 1);
- if (src_image->info.samples <= 1) {
- /* this causes GPU hangs if we get past here */
- fprintf(stderr, "radv: Illegal resolve operation (src not multisampled), will hang GPU.");
- return;
- }
assert(dst_image->info.samples == 1);
unsigned fs_key = radv_format_meta_fs_key(device, dst_image->vk_format);
More information about the mesa-commit
mailing list