Mesa (main): zink: zero viewport and scissor count in pipeline with dynamic state1

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Aug 27 11:07:14 UTC 2021


Module: Mesa
Branch: main
Commit: 827fcb7e32a0b78362da1d749c997247f487da4a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=827fcb7e32a0b78362da1d749c997247f487da4a

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Tue Jun 15 09:51:13 2021 -0400

zink: zero viewport and scissor count in pipeline with dynamic state1

this is illegal

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12586>

---

 src/gallium/drivers/zink/zink_pipeline.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/zink/zink_pipeline.c b/src/gallium/drivers/zink/zink_pipeline.c
index 2bf8e83bc15..b25674648e9 100644
--- a/src/gallium/drivers/zink/zink_pipeline.c
+++ b/src/gallium/drivers/zink/zink_pipeline.c
@@ -125,9 +125,9 @@ zink_create_gfx_pipeline(struct zink_screen *screen,
 
    VkPipelineViewportStateCreateInfo viewport_state = {0};
    viewport_state.sType = VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO;
-   viewport_state.viewportCount = state->dyn_state1.num_viewports;
+   viewport_state.viewportCount = screen->info.have_EXT_extended_dynamic_state ? 0 : state->dyn_state1.num_viewports;
    viewport_state.pViewports = NULL;
-   viewport_state.scissorCount = state->dyn_state1.num_viewports;
+   viewport_state.scissorCount = screen->info.have_EXT_extended_dynamic_state ? 0 : state->dyn_state1.num_viewports;
    viewport_state.pScissors = NULL;
 
    VkPipelineRasterizationStateCreateInfo rast_state = {0};



More information about the mesa-commit mailing list