Mesa (staging/21.2): crocus: add missing line smooth bits.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Aug 27 17:23:30 UTC 2021
Module: Mesa
Branch: staging/21.2
Commit: 1c89b990a64f4af395527a0ddc21eebabd977508
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c89b990a64f4af395527a0ddc21eebabd977508
Author: Dave Airlie <airlied at gmail.com>
Date: Tue Aug 24 22:00:47 2021 -0400
crocus: add missing line smooth bits.
Just noticed this in passing.
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12536>
(cherry picked from commit 6b7a68b7c21eeff1aa037b68b6fb9ab971fe9982)
---
.pick_status.json | 2 +-
src/gallium/drivers/crocus/crocus_state.c | 9 ++++++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index 1abb165c015..5bc61837b1f 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -1489,7 +1489,7 @@
"description": "crocus: add missing line smooth bits.",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": "f3630548f1da904ec6c63b43ece7e68afdb8867e"
},
diff --git a/src/gallium/drivers/crocus/crocus_state.c b/src/gallium/drivers/crocus/crocus_state.c
index 9924923ad89..43d033457e6 100644
--- a/src/gallium/drivers/crocus/crocus_state.c
+++ b/src/gallium/drivers/crocus/crocus_state.c
@@ -2026,6 +2026,9 @@ crocus_create_rasterizer_state(struct pipe_context *ctx,
sf.LineEndCapAntialiasingRegionWidth =
state->line_smooth ? _10pixels : _05pixels;
sf.LastPixelEnable = state->line_last_pixel;
+#if GFX_VER <= 7
+ sf.AntialiasingEnable = state->line_smooth;
+#endif
#if GFX_VER == 8
struct crocus_screen *screen = (struct crocus_screen *)ctx->screen;
if (screen->devinfo.is_cherryview)
@@ -7017,11 +7020,15 @@ crocus_upload_dirty_render_state(struct crocus_context *ice,
sf.DestinationOriginHorizontalBias = 0.5;
sf.DestinationOriginVerticalBias = 0.5;
+ sf.LineEndCapAntialiasingRegionWidth =
+ cso_state->line_smooth ? _10pixels : _05pixels;
sf.LastPixelEnable = cso_state->line_last_pixel;
+ sf.AntialiasingEnable = cso_state->line_smooth;
+
sf.LineWidth = get_line_width(cso_state);
sf.PointWidth = cso_state->point_size;
sf.PointWidthSource = cso_state->point_size_per_vertex ? Vertex : State;
-#if GFX_VERx10 == 45 || GFX_VER >= 5
+#if GFX_VERx10 >= 45
sf.AALineDistanceMode = AALINEDISTANCE_TRUE;
#endif
sf.ViewportTransformEnable = true;
More information about the mesa-commit
mailing list