Mesa (main): ci: Fix a minor issue in prepare-artifacts.sh script
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Aug 30 15:13:30 UTC 2021
Module: Mesa
Branch: main
Commit: a6a89aaa2f2943532d99d9bc7b80106a1740f237
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a6a89aaa2f2943532d99d9bc7b80106a1740f237
Author: Rohan Garg <rohan.garg at collabora.com>
Date: Thu Aug 26 15:00:40 2021 +0200
ci: Fix a minor issue in prepare-artifacts.sh script
bash is whitespace sensitive.
https://github.com/koalaman/shellcheck/wiki/SC1020
This was noticed from the logs of a CI job
https://gitlab.freedesktop.org/mesa/mesa/-/jobs/13158779
There was no fallout from this bug as not having this variable defined
leads to the right behavior, and defining it to 1 leads to a error
which consequently also leads to the right behaviour.
Signed-off-by: Rohan Garg <rohan.garg at collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12562>
---
.gitlab-ci/prepare-artifacts.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci/prepare-artifacts.sh b/.gitlab-ci/prepare-artifacts.sh
index 393329effc4..bbc37ef1419 100755
--- a/.gitlab-ci/prepare-artifacts.sh
+++ b/.gitlab-ci/prepare-artifacts.sh
@@ -18,7 +18,7 @@ if [ -n "$CROSS" ]; then
else
STRIP="strip"
fi
-if [ -z "$ARTIFACTS_DEBUG_SYMBOLS"]; then
+if [ -z "$ARTIFACTS_DEBUG_SYMBOLS" ]; then
find install -name \*.so -exec $STRIP {} \;
fi
More information about the mesa-commit
mailing list