Mesa (main): radv/llvm: fix invalid IR when converting triangle strips to indices

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 31 09:01:33 UTC 2021


Module: Mesa
Branch: main
Commit: 640f15edd73f934b45e90c6453c52805398ed997
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=640f15edd73f934b45e90c6453c52805398ed997

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri Aug 27 16:34:25 2021 +0200

radv/llvm: fix invalid IR when converting triangle strips to indices

Operand 0 of LLVMBuildSelect() should be i1.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12616>

---

 src/amd/vulkan/radv_nir_to_llvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
index 08506d980c9..20d094cb285 100644
--- a/src/amd/vulkan/radv_nir_to_llvm.c
+++ b/src/amd/vulkan/radv_nir_to_llvm.c
@@ -2496,7 +2496,7 @@ gfx10_ngg_gs_emit_epilogue_2(struct radv_shader_context *ctx)
          is_odd = LLVMBuildTrunc(builder, is_odd, ctx->ac.i1, "");
 
          LLVMValueRef flatshade_first =
-            LLVMConstInt(ctx->ac.i32, !ctx->args->options->key.vs.provoking_vtx_last, false);
+            LLVMConstInt(ctx->ac.i1, !ctx->args->options->key.vs.provoking_vtx_last, false);
 
          ac_build_triangle_strip_indices_to_triangle(&ctx->ac, is_odd, flatshade_first, prim.index);
       }



More information about the mesa-commit mailing list