Mesa (main): aco: don't constant propagate to DPP instructions

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 31 17:15:49 UTC 2021


Module: Mesa
Branch: main
Commit: e27946ca110b69be75e999640ffd59fbb45ebe20
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e27946ca110b69be75e999640ffd59fbb45ebe20

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Fri Aug 27 17:50:11 2021 +0100

aco: don't constant propagate to DPP instructions

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12601>

---

 src/amd/compiler/aco_optimizer.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index 4a95ef8bb11..634c0939ea1 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -1058,7 +1058,7 @@ label_instruction(opt_ctx& ctx, aco_ptr<Instruction>& instr)
 
          unsigned bits = get_operand_size(instr, i);
          if (info.is_constant(bits) && alu_can_accept_constant(instr->opcode, i) &&
-             (!instr->isSDWA() || ctx.program->chip_class >= GFX9)) {
+             (!instr->isSDWA() || ctx.program->chip_class >= GFX9) && !instr->isDPP()) {
             Operand op = get_constant_op(ctx, info, bits);
             perfwarn(ctx.program, instr->opcode == aco_opcode::v_cndmask_b32 && i == 2,
                      "v_cndmask_b32 with a constant selector", instr.get());



More information about the mesa-commit mailing list