Mesa (main): glsl: fix for unused variable in glsl_types.cpp
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Dec 1 10:24:18 UTC 2021
Module: Mesa
Branch: main
Commit: 6f54ebe44f7c9dcb52c89684aa160277e1e5ba2c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6f54ebe44f7c9dcb52c89684aa160277e1e5ba2c
Author: Viktoriia Palianytsia <v.palianytsia at globallogic.com>
Date: Tue Nov 9 14:49:45 2021 +0200
glsl: fix for unused variable in glsl_types.cpp
Unused variable vector_elements is now used in return from
function decode_type_from_blob instead of encoded.basic.vector_elements.
In the code we can see how those variables were equated
and then the operations were made exactly to vector_elements.
But variable didn't pass into any other variables or functions.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5536
Signed-off-by: Viktoriia Palianytsia <v.palianytsia at globallogic.com>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13725>
---
src/compiler/glsl_types.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index 627a43fee5d..de98b80354d 100644
--- a/src/compiler/glsl_types.cpp
+++ b/src/compiler/glsl_types.cpp
@@ -3242,7 +3242,7 @@ decode_type_from_blob(struct blob_reader *blob)
vector_elements = 8;
else if (vector_elements == 6)
vector_elements = 16;
- return glsl_type::get_instance(base_type, encoded.basic.vector_elements,
+ return glsl_type::get_instance(base_type, vector_elements,
encoded.basic.matrix_columns,
explicit_stride,
encoded.basic.interface_row_major,
More information about the mesa-commit
mailing list