Mesa (main): radv: Do not use VK_FORMAT_UNDEFINED in meta passes.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Sun Dec 5 17:56:09 UTC 2021


Module: Mesa
Branch: main
Commit: 403a5c1a790f229786d02742b04cdd6a974bc145
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=403a5c1a790f229786d02742b04cdd6a974bc145

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sun Nov  7 15:00:13 2021 +0100

radv: Do not use VK_FORMAT_UNDEFINED in meta passes.

Is used in VK_KHR_dynamic_rendering to indicate non-presence of
color attachments. Wasn't really valid Vulkan so we otherwise don't
need a workaround in the renderpass->dynamic rendering conversion.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13721>

---

 src/amd/vulkan/radv_meta_fast_clear.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c
index 096d2c25b14..2214b65a416 100644
--- a/src/amd/vulkan/radv_meta_fast_clear.c
+++ b/src/amd/vulkan/radv_meta_fast_clear.c
@@ -159,7 +159,7 @@ create_pass(struct radv_device *device)
 
    attachment.sType = VK_STRUCTURE_TYPE_ATTACHMENT_DESCRIPTION_2;
    attachment.pNext = NULL;
-   attachment.format = VK_FORMAT_UNDEFINED;
+   attachment.format = VK_FORMAT_R8_UNORM;
    attachment.samples = 1;
    attachment.loadOp = VK_ATTACHMENT_LOAD_OP_LOAD;
    attachment.storeOp = VK_ATTACHMENT_STORE_OP_STORE;



More information about the mesa-commit mailing list