Mesa (main): r300: Turn a comment about presub into an assert.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Dec 7 01:18:19 UTC 2021


Module: Mesa
Branch: main
Commit: 0e0a49039b617ef1dadc912adc34776be6e06a34
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e0a49039b617ef1dadc912adc34776be6e06a34

Author: Emma Anholt <emma at anholt.net>
Date:   Mon Dec  6 13:58:25 2021 -0800

r300: Turn a comment about presub into an assert.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14092>

---

 src/gallium/drivers/r300/compiler/radeon_optimize.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r300/compiler/radeon_optimize.c b/src/gallium/drivers/r300/compiler/radeon_optimize.c
index 5e3503b2129..df95684fcf7 100644
--- a/src/gallium/drivers/r300/compiler/radeon_optimize.c
+++ b/src/gallium/drivers/r300/compiler/radeon_optimize.c
@@ -496,14 +496,18 @@ static int presub_helper(
 	return 1;
 }
 
-/* This function assumes that inst_add->U.I.SrcReg[0] and
- * inst_add->U.I.SrcReg[1] aren't both negative. */
 static void presub_replace_add(
 	struct rc_instruction * inst_add,
 	struct rc_instruction * inst_reader,
 	unsigned int src_index)
 {
 	rc_presubtract_op presub_opcode;
+
+	/* This function assumes that inst_add->U.I.SrcReg[0] and
+	 * inst_add->U.I.SrcReg[1] aren't both negative.
+	 */
+	assert(!(inst_add->U.I.SrcReg[1].Negate && inst_add->U.I.SrcReg[0].Negate));
+
 	if (inst_add->U.I.SrcReg[1].Negate || inst_add->U.I.SrcReg[0].Negate)
 		presub_opcode = RC_PRESUB_SUB;
 	else



More information about the mesa-commit mailing list