Mesa (main): loader/dri3: remove unused present capability query

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Dec 7 05:14:56 UTC 2021


Module: Mesa
Branch: main
Commit: 9faa2892b9386a7fb7381195c5409a44e5db0fa8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9faa2892b9386a7fb7381195c5409a44e5db0fa8

Author: Qiang Yu <yuq825 at gmail.com>
Date:   Tue Nov  9 21:51:35 2021 +0800

loader/dri3: remove unused present capability query

The query result is not used anywhere.

Reviewed-by: Adam Jackson <ajax at redhat.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13750>

---

 src/loader/loader_dri3_helper.c | 16 ----------------
 src/loader/loader_dri3_helper.h |  4 ----
 2 files changed, 20 deletions(-)

diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index 73e8165eb4f..fc3f8032eef 100644
--- a/src/loader/loader_dri3_helper.c
+++ b/src/loader/loader_dri3_helper.c
@@ -1660,8 +1660,6 @@ dri3_update_drawable(struct loader_dri3_drawable *draw)
       xcb_get_geometry_reply_t                  *geom_reply;
       xcb_void_cookie_t                         cookie;
       xcb_generic_error_t                       *error;
-      xcb_present_query_capabilities_cookie_t   present_capabilities_cookie;
-      xcb_present_query_capabilities_reply_t    *present_capabilities_reply;
       xcb_window_t                               root_win;
 
       draw->first_init = false;
@@ -1682,9 +1680,6 @@ dri3_update_drawable(struct loader_dri3_drawable *draw)
                                           XCB_PRESENT_EVENT_MASK_COMPLETE_NOTIFY |
                                           XCB_PRESENT_EVENT_MASK_IDLE_NOTIFY);
 
-      present_capabilities_cookie =
-         xcb_present_query_capabilities(draw->conn, draw->drawable);
-
       /* Create an XCB event queue to hold present events outside of the usual
        * application event queue
        */
@@ -1717,17 +1712,6 @@ dri3_update_drawable(struct loader_dri3_drawable *draw)
 
       error = xcb_request_check(draw->conn, cookie);
 
-      present_capabilities_reply =
-          xcb_present_query_capabilities_reply(draw->conn,
-                                               present_capabilities_cookie,
-                                               NULL);
-
-      if (present_capabilities_reply) {
-         draw->present_capabilities = present_capabilities_reply->capabilities;
-         free(present_capabilities_reply);
-      } else
-         draw->present_capabilities = 0;
-
       if (error) {
          if (error->error_code != BadWindow) {
             free(error);
diff --git a/src/loader/loader_dri3_helper.h b/src/loader/loader_dri3_helper.h
index 0d8f734e920..c66ea9e28d4 100644
--- a/src/loader/loader_dri3_helper.h
+++ b/src/loader/loader_dri3_helper.h
@@ -147,10 +147,6 @@ struct loader_dri3_drawable {
    /* DRI screen created for display GPU in case of prime */
    __DRIscreen *dri_screen_display_gpu;
 
-   /* Present extension capabilities
-    */
-   uint32_t present_capabilities;
-
    /* SBC numbers are tracked by using the serial numbers
     * in the present request and complete events
     */



More information about the mesa-commit mailing list