Mesa (main): nir: limit lower_clip_cull_distance_arrays input to traditional stages

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Dec 13 09:12:39 UTC 2021


Module: Mesa
Branch: main
Commit: 87f03b1662492249b03aa0406024a4c7ef5ebfd1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=87f03b1662492249b03aa0406024a4c7ef5ebfd1

Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date:   Wed Nov 24 12:38:07 2021 +0100

nir: limit lower_clip_cull_distance_arrays input to traditional stages

Compute, task, mesh & raytracing stages don't support
ClipDistance/CullDistance as input.

This change is not needed for correctness. Just something I stumbled on.

Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14149>

---

 src/compiler/nir/nir_lower_clip_cull_distance_arrays.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c b/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
index 126e5c87149..26f771817cc 100644
--- a/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
+++ b/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
@@ -128,7 +128,8 @@ nir_lower_clip_cull_distance_arrays(nir_shader *nir)
        nir->info.stage == MESA_SHADER_MESH)
       progress |= combine_clip_cull(nir, nir_var_shader_out, true);
 
-   if (nir->info.stage > MESA_SHADER_VERTEX) {
+   if (nir->info.stage > MESA_SHADER_VERTEX &&
+       nir->info.stage <= MESA_SHADER_FRAGMENT) {
       progress |= combine_clip_cull(nir, nir_var_shader_in,
                                     nir->info.stage == MESA_SHADER_FRAGMENT);
    }



More information about the mesa-commit mailing list