Mesa (staging/21.3): 28 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Dec 17 22:31:51 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a06cd045d16908acf6644a69e08a1f671f9fa653
Author: Eric Engestrom <eric at engestrom.ch>
Date: Fri Dec 17 22:31:25 2021 +0000
VERSION: bump for 21.3.2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b6c14cc7a0371b1132fa88a38b8ae2bc5d1709f
Author: Eric Engestrom <eric at engestrom.ch>
Date: Fri Dec 17 22:31:13 2021 +0000
docs: add release notes for 21.3.2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b8f73b5c7b5c48619aba6258fe5e5bf9f18ccc0
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Dec 16 23:20:31 2021 -0600
radeonsi/nir: Check for VARYING_SLOT_PRIMITIVE_ID not SYSTEM_VALUE
This function is called on load/store_input/output. It makes no sense
for it to get a SYSTEM_VALUE enum. This only doesn't explode because
SYSTEM_VALUE_PRIMITIVE_ID happens to be below VARYING_SLOT_VAR0 so it
doesn't interact with any actual varyings. The next commit is going to
add another system value which will push SYSTEM_VALUE_PRIMITIVE_ID up by
one so it will equal VARYING_SLOT_VAR0 and then the first FS input will
always get smashed to flat which isn't what we want.
Fixes: b59bb9c07ae4 ("radeonsi: force flat for PrimID early in si_nir_scan_shader")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14198>
(cherry picked from commit 732b234ddba7ed697cb1ed351d56cc4a8b56539a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=09ead89f6de6a48e3cd854fb11032e8c51167f61
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Dec 15 11:08:17 2021 +0200
vulkan: fix missing handling of WSI memory signal
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: b996fa8efaa4 ("anv: implement VK_KHR_synchronization2")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5744
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14237>
(cherry picked from commit cdf101455d488a9dadb74765d5250dbc34472165)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd54eeb8978771c68af480df14584cebeec7b33e
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Dec 9 12:06:39 2021 -0800
intel/stub: Silence "initialized field overwritten" warning
src/intel/tools/intel_noop_drm_shim.c:459:36: warning: initialized field overwritten [-Woverride-init]
459 | [DRM_I915_GEM_EXECBUFFER2_WR] = i915_ioctl_noop,
| ^~~~~~~~~~~~~~~
Fixes: 0f4f1d70bfe ("intel: add stub_gpu tool")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14218>
(cherry picked from commit 2dc7c24b80147709e00cc47a2d1da1ca6058e9d2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c51e26649ee7f059a63327afcdbae78534421aa4
Author: Michel Zou <xantares09 at hotmail.com>
Date: Thu Nov 25 21:51:07 2021 +0100
meson: correctly detect linker arguments
Fixes: 22673a98 ("meson: Check arguments before adding")
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13961>
(cherry picked from commit 631b3fe3e9e27302d48051f7d5bef5e4e1bb0e40)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=709c5d14920f01e026628f893f3d8f5cde735c84
Author: Caio Oliveira <caio.oliveira at intel.com>
Date: Wed Dec 15 00:47:36 2021 -0800
nir: Initialize nir_register::divergent
Fixes: c7fc44f9ebb ("nir/from_ssa: Respect and populate divergence information")
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14205>
(cherry picked from commit dcc7b19cae924ecbcee88186a11df0290e5c7a8e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2198488bbb0917d87ed125451ca8dc846c8c384f
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Wed Dec 8 16:52:33 2021 +0000
radv: have the null winsys set more fields
I copied stuff from ac_gpu_info.c until there were no Sienna Cichild or
Polaris10 fossil-db changes between real hardware and RADV_FORCE_FAMILY.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14126>
(cherry picked from commit 451e6c1b32c2ea43d84ab60513dc6fde2373431c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6f3d5f546daa745c179a96a18f84a00b9526890
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Tue Dec 7 16:25:20 2021 -0500
iris: Free the local cache bucket in bufmgr_destroy
Fixes: 55be94dcab4 ("iris/bufmgr: Add new set of buckets for local memory.")
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14012>
(cherry picked from commit f93892c5d3300127faabb5ba8cbf986d11cc38a4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=41f9866120b53e497c3fbedad64e56f22698c46c
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Thu Dec 2 11:56:41 2021 +0100
radeonsi: fix fast clear / depth decompression corruption
Insert a flush after a depth decompression pass if the texture
was fast cleared.
This fixes a corruption which seems to only affect gfx10.3 chips.
Ideally we should also clear tex->need_flush_after_depth_decompression
after a flush but there's no easy way for this so this commit will
introduce extra flushes.
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14089>
(cherry picked from commit 573d6451335a0b3c947aa2823619e31017d0362c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5c982b332396d8d7ef48608055e8f871305191d
Author: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
Date: Fri Dec 10 11:08:21 2021 +0200
v3dv: Fix V3DV_HAS_SURFACE preprocessor condition
Currently V3DV_HAS_SURFACE is always defined.
There is no WSI for Android in mesa3d, therefore WSI related extensions
should not be exposed.
1. Define V3DV_HAS_SURFACE only for platforms which has WSI implemented.
2. Rename V3DV_HAS_SURFACE -> V3DV_USE_WSI_PLATFORM to align naming
with other platforms.
Fixes dEQP-VK.wsi.android.surface#query_protected_capabilities
Fixes: 79e445143054 ("v3dv: move extensions table to v3dv_device")
Signed-off-by: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14144>
(cherry picked from commit fcfc4ddfccd5ab998409304c164b73b62bb3c480)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b5c69dab1b5ddfe6fb8abddb5b5203f2a8c5b42
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Dec 13 10:21:47 2021 +1000
crocus: cleanup bo exports for external objects
This might have led to a leak in firefox/webrender/webgl scenarios
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14167>
(cherry picked from commit 76da4569544f8b08de0d3044b7e4bc74a6a1df45)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7dd3b99eabd763ac540d3359a219819b9eaf78b8
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Tue Nov 30 01:18:48 2021 +0100
android: add support for classic dri-drivers (v2)
(v1) Changelog:
-Ddri-drivers option is added in MESON_GEN_NINJA
$(foreach ) cycle copies *_dri.so files to /vendor/lib{64}/dri/
(v2) Changelog
Remove unwanted Symlinks created for classic dri drivers
Update the comments describing each step
Rename .symlinks.timestamp to .targets.timestamp
Squash all the changes in one commit to facilitate picking in mesa stable
HowTo:
BoardConfig.mk: BOARD_MESA3D_CLASSIC_DRIVERS defines the list of classic dri drivers
example: BOARD_MESA3D_CLASSIC_DRIVERS := i965
Fixes: 8621bd8d ("android: Add scripts to build using meson")
Cc: "21.3" "21.2" mesa-stable
Reviewed-by: Roman Stratiienko <r.stratiienko at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13973>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=29fcb94b9ea10c0c6a960fc0f2825f13e9344813
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Dec 2 14:42:16 2021 -0600
anv: Stop doing too much per-sample shading
We were setting anv_pipeline::sample_shading_enable based on
sampleShadingEnable without looking at minSampleShading. We would then
pass this value into nir_lower_wpos_center which would add sample_pos to
frag_coord. Then the back-end compiler picks up on the existence of
sample_pos and forces persample dispatch. This leads to doing
per-sample dispatch whenever sampleShadingEnable = VK_TRUE regardless of
the value of minSampleShading. This is almost certainly costing us
perf somewhere.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14022>
(cherry picked from commit 1f559930b6b7a633d93cd4e9cc4965b3f5e7c607)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d8d9dde7ba8c4dc3af8cf0c047fc23e09c818ae
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Thu Dec 9 18:20:55 2021 -0600
crocus: wm_prog_key::key_alpha_test uses GL enums
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14141>
(cherry picked from commit 4175ed50994a27b7d0b36471da58195670aa4192)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7aca70e17b99eab21bf1f8059d643003696edea7
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date: Fri Dec 10 17:15:39 2021 +0200
turnip: Fix operator precedence in address calculation macros for queries
Fixes crash in Oblivion, Skyrim, Crysis running through DXVK on 32b
systems.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5723
Fixes: 937dd76426b2b372a18be35e1416eed291524af7 "turnip: Implement VK_KHR_performance_query"
Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14148>
(cherry picked from commit c82d7e36174198b5dea3811fb11672d33aed4acb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=519ea90401817cc28463ed2ac1e3ea006e54714b
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Tue Nov 23 16:50:20 2021 +0100
aco: Clean up and fix quad group instructions with WQM.
According to the Vulkan spec chapter 9.25 Helper Invocations,
quad group operations have to be executed by helper invocations.
This commit cleans up the code for quad group instructions by
unifying the code path of quad broadcast with the others, and then
calling emit_wqm just once at the end.
Fixes: 93c8ebfa780ebd1495095e794731881aef29e7d3
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5570
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13929>
(cherry picked from commit 77db4e27b1814fb48036abe457d7fbe1a6965409)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=55d80bc20abb307353318f084cce896d557cd167
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Mon Sep 20 16:21:45 2021 -0700
intel/compiler: Don't predicate a WHILE if there is a CONT
Previously a predicated BREAK that appeared immediately before the WHILE
would get merged into the WHILE. This doesn't work if other flow
control (e.g., a CONT) can transfer directly to the WHILE.
On Intel platforms, this fixes the CTS test
dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional.
No shader-db changes on any Intel platform.
When this commit was first created (over a month before it is going to
land), there were some regressions that were prevented by other commits
in MR !13095. That does not appear to be the case now, so I don't know
what changed. Basically, the treatment of discard as a combination of
demote and terminate causes additional continues in some loops, and
those continues trigger this bug. The other commits from that MR
prevent those continues from being generated in the first place.
All Intel platforms had simlar fossil-db results. (Ice Lake shown)
Instructions in all programs: 144419989 -> 144419995 (+0.0%)
SENDs in all programs: 6947332 -> 6947332 (+0.0%)
Loops in all programs: 38277 -> 38277 (+0.0%)
Spills in all programs: 204075 -> 204075 (+0.0%)
Fills in all programs: 319480 -> 319480 (+0.0%)
A few shaders in Doom 2016 were hurt by one instruction each. It seems
likely that these shaders would have experienced at least some
mis-rendering.
Closes: #4213
Fixes: d13bcdb3a9f ("i965/fs: Extend predicated break pass to predicate WHILE.")
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14128>
(cherry picked from commit 4563261ad18c5e82d8fa869e87f938dc123e10b1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=69b8f9c6cd05a101dea7be86311fbcb1f9cfef83
Author: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
Date: Fri Dec 3 18:38:27 2021 +0200
v3dv: Fix dEQP-VK.info#instance_extensions test
When mesa3d is built without VK_USE_PLATFORM_DISPLAY_KHR definition,
dEQP test fails:
dEQP : Test case 'dEQP-VK.info.instance_extensions'..
dEQP : Fail (Extension VK_KHR_get_display_properties2 is missing
dependency: VK_KHR_display)
dEQP : DONE!
Enable KHR_get_display_properties2 only if VK_USE_PLATFORM_DISPLAY_KHR
is enabled.
Fixes: f884c2e3be36 ("v3dv: implement VK_KHR_get_display_properties2")
Signed-off-by: Roman Stratiienko <roman.o.stratiienko at globallogic.com>
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14047>
(cherry picked from commit 72db15913f63344cd8f01e6682c2079727762d3b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0cc65a565cb9ae52e7e20d57c3fa783e1ae4fc5f
Author: James Jones <jajones at nvidia.com>
Date: Fri Nov 19 11:50:18 2021 -0800
gbm: Don't pass default usage flags on ABIs < 1
Older drivers will not expect any flags from the
GBM front-end when modifiers are in use, and will
likely fail the allocation or handle them
incorrectly as a result. Only specify usage flags
when allocating from a backend with an ABI >= 1,
as that's the ABI version that added support for
specifying usage flags along with modifiers.
Fixes: ad50b47a14e9 ("gbm: assume USE_SCANOUT in create_with_modifiers")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5709
Signed-off-by: James Jones <jajones at nvidia.com>
Reviewed-by: Simon Ser <contact at emersion.fr>
Tested-by: Olivier Fourdan <ofourdan at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14049>
(cherry picked from commit c2550d1b7ca8146283265ce6f4267fa2b3591946)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d1f28201545a6a264226507f9eb779f22121345d
Author: Francisco Jerez <currojerez at riseup.net>
Date: Mon Nov 29 23:45:50 2021 -0800
intel/fs/xehp: Teach SWSB pass about the exec pipeline of FS_OPCODE_PACK_HALF_2x16_SPLIT.
This virtual instruction is translated into multiple half float
physical instructions, even though its destination is typically of
integer type, which prevents the software scoreboard pass from
inferring the correct execution pipeline for the virtual instruction
on XeHP+ platforms. Teach the SWSB lowering pass about this
inconsistency between the IR and physical instruction types.
Fixes among other tests:
dEQP-GLES31.functional.shaders.builtin_functions.pack_unpack.packhalf2x16_compute
Fixes: d4537770bbf ("intel/fs: Add helper functions inferring sync and exec pipeline of an instruction.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5685
Reported-by: Tapani Pälli <tapani.palli at intel.com>
Tested-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14002>
(cherry picked from commit de55fd358fa4b3e3620145c71557090403b8ec6c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=898308f1483cb3091eb7ea02ab2a07c89b6fae93
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Thu Nov 18 22:43:36 2021 -0500
panfrost: Don't shadow Mesa's fui()
Will fix a compiler error when we #include the Valhall disassembler
header from pandecode.
Fixes: 688827f3c52 ("pan/va: Add disassembler generator")
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14063>
(cherry picked from commit 745d7db74813b8e1ce52c879e0bbffde2ca6e6c1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4b38a272b65fa524dcf9fa83b4ff8cdcd9c113ee
Author: Jakob Bornecrantz <jakob at collabora.com>
Date: Sun Dec 5 17:32:20 2021 +0000
vulkan-device-select: Don't leak drmDevicePtr
ASAN found a leak:
```
Direct leak of 1440 byte(s) in 10 object(s) allocated from:
#0 0x4a9a92 in calloc (build-Monado-CMake/src/xrt/targets/service/monado-service+0x4a9a92)
#1 0x7fdf82afed06 in drmDeviceAlloc build-drm/../drm/xf86drm.c:3933:14
#2 0x7fdf82b00203 in drmProcessPciDevice build-drm/../drm/xf86drm.c:3965:11
#3 0x7fdf82b00203 in process_device build-drm/../drm/xf86drm.c:4359:16
#4 0x7fdf82b0485e in drmGetDevice2 build-drm/../drm/xf86drm.c:4528:15
#5 0x7fdf70751113 in device_select_find_xcb_pci_default ../src/vulkan/device-select-layer/device_select_x11.c:95:13
#6 0x7fdf70751113 in get_default_device ../src/vulkan/device-select-layer/device_select_layer.c:395:21
#7 0x7fdf70751113 in device_select_EnumeratePhysicalDevices ../src/vulkan/device-select-layer/device_select_layer.c:456:33
```
Cc: mesa-stable
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14068>
(cherry picked from commit 555f93cdcd9e8f41b860513bcfedc85076f98ff0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=26a01fc07a797e1bcc471c33581f6161e97d88e1
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Oct 28 13:47:41 2021 +0300
nir/lower_io: include the variable access in the lowered intrinsic
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13718>
(cherry picked from commit f98984ad1390098f2a5cf5d8770b35ad8fcf6d6a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0ce6f5f587d0e67eff8bde484a31e1a35c55685
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Oct 27 19:02:38 2021 +0300
intel/nir: preserve access value when duping intrinsic
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 6339aba775ecdc ("intel/compiler: Lower SSBO and shared loads/stores in NIR")
Reviewed-by: Caio Oliveira <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13718>
(cherry picked from commit 7661237a313cdac13aee866041963a1f00c13f3a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0025ef9880e444cc8371048a76ff8f1a868b4ab3
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Thu Dec 2 10:44:10 2021 +0200
anv: allow VK_IMAGE_LAYOUT_UNDEFINED as final layout
From VK_KHR_synchronization2:
"Image memory barriers that do not perform an image layout
transition can be specified by setting oldLayout equal to
newLayout.
E.g. the old and new layout can both be set to
VK_IMAGE_LAYOUT_UNDEFINED, without discarding data in the
image."
v2: make assert more readable (Lionel Landwerlin)
Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14008>
(cherry picked from commit d44d2e823f6fae31bff5876835717b64149414c2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=04ccbf5fead10904836aa504079c4c92bbe16c20
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Nov 16 14:25:08 2021 +0200
nir/opt_deref: don't try to cast empty structures
Found while running valgrind :
==3583454== Invalid read of size 4
==3583454== at 0xF48336: glsl_get_struct_field_offset (nir_types.cpp:84)
==3583454== by 0xC7CD0D: opt_replace_struct_wrapper_cast (nir_deref.c:1068)
==3583454== by 0xC7CDD9: opt_deref_cast (nir_deref.c:1087)
==3583454== by 0xC7DD8E: nir_opt_deref_impl (nir_deref.c:1369)
==3583454== by 0xC7DF4E: nir_opt_deref (nir_deref.c:1428)
==3583454== by 0xA63F3C: brw_kernel_from_spirv (brw_kernel.c:325)
==3583454== by 0xA3BC2C: main (intel_clc.c:481)
==3583454== Address 0xe4f7e88 is 24 bytes after a block of size 48 in arena "client"
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13952>
(cherry picked from commit 8e568d3f00b31344bc86a7ee1d8e57eb430314a5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=16e281c4aa72e7af15de775b7c0b526e9fa7a37b
Author: Eric Engestrom <eric at engestrom.ch>
Date: Wed Dec 1 19:48:29 2021 +0000
.pick_status.json: Update to a65285f54be6d756a8a558f638c18bb4f075222c
More information about the mesa-commit
mailing list