Mesa (main): radv: re-enable fast clears for images that support comp-to-single

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Dec 28 14:44:35 UTC 2021


Module: Mesa
Branch: main
Commit: 01f1bd4dfdb4f4d70fedfc999c99df9089d2f4ef
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=01f1bd4dfdb4f4d70fedfc999c99df9089d2f4ef

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon Nov 29 16:34:47 2021 +0100

radv: re-enable fast clears for images that support comp-to-single

This optimized path was disabled, oops.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14176>

---

 src/amd/vulkan/radv_meta_clear.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
index 0ed9db3d183..3a85fe295e5 100644
--- a/src/amd/vulkan/radv_meta_clear.c
+++ b/src/amd/vulkan/radv_meta_clear.c
@@ -1820,7 +1820,9 @@ radv_can_fast_clear_color(struct radv_cmd_buffer *cmd_buffer, const struct radv_
    if (!radv_format_pack_clear_color(iview->vk_format, clear_color, &clear_value))
       return false;
 
-   if (!radv_image_has_clear_value(iview->image) && (clear_color[0] != 0 || clear_color[1] != 0))
+   /* Images that support comp-to-single clears don't have clear values. */
+   if (!iview->image->support_comp_to_single &&
+       !radv_image_has_clear_value(iview->image) && (clear_color[0] != 0 || clear_color[1] != 0))
       return false;
 
    if (radv_dcc_enabled(iview->image, iview->base_mip)) {



More information about the mesa-commit mailing list