Mesa (main): radv: stop checking buffer size in vkCreateBuffer()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Dec 29 15:23:43 UTC 2021


Module: Mesa
Branch: main
Commit: 4942e108909bbe0f53ec5fd52a3c7ae14c60abe6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4942e108909bbe0f53ec5fd52a3c7ae14c60abe6

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Dec 29 10:29:05 2021 +0100

radv: stop checking buffer size in vkCreateBuffer()

This was added to fix dEQP-VK.api.buffer.basic.size_max_uint64 but
with VK_KHR_maintenance4 this is now considered invalid usage.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14331>

---

 src/amd/ci/radv-skips.txt    | 4 ++++
 src/amd/vulkan/radv_device.c | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/amd/ci/radv-skips.txt b/src/amd/ci/radv-skips.txt
index 521123c7738..9b9c0748e42 100644
--- a/src/amd/ci/radv-skips.txt
+++ b/src/amd/ci/radv-skips.txt
@@ -7,3 +7,7 @@ dEQP-VK.wsi.*
 
 # Exclude this test which timeout most of the time.
 dEQP-VK.memory.pipeline_barrier.transfer_src_transfer_dst.1048576
+
+# Exclude this test because it fails with VK_KHR_maintenance4 and the CTS fix
+# hasn't landed yet.
+dEQP-VK.api.buffer.basic.size_max_uint64
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 099337bcc2d..1537f110816 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -6468,9 +6468,6 @@ radv_CreateBuffer(VkDevice _device, const VkBufferCreateInfo *pCreateInfo,
    RADV_FROM_HANDLE(radv_device, device, _device);
    struct radv_buffer *buffer;
 
-   if (pCreateInfo->size > RADV_MAX_MEMORY_ALLOCATION_SIZE)
-      return VK_ERROR_OUT_OF_DEVICE_MEMORY;
-
    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO);
 
    buffer = vk_alloc2(&device->vk.alloc, pAllocator, sizeof(*buffer), 8,



More information about the mesa-commit mailing list