Mesa (main): r600/sfn: Remove unused AluInstruction members.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Dec 30 07:54:19 UTC 2021


Module: Mesa
Branch: main
Commit: 94351c94dbab22d0ad0f524dbf945795fb554a16
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=94351c94dbab22d0ad0f524dbf945795fb554a16

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Aug  9 17:33:04 2021 -0700

r600/sfn: Remove unused AluInstruction members.

Fix defects reported by Coverity Scan.

uninit_member: Non-static class member m_omod is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member m_pred_sel is not initialized in this constructor nor in any functions that it calls.

Suggested-by: Emma Anholt <emma at anholt.net>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12294>

---

 src/gallium/drivers/r600/sfn/sfn_instruction_alu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/gallium/drivers/r600/sfn/sfn_instruction_alu.h b/src/gallium/drivers/r600/sfn/sfn_instruction_alu.h
index 383fa3bafb5..ecf563c8a0e 100644
--- a/src/gallium/drivers/r600/sfn/sfn_instruction_alu.h
+++ b/src/gallium/drivers/r600/sfn/sfn_instruction_alu.h
@@ -133,8 +133,6 @@ private:
    PValue m_dest;
    std::vector<PValue> m_src;
    AluOpFlags m_flags;
-   AluDstModifiers m_omod;
-   AluPredSel m_pred_sel;
    AluBankSwizzle m_bank_swizzle;
    ECFAluOpCode m_cf_type;
 };



More information about the mesa-commit mailing list