Mesa (master): panfrost: Don't memset the last attribute buffer entry twice

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Feb 2 09:33:21 UTC 2021


Module: Mesa
Branch: master
Commit: 63d9e412ecebfa786021376556893879412e0bf0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=63d9e412ecebfa786021376556893879412e0bf0

Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Thu Jan 28 10:23:29 2021 +0100

panfrost: Don't memset the last attribute buffer entry twice

It's already done a few lines below.

Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Italo Nicola <italonicola at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8808>

---

 src/gallium/drivers/panfrost/pan_cmdstream.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c
index 334609fa80b..88003444aae 100644
--- a/src/gallium/drivers/panfrost/pan_cmdstream.c
+++ b/src/gallium/drivers/panfrost/pan_cmdstream.c
@@ -1372,11 +1372,6 @@ panfrost_emit_vertex_data(struct panfrost_batch *batch,
         struct mali_attribute_buffer_packed *bufs =
                 (struct mali_attribute_buffer_packed *) S.cpu;
 
-        /* Determine (n + 1)'th index to suppress prefetch on Bifrost */
-        unsigned last = (nr_images + vs->attribute_count) *
-                        ((ctx->instance_count > 1) ? 2 : 1);
-        memset(bufs + last, 0, sizeof(*bufs));
-
         struct mali_attribute_packed *out =
                 (struct mali_attribute_packed *) T.cpu;
 



More information about the mesa-commit mailing list