Mesa (master): nir/algebraic: Partially revert 3f782cdd2591

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Feb 8 02:49:11 UTC 2021


Module: Mesa
Branch: master
Commit: ed138f2861a6cbc39085e0b506c90d35a3b3175b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed138f2861a6cbc39085e0b506c90d35a3b3175b

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Jan 17 13:33:20 2020 -0800

nir/algebraic: Partially revert 3f782cdd2591

I'm not sure what the logic was, but there is no opportunity for
anything to flush to zero here.  'a' is a Boolean value, and b2f
produces 1.0 or 0.0.

This was originally part of
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3765/.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Cc: Andres Gomez <agomez at igalia.com>
Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Cc: Connor Abbott <cwabbott0 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8910>

---

 src/compiler/nir/nir_opt_algebraic.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py
index 8eec5608e91..c719cd096f8 100644
--- a/src/compiler/nir/nir_opt_algebraic.py
+++ b/src/compiler/nir/nir_opt_algebraic.py
@@ -466,7 +466,7 @@ optimizations.extend([
    (('ine', ('iadd', a, b), a), ('ine', b, 0)),
 
    (('feq', ('b2f', 'a at 1'), 0.0), ('inot', a)),
-   (('~fneu', ('b2f', 'a at 1'), 0.0), a),
+   (('fneu', ('b2f', 'a at 1'), 0.0), a),
    (('ieq', ('b2i', 'a at 1'), 0),   ('inot', a)),
    (('ine', ('b2i', 'a at 1'), 0),   a),
 



More information about the mesa-commit mailing list