Mesa (master): radv/winsys: stop zeroing radv_amdgpu_cs_request

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Feb 8 08:42:43 UTC 2021


Module: Mesa
Branch: master
Commit: e498f25ff4ea9a3382cbfa558205812a312bbd85
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e498f25ff4ea9a3382cbfa558205812a312bbd85

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri Feb  5 15:26:09 2021 +0100

radv/winsys: stop zeroing radv_amdgpu_cs_request

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8859>

---

 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index 1ae78aa4ec8..275e5d3fe94 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
@@ -853,7 +853,7 @@ radv_amdgpu_winsys_cs_submit_chained(struct radeon_winsys_ctx *_ctx,
 	struct radv_amdgpu_cs *cs0 = radv_amdgpu_cs(cs_array[0]);
 	struct radv_amdgpu_winsys *aws = cs0->ws;
 	struct drm_amdgpu_bo_list_entry *handles = NULL;
-	struct radv_amdgpu_cs_request request = {0};
+	struct radv_amdgpu_cs_request request;
 	struct amdgpu_cs_ib_info ibs[2];
 	unsigned number_of_ibs = 1;
 	unsigned num_handles = 0;
@@ -901,6 +901,7 @@ radv_amdgpu_winsys_cs_submit_chained(struct radeon_winsys_ctx *_ctx,
 	}
 
 	request.ip_type = cs0->hw_ip;
+	request.ip_instance = 0;
 	request.ring = queue_idx;
 	request.number_of_ibs = number_of_ibs;
 	request.ibs = ibs;
@@ -939,7 +940,7 @@ radv_amdgpu_winsys_cs_submit_fallback(struct radeon_winsys_ctx *_ctx,
 	struct radv_amdgpu_ctx *ctx = radv_amdgpu_ctx(_ctx);
 	struct radv_amdgpu_fence *fence = (struct radv_amdgpu_fence *)_fence;
 	struct drm_amdgpu_bo_list_entry *handles = NULL;
-	struct radv_amdgpu_cs_request request = {0};
+	struct radv_amdgpu_cs_request request;
 	struct amdgpu_cs_ib_info *ibs;
 	struct radv_amdgpu_cs *cs0;
 	struct radv_amdgpu_winsys *aws;
@@ -988,6 +989,7 @@ radv_amdgpu_winsys_cs_submit_fallback(struct radeon_winsys_ctx *_ctx,
 	}
 
 	request.ip_type = cs0->hw_ip;
+	request.ip_instance = 0;
 	request.ring = queue_idx;
 	request.handles = handles;
 	request.num_handles = num_handles;
@@ -1184,9 +1186,8 @@ radv_amdgpu_winsys_cs_submit_sysmem(struct radeon_winsys_ctx *_ctx,
 			return result;
 		}
 
-		memset(&request, 0, sizeof(request));
-
 		request.ip_type = cs0->hw_ip;
+		request.ip_instance = 0;
 		request.ring = queue_idx;
 		request.handles = handles;
 		request.num_handles = num_handles;



More information about the mesa-commit mailing list