Mesa (master): anv/formats: Advertise linear sampling on depth formats
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Feb 17 23:49:26 UTC 2021
Module: Mesa
Branch: master
Commit: 56d005c21c1e679c62214e89497766d097da6f38
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=56d005c21c1e679c62214e89497766d097da6f38
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Feb 17 15:08:12 2021 -0600
anv/formats: Advertise linear sampling on depth formats
They've all supported it since either forever or Iron Lake which is
equivalent to forever for Vulkan.
>From Kenneth Graunke's GitLab review:
"Linear blending of depth buffer data is usually fairly nonsense
(something's 2 meters away? another thing's 6 meters away? let's
just report 4 meters?)...but it's definitely a thing we can do, so
we may as well let apps do it, and trust them not when it doesn't
make sense."
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9110>
---
src/intel/vulkan/anv_formats.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 71538e93aff..9d09e6bf016 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -571,6 +571,9 @@ anv_get_image_format_features(const struct gen_device_info *devinfo,
VK_FORMAT_FEATURE_TRANSFER_SRC_BIT |
VK_FORMAT_FEATURE_TRANSFER_DST_BIT;
+ if (aspects & VK_IMAGE_ASPECT_DEPTH_BIT)
+ flags |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT;
+
if ((aspects & VK_IMAGE_ASPECT_DEPTH_BIT) && devinfo->gen >= 9)
flags |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_MINMAX_BIT_EXT;
More information about the mesa-commit
mailing list