Mesa (master): nir/ttn: Silence some warnings at -Og
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Feb 18 21:15:30 UTC 2021
Module: Mesa
Branch: master
Commit: 5cf6c9e609c1e1b9c2590c0af6f72e0ea2390e69
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cf6c9e609c1e1b9c2590c0af6f72e0ea2390e69
Author: Adam Jackson <ajax at redhat.com>
Date: Tue Jan 26 14:16:05 2021 -0500
nir/ttn: Silence some warnings at -Og
../src/gallium/auxiliary/nir/tgsi_to_nir.c: In function ‘ttn_mem’:
../src/gallium/auxiliary/nir/tgsi_to_nir.c:1724:15: warning: ‘op’ may be used uninitialized in this function [-Wmaybe-uninitialized]
1724 | instr = nir_intrinsic_instr_create(b->shader, op);
../src/gallium/auxiliary/nir/tgsi_to_nir.c:1697:15: warning: ‘op’ may be used uninitialized in this function [-Wmaybe-uninitialized]
1697 | instr = nir_intrinsic_instr_create(b->shader, op);
Add some more unreachable() to make this go away.
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8724>
---
src/gallium/auxiliary/nir/tgsi_to_nir.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c
index 75f63b3665b..0e42118ee87 100644
--- a/src/gallium/auxiliary/nir/tgsi_to_nir.c
+++ b/src/gallium/auxiliary/nir/tgsi_to_nir.c
@@ -1709,6 +1709,8 @@ ttn_mem(struct ttn_compile *c, nir_alu_dest dest, nir_ssa_def **src)
case TGSI_OPCODE_STORE:
op = nir_intrinsic_store_ssbo;
break;
+ default:
+ unreachable("unexpected buffer opcode");
}
add_ssbo_var(c, resource_index);
@@ -1738,6 +1740,8 @@ ttn_mem(struct ttn_compile *c, nir_alu_dest dest, nir_ssa_def **src)
case TGSI_OPCODE_STORE:
op = nir_intrinsic_image_deref_store;
break;
+ default:
+ unreachable("unexpected file opcode");
}
instr = nir_intrinsic_instr_create(b->shader, op);
More information about the mesa-commit
mailing list