Mesa (staging/21.0): 26 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Feb 26 19:47:17 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=10611abc1933944dcbe2966f65f70e38b0bb50e1
Author: Mauro Rossi <issor.oruam at gmail.com>
Date: Tue Feb 23 21:50:18 2021 +0100
android: pan/bi: reorder static dependencies in gallium/dri
libpanfrost_lib depends on libpanfrost_bifrost for 'bifrost_compile_shader_nir' symbol
libpanfrost_lib depends on libpanfrost_bifrost_disasm for 'disassemble_bifrost' symbol
LOCAL_STATIC_LIBRARIES requires proper ordering to make the symbols available
Fixes the following building error happening with Android P:
FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so
external/mesa/src/panfrost/lib/decode.c:534: error: undefined reference to 'disassemble_bifrost'
external/mesa/src/panfrost/lib/pan_shader.c:145: error: undefined reference to 'bifrost_compile_shader_nir'
Cc: 20.3 21.0 <mesa-stable at lists.freedesktop.org>
Fixes: 166630f ("android: pan/bi: Separate disasm/compiler targets")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9265>
(cherry picked from commit 97b7786e6be1adf5e023d3ebd1fe54bf25d3fd26)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc2132abda34b33dc53b20ab0d6024ab4e677c9c
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Feb 24 13:05:26 2021 +0100
radv: do not scale the depth bias for D16_UNORM depth surfaces
Scaling the depth bias doesn't seem correct with Vulkan. This is
probably the root cause of the shadow artifacts differences between
RADV and AMDVLK/AMDGPU-PRO.
Fix dEQP-VK.rasterization.depth_bias.d16_unorm.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2217
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9249>
(cherry picked from commit 8a47422d9778056b2263d5f253fab49dfed91486)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4482dc269b7b1434421fd24910c8f96c048df7e6
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 23 10:44:36 2021 -0500
nouveau_vieux: use align_calloc for the context to fix m32 crashes
Fixes: 3175b63a0dfa290 "mesa: don't allocate matrices with malloc"
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9220>
(cherry picked from commit f827b29234cb3dfa4ff07adbcf1550fd53e0a573)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4350d977580ca42bbeddde0c37e65ea6954fe887
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 23 10:44:36 2021 -0500
radeon,r200: use align_calloc for the context to fix m32 crashes
Fixes: 3175b63a0dfa290 "mesa: don't allocate matrices with malloc"
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9220>
(cherry picked from commit 81cf4bef7e83fe3174503d48b458f8596420fdd7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=50cd4585a58fb07a5061652218d0a0bb34223e75
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Feb 23 10:44:36 2021 -0500
i915: use align_calloc for the context to fix m32 crashes
Fixes: 3175b63a0dfa290 "mesa: don't allocate matrices with malloc"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4295
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9220>
(cherry picked from commit 75d5c1229e1fcc0e0885b35a1cc23e66a90aeb84)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=716651a9815405f9c142620c245a0cbaa7ac9331
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Feb 22 18:41:24 2021 +0200
anv: Fix wait_count missing increment
If we don't wait on anything, I bet it makes the QueuePresent faster,
but also completely wrong...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 02f94c33066eff ("anv: don't wait for completion of work on vkQueuePresent()")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4276
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9211>
(cherry picked from commit b0b1bf9957380ad967e900b40027668353b71df6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b722466dd2949ab5785f84f7b0811da5e54659f
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Feb 22 15:05:32 2021 +0000
aco/lower_phis: fix all_preds_uniform with continue_or_break
Found in a Death Stranding shader with loop unrolling disabled.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 9a089baff1a ("aco: optimize boolean phis with uniform selections")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9193>
(cherry picked from commit 75c9adf0398014b21ed9bbbd36f741b02b8f87f7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f53525e3b2594a429c25c518fdce71c65c35912
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Feb 22 18:41:24 2021 +0200
anv: don't wait for completion of work on vkQueuePresent()
Another mistake which is that we don't use the right wait API.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 829699ba632b2b ("anv: implement shareable timeline semaphores")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4276
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9188>
(cherry picked from commit 02f94c33066eff9e5de2077230affab1a1f3d063)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5d31b4896a91f92942cfe155688e11ddd30af96c
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Feb 22 13:57:37 2021 +0200
anv: reset binary syncobj to be signaled before submission
Before we introduced the submission thread in 829699ba632b2b, once we
returned from vkQueueSubmit, all signaled syncobj would have a
i915_request/dma-fence waiting to be signaled by some work that would
submitted to HW by i915.
After this submission thread that is no longer the case. We added a
few checks in places like vkQueuePresentKHR() to wait for the binary
semaphores to materialize before we would hand things over to the WSI
code.
Unfortunately 829699ba632b2b forgot to reset the signaled binary
semaphore.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 829699ba632b2b ("anv: implement shareable timeline semaphores")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4276
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9188>
(cherry picked from commit cb74cd816c0a0b1d6a715585414f8518cefbba5a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0da957d0e40ba91d32b60663ae3625df0181cd64
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date: Sat Jan 30 13:10:12 2021 -0800
Adjust dylib compatibility versions to match what was set by mesa-18.3's autotools-based builds
Cc: 20.3 21.0 <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4113
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Reviewed-by: Dylan Baker <dylan.c.baker at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8796>
(cherry picked from commit 38ae84b8daa1c2bc2f74093cf46ced5e252b04e5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=552c80c186dad7cf89b6b01d279e4148445f8e50
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Feb 22 15:57:01 2021 +1000
glx: proposed fix for setSwapInterval
When mesa gets a DRI2 1.1 connection (as experienced with
vmwware DDX) we don't get a pointer for this.
Don't explode just keep going.
Fixes: 60ebeb4608a8 ("glx: Implement GLX_EXT_swap_control for DRI2 and DRI3")
Reviewed-by: Adam Jackson <ajaX at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9184>
(cherry picked from commit 279d1705525026c15e7cae88f8fa752046db1c19)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d48b8d338ab16bea583d0d020fb662528246a613
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Fri Feb 19 15:58:16 2021 -0500
panfrost: Don't advertise OES_copy_image
We don't support it yet.
Fixes: 61d3ae6e0bd ("panfrost: Initial stub for Panfrost driver")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9164>
(cherry picked from commit 5eff64e3a318f911326499e9940ee773f6f58c21)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9dc551f3757871b4452abbb479092bdceeeac35c
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Feb 26 10:09:20 2021 -0800
.pick_status.json: Mark 38ce8d4d00c2b0e567b6dd36876cf171acb1dbc7 as backported
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a983ff51dce864494255e201f25a1a6b236752e4
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Fri Feb 19 11:51:16 2021 -0500
panfrost: Raise TEXTURE_BUFFER_OFFSET_ALIGNMENT
The blob advertises 64 for this, so let's use the same value. Small
alignments are observed to raise an IMPRECISE_FAULT at least on Bifrost.
As a bonus this forces cache line alignment which will help perf. Fixes
dEQP-GLES31.functional.texture.texture_buffer.render.as_vertex_texture.offset_1_alignments
Fixes: 5f7bafa316f ("panfrost: Enable ARB_texture_buffer_object")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9164>
(cherry picked from commit 3f21b089f8ee16f1b51ed64e9c203b073c015766)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f65884192caf05febb226db55df2f00295b25aec
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Feb 21 21:01:04 2021 +0100
radv: Don't use dedicated memory info to indicate sharing.
Can be used without sharing, so if only the dedicated memory info
is set we know it isn't shareable. Use that.
Fixes: a639d40f133 ("radv: add support for local bos. (v3)")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4330
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9176>
(cherry picked from commit 2d520b692354ded47dbc32d19c2be253727bc935)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ebc941a87c7fceae5298e0a8d171a79fc50cf4f
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date: Tue Jan 12 16:44:34 2021 -0800
Fall back on clock_gettime when timespec_get() is unavailable
Fixes: e3a8013de8ca "util/u_queue: add util_queue_fence_wait_timeout"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/1020
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4088
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Signed-off-by: Yurii Kolesnykov <root at yurikoles.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8482>
(cherry picked from commit 68a785e63fe848c7bcd48bce2095670926f97eea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=786fec1f53064e98d9915c108c06e44934f2579f
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sat Feb 13 20:21:55 2021 -0800
aco: Initialize ds_state.front.writeMask.
Fix defect reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value ds_state.front. Field ds_state.front.writeMask is uninitialized.
Fixes: d488d0fd7ba ("aco: add framework for testing isel and integration tests")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9033>
(cherry picked from commit 7cc83f237efe1fdba075d07b18450c4345d2dc7f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=048efe01c9ffc8e1952b95fd2ef35bc876b9ac8d
Author: Erico Nunes <nunes.erico at gmail.com>
Date: Sat Feb 20 14:24:09 2021 +0100
lima: fix max sampler views
If this is not defined, mesa may not deallocate sampler views,
which can result in memory leaks.
Just define it to the same as max texture samplers, like other
mesa drivers do.
Cc: mesa-stable
Signed-off-by: Erico Nunes <nunes.erico at gmail.com>
Reviewed-by: Vasily Khoruzhick <anarsoul at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9172>
(cherry picked from commit f3d47ba0c7596415b896297378ae5de0c4f30359)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7928d97c48c88f87bb3055c864b9e5756a57d9ea
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Tue Jan 12 12:23:16 2021 -0800
nir/algebraic: Fix some min/max of b2f replacements
fmin(-A, -B) is -fmax(A, B), and fmax(-A, -B) is -fmin(A, B). Therefore
the logic joining A and B should toggle between ior and iand for the
negated versions.
At the very least, a shader from Euro Truck Simulator 2 in shader-db is
affected by this. The KIL instruction in the (ARB assembly) shader ends
up with the wrong logic. This is _probably_ the source of
https://gitlab.freedesktop.org/mesa/mesa/-/issues/1346.
That said, the issue mentions that Mesa 18.0.5 works, but commit
68420d8322c ("nir: Simplify min and max of b2f") was added in 17.3.
Moreover, I was not able to reproduce the error in the ETS2 shader from
shader-db from any Mesa commit near the time the original fd.o bugzilla
was submitted (December 2018). :shrug:
In fact, the current error in that shader starts with 9167324a86b
("nir/algebraic: Mark some logic-joined comparison reductions as
exact"). That's a bit of a red herring as 9167324a86b just sets off a
chain of replacements that eventually leads to the incorrect min/max of
b2f patterns fixed by this commit.
The other affected shaders in the shader-db results are from Cargo
Commander. These are also ARB assembly shaders.
I think any ARB assembly shader that uses the pattern
SLT r0, ...;
...
KIL -r0;
will suffer from issues related to this.
This change fixes the piglit
tests/spec/arb_fragment_program/kil-of-slt.shader_test test added in
https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/454.
shader-db results:
All Gen6+ platforms had similar result. (Ice Lake shown)
total instructions in shared programs: 20034604 -> 20034486 (<.01%)
instructions in affected programs: 3885 -> 3767 (-3.04%)
helped: 47
HURT: 2
helped stats (abs) min: 2 max: 4 x̄: 2.64 x̃: 2
helped stats (rel) min: 2.33% max: 8.33% x̄: 3.48% x̃: 3.39%
HURT stats (abs) min: 3 max: 3 x̄: 3.00 x̃: 3
HURT stats (rel) min: 13.64% max: 16.67% x̄: 15.15% x̃: 15.15%
95% mean confidence interval for instructions value: -2.83 -1.99
95% mean confidence interval for instructions %-change: -3.84% -1.60%
Instructions are helped.
total cycles in shared programs: 979881379 -> 979879406 (<.01%)
cycles in affected programs: 119873 -> 117900 (-1.65%)
helped: 46
HURT: 3
helped stats (abs) min: 10 max: 756 x̄: 45.41 x̃: 26
helped stats (rel) min: 0.53% max: 19.72% x̄: 1.67% x̃: 1.26%
HURT stats (abs) min: 28 max: 56 x̄: 38.67 x̃: 32
HURT stats (rel) min: 1.44% max: 3.54% x̄: 2.75% x̃: 3.27%
95% mean confidence interval for cycles value: -70.83 -9.70
95% mean confidence interval for cycles %-change: -2.23% -0.57%
Cycles are helped.
Iron Lake and GM45 had similar results. (Iron Lake shown)
total instructions in shared programs: 8115098 -> 8115076 (<.01%)
instructions in affected programs: 2592 -> 2570 (-0.85%)
helped: 32
HURT: 2
helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1
helped stats (rel) min: 0.88% max: 2.70% x̄: 1.35% x̃: 1.31%
HURT stats (abs) min: 5 max: 5 x̄: 5.00 x̃: 5
HURT stats (rel) min: 17.24% max: 18.52% x̄: 17.88% x̃: 17.88%
95% mean confidence interval for instructions value: -1.15 -0.15
95% mean confidence interval for instructions %-change: -1.83% 1.39%
Inconclusive result (%-change mean confidence interval includes 0).
total cycles in shared programs: 238189718 -> 238189802 (<.01%)
cycles in affected programs: 75076 -> 75160 (0.11%)
helped: 3
HURT: 31
helped stats (abs) min: 2 max: 130 x̄: 44.67 x̃: 2
helped stats (rel) min: 0.18% max: 5.70% x̄: 2.02% x̃: 0.19%
HURT stats (abs) min: 2 max: 70 x̄: 7.03 x̃: 4
HURT stats (rel) min: 0.07% max: 6.41% x̄: 0.53% x̃: 0.15%
95% mean confidence interval for cycles value: -7.27 12.21
95% mean confidence interval for cycles %-change: -0.33% 0.94%
Inconclusive result (value mean confidence interval includes 0).
No fossil-db changes on any Intel platform.
Fixes: 68420d8322c ("nir: Simplify min and max of b2f")
Closes: #1346
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9122>
(cherry picked from commit 7e127c1fca6bd934469f4803dde54842fbd100da)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=670f26946443fb6dec3f23ebb0eedc01f2d2995d
Author: Yevhenii Kharchenko <yevhenii.kharchenko at globallogic.com>
Date: Thu Feb 4 12:23:30 2021 +0200
st/mesa: fix PBO download for TEXTURE_1D_ARRAY textures
Fixes 'nir_tex_src_coord' param was provided to NIR 'txf' operation as a
vec3 for TEXTURE_1D_ARRAY target, causing an assert.
Only following targets require vec3: TEXTURE_2D_ARRAY, TEXTURE_3D,
TEXTURE_CUBE, TEXTURE_CUBE_ARRAY. The rest must use vec2.
Packing layer value into Y-coordinate the same way it was done in
'create_fs' in commit 2bf6dfac.
Fixes: a01ad311 ("st/mesa: Add NIR versions of the PBO upload/download
shaders. ")
Signed-off-by: Yevhenii Kharchenko <yevhenii.kharchenko at globallogic.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9014>
(cherry picked from commit 1516b6bd9a5307ad37f10b1b1c614e399f4bce2d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a59d4e79778f1d4d29bcce05b17deda65758cc95
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Feb 18 23:34:41 2021 +0100
radv: set correct value for OFFCHIP_BUFFERING on GFX10+
Higher values break tessellation. I was only able to reproduce this
by switching back/from AMDVLK which was really weird...
According to Marek (1c6eca23fdd8), it looks like it's related to
register shadowing and PAL enables it, that probably explains a bit.
Copied from PAL and RadeonSI.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4207
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2498
Fixes: 74d69299d16 ("radv/gfx10: double the number of tessellation offchip buffers per SE")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9141>
(cherry picked from commit e3bdf815b790be61f5141afe630bb8eb1453a0ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=24f7b491851cb994e0bee4d7be9510cfe47b1bd7
Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date: Tue Feb 16 21:16:26 2021 -0500
pan/bi: Use explicit move even for RT#0 of MRT
Otherwise we get a bad RA if RT 0 = RT 3 (for example), fixes
dEQP-GLES31.functional.shaders.opaque_type_indexing.sampler.const_literal.fragment.sampler2d
Fixes: a6f1500bedd ("pan/bi: Workaround BLEND precolour with explicit moves")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
(cherry picked from commit ed29a2beb80e53e6a9985786c77350d963e860e7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd0b20069005bdc9a66fbc0fa8a090aca11b8334
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Thu Feb 18 11:13:25 2021 -0800
microsoft/clc: Use driver_location for metadata instead of re-computing offsets
Fixes: ff05da7f ("microsoft: Add CLC frontend and kernel/compute support to DXIL converter")
Reviewed-By: Bill Kristiansen <billkris at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9138>
(cherry picked from commit 5b0a10823b3f80f5d28cd460a57b7fa435d34ee8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2d2ce5226bfa428fc1565b0727f587cbfd9e1f1a
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Thu Feb 18 11:05:43 2021 -0800
microsoft/clc: Move inline samplers to the end of the variable list
Since inline samplers are uniforms, just like kernel args, and
nir_lower_vars_to_explicit_types will assign driver_location based
on order in the variable list, move the inline samplers to the end
of the list to prevent them from creating gaps in the kernel arg
offsets.
Fixes: ff05da7f ("microsoft: Add CLC frontend and kernel/compute support to DXIL converter")
Reviewed-By: Bill Kristiansen <billkris at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9138>
(cherry picked from commit 3ee8f2ccba93a984f895eeff6d908979e22215b3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc0c0b641c61af10aeed28f7c5e317882db64501
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Thu Feb 18 11:04:23 2021 -0800
microsoft/clc: Fix wrap modes for inline samplers for integer textures
Fixes: ff05da7f ("microsoft: Add CLC frontend and kernel/compute support to DXIL converter")
Reviewed-By: Bill Kristiansen <billkris at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9138>
(cherry picked from commit d773257012a2fa3d67144263387cff670cccc97a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c83faad08511b4359ba339f8e2c41909b3f84b7
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Thu Feb 18 10:28:20 2021 -0800
microsoft/clc: Let lower_vars_to_explicit_types fill kernel input driver_location
Importantly, also run that before mucking with the variable list via image lowering,
which removes and inserts variables, making the driver_location no longer line up
with metadata.
Fixes: ff05da7f ("microsoft: Add CLC frontend and kernel/compute support to DXIL converter")
Reviewed-By: Bill Kristiansen <billkris at microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9138>
(cherry picked from commit 9da8179a1e8c835749c6c97f4adc31d0428cae8e)
More information about the mesa-commit
mailing list