Mesa (master): pan/mdg: Fix promoted uniform moves with 64-bit types

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jan 1 03:14:23 UTC 2021


Module: Mesa
Branch: master
Commit: 97929b1aaf4d0bbb9214cd7a31ee938c78f7e8bc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=97929b1aaf4d0bbb9214cd7a31ee938c78f7e8bc

Author: Icecream95 <ixn at keemail.me>
Date:   Mon Sep  7 21:29:28 2020 +1200

pan/mdg: Fix promoted uniform moves with 64-bit types

The move source is the second src, not the first one.

Fixes: 5e5ea25a0da ("pan/mdg: Explicitly type 64-bit uniform moves")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8264>

---

 src/panfrost/midgard/mir_promote_uniforms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/panfrost/midgard/mir_promote_uniforms.c b/src/panfrost/midgard/mir_promote_uniforms.c
index 239020dd219..525ce59b35b 100644
--- a/src/panfrost/midgard/mir_promote_uniforms.c
+++ b/src/panfrost/midgard/mir_promote_uniforms.c
@@ -195,7 +195,7 @@ midgard_promote_uniforms(compiler_context *ctx)
                         unsigned type_size = nir_alu_type_get_type_size(ins->dest_type);
                         midgard_instruction mov = v_mov(promoted, ins->dest);
                         mov.dest_type = nir_type_uint | type_size;
-                        mov.src_types[0] = mov.dest_type;
+                        mov.src_types[1] = mov.dest_type;
 
                         uint16_t rounded = mir_round_bytemask_up(mir_bytemask(ins), type_size);
                         mir_set_bytemask(&mov, rounded);



More information about the mesa-commit mailing list