Mesa (master): radv: disable A2 SNORM/SSCALED/SINT for texel buffers & images on all gens

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jan 4 17:31:38 UTC 2021


Module: Mesa
Branch: master
Commit: 3ae1c6a4fb9bed5cb215cffc4c8d90b26add3777
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ae1c6a4fb9bed5cb215cffc4c8d90b26add3777

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon Jan  4 16:22:23 2021 +0100

radv: disable A2 SNORM/SSCALED/SINT for texel buffers & images on all gens

AMDVLK and AMDGPU-PRO also don't support these formats for texel
buffers and images.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3386
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8315>

---

 src/amd/vulkan/radv_formats.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index c07411ef0dd..63dd6c55056 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -784,13 +784,10 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
 	case VK_FORMAT_A2B10G10R10_SSCALED_PACK32:
 	case VK_FORMAT_A2R10G10B10_SINT_PACK32:
 	case VK_FORMAT_A2B10G10R10_SINT_PACK32:
-		if (physical_device->rad_info.chip_class <= GFX8 &&
-		    physical_device->rad_info.family != CHIP_STONEY) {
-			buffer &= ~(VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT |
-			            VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT);
-			linear = 0;
-			tiled = 0;
-		}
+		buffer &= ~(VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT |
+			    VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT);
+		linear = 0;
+		tiled = 0;
 		break;
 	default:
 		break;



More information about the mesa-commit mailing list