Mesa (master): panfrost: Disable AFBC of 3D, 2D arrays

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: abca80cf30879526d79230606f75371af0bcd211
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=abca80cf30879526d79230606f75371af0bcd211

Author: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Date:   Mon Jan 11 16:00:41 2021 -0500

panfrost: Disable AFBC of 3D, 2D arrays

These are broken at least on v7 and likely elsewhere. Until this can be
investigated, let's disable it so we don't break dEQP-GLES3.

Example of a failing test without this patch:

dEQP-GLES3.functional.texture.filtering.2d_array.sizes.128x32x64_nearest

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Tested-by: Maciej Matuszczyk <maccraft123mc at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8427>

---

 src/gallium/drivers/panfrost/pan_resource.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_resource.c b/src/gallium/drivers/panfrost/pan_resource.c
index b5ed8b8aa5d..9c534497372 100644
--- a/src/gallium/drivers/panfrost/pan_resource.c
+++ b/src/gallium/drivers/panfrost/pan_resource.c
@@ -534,7 +534,6 @@ panfrost_should_afbc(struct panfrost_device *dev, const struct panfrost_resource
 
         switch (pres->base.target) {
         case PIPE_TEXTURE_2D:
-        case PIPE_TEXTURE_2D_ARRAY:
         case PIPE_TEXTURE_RECT:
                 break;
 
@@ -544,7 +543,12 @@ panfrost_should_afbc(struct panfrost_device *dev, const struct panfrost_resource
                 if (dev->arch < 7)
                         return false;
 
-                break;
+                /* fallthrough */
+        case PIPE_TEXTURE_2D_ARRAY:
+                /* Both 3D and 2D arrays are having issues on dEQP-GLES3, hide
+                 * support until these bugs can be sorted so we don't introduce
+                 * flakes */
+                return false;
 
         default:
                 return false;