Mesa (master): aco/ra: Remove unused function parameter

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 13 18:31:39 UTC 2021


Module: Mesa
Branch: master
Commit: d2d0096c0cf7a4fa71dfd619dbb70bd596f1dfa4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d2d0096c0cf7a4fa71dfd619dbb70bd596f1dfa4

Author: Tony Wasserka <tony.wasserka at gmx.de>
Date:   Thu Oct 29 11:55:28 2020 +0100

aco/ra: Remove unused function parameter

Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7799>

---

 src/amd/compiler/aco_register_allocation.cpp | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp
index 57334045d77..71c47b1960d 100644
--- a/src/amd/compiler/aco_register_allocation.cpp
+++ b/src/amd/compiler/aco_register_allocation.cpp
@@ -1199,7 +1199,6 @@ std::pair<PhysReg, bool> get_reg_impl(ra_ctx& ctx,
 bool get_reg_specified(ra_ctx& ctx,
                        RegisterFile& reg_file,
                        RegClass rc,
-                       std::vector<std::pair<Operand, Definition>>& parallelcopies,
                        aco_ptr<Instruction>& instr,
                        PhysReg reg)
 {
@@ -1270,7 +1269,7 @@ PhysReg get_reg(ra_ctx& ctx,
          if (affinity_it != ctx.affinities.end() && ctx.assignments[affinity_it->second].assigned) {
             PhysReg reg = ctx.assignments[affinity_it->second].reg;
             reg.reg_b -= offset;
-            if (get_reg_specified(ctx, reg_file, temp.regClass(), parallelcopies, instr, reg))
+            if (get_reg_specified(ctx, reg_file, temp.regClass(), instr, reg))
                return reg;
          }
          offset += def.bytes();
@@ -1280,7 +1279,7 @@ PhysReg get_reg(ra_ctx& ctx,
    if (ctx.affinities.find(temp.id()) != ctx.affinities.end() &&
        ctx.assignments[ctx.affinities[temp.id()]].assigned) {
       PhysReg reg = ctx.assignments[ctx.affinities[temp.id()]].reg;
-      if (get_reg_specified(ctx, reg_file, temp.regClass(), parallelcopies, instr, reg))
+      if (get_reg_specified(ctx, reg_file, temp.regClass(), instr, reg))
          return reg;
    }
 
@@ -1301,7 +1300,7 @@ PhysReg get_reg(ra_ctx& ctx,
              ctx.assignments[op.tempId()].assigned) {
             PhysReg reg = ctx.assignments[op.tempId()].reg;
             reg.reg_b += (byte_offset - k);
-            if (get_reg_specified(ctx, reg_file, temp.regClass(), parallelcopies, instr, reg))
+            if (get_reg_specified(ctx, reg_file, temp.regClass(), instr, reg))
                return reg;
          }
          k += op.bytes();
@@ -1313,7 +1312,7 @@ PhysReg get_reg(ra_ctx& ctx,
       if (res.second) {
          reg.reg_b += byte_offset;
          /* make sure to only use byte offset if the instruction supports it */
-         if (get_reg_specified(ctx, reg_file, temp.regClass(), parallelcopies, instr, reg))
+         if (get_reg_specified(ctx, reg_file, temp.regClass(), instr, reg))
             return reg;
       }
    }
@@ -1989,7 +1988,7 @@ void register_allocation(Program *program, std::vector<IDSet>& live_out_per_bloc
                /* we tried this already on the previous loop */
                if (reg == scc || reg == exec)
                   continue;
-               if (get_reg_specified(ctx, register_file, definition.regClass(), parallelcopy, phi, reg)) {
+               if (get_reg_specified(ctx, register_file, definition.regClass(), phi, reg)) {
                   definition.setFixed(reg);
                   break;
                }
@@ -2262,7 +2261,7 @@ void register_allocation(Program *program, std::vector<IDSet>& live_out_per_bloc
                PhysReg reg = instr->operands[0].physReg();
                for (unsigned j = 0; j < i; j++)
                   reg.reg_b += instr->definitions[j].bytes();
-               if (get_reg_specified(ctx, register_file, definition->regClass(), parallelcopy, instr, reg))
+               if (get_reg_specified(ctx, register_file, definition->regClass(), instr, reg))
                   definition->setFixed(reg);
             } else if (instr->opcode == aco_opcode::p_wqm || instr->opcode == aco_opcode::p_parallelcopy) {
                PhysReg reg = instr->operands[i].physReg();
@@ -2273,7 +2272,7 @@ void register_allocation(Program *program, std::vector<IDSet>& live_out_per_bloc
             } else if (instr->opcode == aco_opcode::p_extract_vector) {
                PhysReg reg = instr->operands[0].physReg();
                reg.reg_b += definition->bytes() * instr->operands[1].constantValue();
-               if (get_reg_specified(ctx, register_file, definition->regClass(), parallelcopy, instr, reg))
+               if (get_reg_specified(ctx, register_file, definition->regClass(), instr, reg))
                   definition->setFixed(reg);
             } else if (instr->opcode == aco_opcode::p_create_vector) {
                PhysReg reg = get_reg_create_vector(ctx, register_file, definition->getTemp(),



More information about the mesa-commit mailing list