Mesa (master): gallium/tgsi: Remove support for f64 src modifiers.

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 1fc79592b76a4ac3e07b0ea3dfd5ebdadb8a4253
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1fc79592b76a4ac3e07b0ea3dfd5ebdadb8a4253

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Jan  7 10:53:03 2021 -0800

gallium/tgsi: Remove support for f64 src modifiers.

The tgsi.rst was not very clear but didn't indicate that they were
supported, and llvmpipe only supported double abs and not negate.
glsl_to_tgsi never generated them, and neither did the new nir_to_tgsi, so
just garbage collect it.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8369>

---

 src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 2 +-
 src/gallium/auxiliary/tgsi/tgsi_exec.c      | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c
index 3b111138b79..f39397727d5 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c
@@ -377,11 +377,11 @@ lp_build_emit_fetch_src(
    if (reg->Register.Absolute) {
       switch (stype) {
       case TGSI_TYPE_FLOAT:
-      case TGSI_TYPE_DOUBLE:
       case TGSI_TYPE_UNTYPED:
           /* modifiers on movs assume data is float */
          res = lp_build_abs(&bld_base->base, res);
          break;
+      case TGSI_TYPE_DOUBLE:
       case TGSI_TYPE_UNSIGNED:
       case TGSI_TYPE_SIGNED:
       case TGSI_TYPE_UNSIGNED64:
diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index d1203cb1c57..f7ed64121f0 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -3594,12 +3594,8 @@ fetch_double_channel(struct tgsi_exec_machine *mach,
       chan->u[i][0] = src[0].u[i];
       chan->u[i][1] = src[1].u[i];
    }
-   if (reg->Register.Absolute) {
-      micro_dabs(chan, chan);
-   }
-   if (reg->Register.Negate) {
-      micro_dneg(chan, chan);
-   }
+   assert(!reg->Register.Absolute);
+   assert(!reg->Register.Negate);
 }
 
 static void