Mesa (master): nv50/ir: Initialize DataArray members in constructor.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 19 02:20:48 UTC 2021


Module: Mesa
Branch: master
Commit: 3e6b37a9544af19583e3c79f874c521ddc91b13d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e6b37a9544af19583e3c79f874c521ddc91b13d

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Tue Nov 24 16:54:37 2020 -0800

nv50/ir: Initialize DataArray members in constructor.

Fix defects reported by Coverity Scan.

uninit_member: Non-static class member array is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member arrayIdx is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member baseAddr is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member arrayLen is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member baseSym is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member vecDim is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member eltSize is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member file is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member regOnly is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7764>

---

 src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.h b/src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.h
index d171f64d9a1..c2bc0d686cf 100644
--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.h
+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_build_util.h
@@ -137,7 +137,9 @@ public:
    class DataArray
    {
    public:
-      DataArray(BuildUtil *bld) : up(bld) { }
+      DataArray(BuildUtil *bld) : up(bld), array(0), arrayIdx(0), baseAddr(0),
+         arrayLen(0), baseSym(NULL), vecDim(0), eltSize(0), file(FILE_NULL),
+         regOnly(false) { }
 
       void setup(unsigned array, unsigned arrayIdx,
                  uint32_t base, int len, int vecDim, int eltSize,



More information about the mesa-commit mailing list