Mesa (master): zink: force per-sample interpolation
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Jan 21 23:21:33 UTC 2021
Module: Mesa
Branch: master
Commit: 0ab9114abde1f9fac31ba6cbf55754e5596755e2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ab9114abde1f9fac31ba6cbf55754e5596755e2
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Fri Aug 7 11:28:37 2020 -0400
zink: force per-sample interpolation
this gives us new rasterizer states when multisample stuff changes instead
of new fs states, which is what we want since these correlate to pipeline
flags, not shader-specific things
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8631>
---
src/gallium/drivers/zink/zink_pipeline.c | 4 ++++
src/gallium/drivers/zink/zink_screen.c | 1 +
src/gallium/drivers/zink/zink_state.c | 1 +
src/gallium/drivers/zink/zink_state.h | 1 +
4 files changed, 7 insertions(+)
diff --git a/src/gallium/drivers/zink/zink_pipeline.c b/src/gallium/drivers/zink/zink_pipeline.c
index 4e20eb4ec3e..0808dbdf910 100644
--- a/src/gallium/drivers/zink/zink_pipeline.c
+++ b/src/gallium/drivers/zink/zink_pipeline.c
@@ -85,6 +85,10 @@ zink_create_gfx_pipeline(struct zink_screen *screen,
ms_state.alphaToCoverageEnable = state->blend_state->alpha_to_coverage;
ms_state.alphaToOneEnable = state->blend_state->alpha_to_one;
ms_state.pSampleMask = state->sample_mask ? &state->sample_mask : NULL;
+ if (state->rast_state->force_persample_interp) {
+ ms_state.sampleShadingEnable = VK_TRUE;
+ ms_state.minSampleShading = 1.0;
+ }
VkPipelineViewportStateCreateInfo viewport_state = {};
viewport_state.sType = VK_STRUCTURE_TYPE_PIPELINE_VIEWPORT_STATE_CREATE_INFO;
diff --git a/src/gallium/drivers/zink/zink_screen.c b/src/gallium/drivers/zink/zink_screen.c
index 95bb1e0c50a..fb3e645d7d8 100644
--- a/src/gallium/drivers/zink/zink_screen.c
+++ b/src/gallium/drivers/zink/zink_screen.c
@@ -106,6 +106,7 @@ zink_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
case PIPE_CAP_GLSL_TESS_LEVELS_AS_INPUTS:
case PIPE_CAP_CLEAR_TEXTURE:
case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
+ case PIPE_CAP_FORCE_PERSAMPLE_INTERP:
return 1;
case PIPE_CAP_MULTI_DRAW_INDIRECT:
diff --git a/src/gallium/drivers/zink/zink_state.c b/src/gallium/drivers/zink/zink_state.c
index 734cc03a40d..d8e08bba812 100644
--- a/src/gallium/drivers/zink/zink_state.c
+++ b/src/gallium/drivers/zink/zink_state.c
@@ -434,6 +434,7 @@ zink_create_rasterizer_state(struct pipe_context *pctx,
assert(rs_state->depth_clip_far == rs_state->depth_clip_near);
state->hw_state.depth_clamp = rs_state->depth_clip_near == 0;
state->hw_state.rasterizer_discard = rs_state->rasterizer_discard;
+ state->hw_state.force_persample_interp = rs_state->force_persample_interp;
assert(rs_state->fill_front <= PIPE_POLYGON_MODE_POINT);
if (rs_state->fill_back != rs_state->fill_front)
diff --git a/src/gallium/drivers/zink/zink_state.h b/src/gallium/drivers/zink/zink_state.h
index 141f4c39126..caa8194cbe3 100644
--- a/src/gallium/drivers/zink/zink_state.h
+++ b/src/gallium/drivers/zink/zink_state.h
@@ -49,6 +49,7 @@ struct zink_rasterizer_hw_state {
VkFrontFace front_face;
VkPolygonMode polygon_mode;
VkCullModeFlags cull_mode;
+ bool force_persample_interp;
};
struct zink_rasterizer_state {
More information about the mesa-commit
mailing list