Mesa (master): panfrost: Stub out set_shader_images().

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jan 25 19:20:56 UTC 2021


Module: Mesa
Branch: master
Commit: f259fcae83c12e4df10ec2415a1660cc44810eb7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f259fcae83c12e4df10ec2415a1660cc44810eb7

Author: Eric Anholt <eric at anholt.net>
Date:   Wed Jan 20 10:29:38 2021 -0800

panfrost: Stub out set_shader_images().

If PAN_MESA_DEBUG=deqp is set to enable testing, then we advertise shader
images to get GLES3.1, even though we don't have any of the shader image
funcs hooked up.  This caused breakage when cso started unbinding shader
images at context destruction.

Just stub out the function for now, you'll still segfault when creating an
image.

Cc: mesa-stable (for the next commit)
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>

---

 src/gallium/drivers/panfrost/pan_context.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
index f8570149ee8..95ee7e5ee90 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -1186,6 +1186,16 @@ panfrost_set_shader_buffers(
                         buffers, start, count);
 }
 
+static void
+panfrost_set_shader_images(
+        struct pipe_context *pctx,
+        enum pipe_shader_type shader,
+        unsigned start, unsigned count,
+        const struct pipe_image_view *images)
+{
+        /* TODO */
+}
+
 static void
 panfrost_set_framebuffer_state(struct pipe_context *pctx,
                                const struct pipe_framebuffer_state *fb)
@@ -1596,6 +1606,7 @@ panfrost_create_context(struct pipe_screen *screen, void *priv, unsigned flags)
         gallium->set_vertex_buffers = panfrost_set_vertex_buffers;
         gallium->set_constant_buffer = panfrost_set_constant_buffer;
         gallium->set_shader_buffers = panfrost_set_shader_buffers;
+        gallium->set_shader_images = panfrost_set_shader_images;
 
         gallium->set_stencil_ref = panfrost_set_stencil_ref;
 



More information about the mesa-commit mailing list