Mesa (21.0): 67 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Jan 27 17:53:03 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=59417ecc8478d1c8cd69468754ba9a3fb2eaa6b7
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jan 27 09:27:36 2021 -0800
VERSION: bump for 21.0.0-rc3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd506cb19ca1f48d44c16a4f2ccf49218ec1f2ed
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Jan 15 18:54:01 2021 +0100
aco/optimizer: don't copy-prop logical phis
This is dangerous w.r.t. LCSSA-phis.
Totals from 746 (0.54% of 139391) affected shaders (Navi10):
CodeSize: 8592160 -> 8568156 (-0.28%); split: -0.30%, +0.02%
MaxWaves: 5172 -> 5171 (-0.02%); split: +0.02%, -0.04%
Instrs: 1653949 -> 1648489 (-0.33%); split: -0.36%, +0.03%
Cycles: 49474892 -> 49329224 (-0.29%); split: -0.33%, +0.03%
VMEM: 137574 -> 137421 (-0.11%); split: +0.18%, -0.29%
SMEM: 42391 -> 42439 (+0.11%); split: +0.12%, -0.01%
VClause: 26946 -> 26943 (-0.01%)
Copies: 130902 -> 126176 (-3.61%); split: -4.05%, +0.43%
Branches: 54891 -> 54556 (-0.61%); split: -0.64%, +0.03%
PreVGPRs: 53941 -> 53939 (-0.00%)
This has a slight effect on RA due to affinity changes.
Cc: 20.3
Cc: 21.0
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8260>
(cherry picked from commit cd870d1b6aa43daa65f1e6c9763e5bdd7139acc9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=215266234b56498c77b813513f3736928630f749
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Mon Dec 28 19:15:17 2020 +0000
aco/optimizer: don't propagate subdword temps of different size
It could happen that due to inconsistent copy-propagation
v1 = p_parallelcopy v2b
instructions were left after optimization on GFX8.
Cc: 20.3
Cc: 21.0
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8260>
(cherry picked from commit 856fd4750daf23ac3f8f40278cf685f36661c19f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5d8a6fd48d74b04498d8b62e0ffc0ef3fdcc9fb6
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Thu Jan 21 08:41:15 2021 -0800
nir: Add a data pointer to the callback in nir_remove_dead_variables
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8706>
(cherry picked from commit cb7352ae95a48ba4f20286a59bea184072f52785)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=96de6d77548c3f56fc8cb4d0af0c6d7bfa5f1e6f
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Thu Jan 21 10:14:36 2021 -0800
spirv: Don't remove variables used by resource indexing intrinsics
In Vulkan, for some variable modes, the generated NIR will have derefs
pointing to resource index intrinsics instead of the variable. This
was letting nir_remove_dead_variables pass remove those variables,
which would lose information relevant for later passes after
spirv2nir.
Add a set to keep track of such variables and prevent them to be
removed when producing the NIR output.
Issue reported by Rhys.
Fixes: c4c9c780b13 ("spirv: Remove more dead variables")
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8706>
(cherry picked from commit 10b3eecd361af465e0e207fb18553ae37b924c45)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0bb52cf5227cf8a1b4d55006c533c173a02a8b7
Author: David McFarland <corngood at gmail.com>
Date: Mon Nov 30 20:48:50 2020 -0400
radv: fix divide by zero with no tesselation params
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7878>
(cherry picked from commit e3f56601e0c00380748bbf0039b82a2212e405b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=72dcdac82b3d8afef415883ef8a9b57ec9abf8f4
Author: Sagar Ghuge <sagar.ghuge at intel.com>
Date: Mon Jan 25 13:23:32 2021 -0800
anv: Skip CCS ambiguate which preceed fast-clears
We can skip CCS ambiguate if followed by a fast clear within render
pass.
v2: (Jason)
- Check array layer as well since we only fast clear first layer and
first LOD.
- Don't drop fast clear check while doing resolve operation.
Fixes: d5849bc840e "anv: Skip HiZ and CCS ambiguates which preceed fast-clears"
Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6988>
(cherry picked from commit 001722b3a301312d2ec16c939376098dc11fab98)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=70887f253c2ba8201799b9539c78686f35dd09fd
Author: Francisco Jerez <currojerez at riseup.net>
Date: Thu Jan 21 14:21:50 2021 -0800
intel/gen12: Fix memory corruption issues in fused Gen12 parts.
According to the BSpec page for MEDIA_VFE_STATE, on Gen12 platforms
"if a fused configuration has fewer threads than the native POR
configuration, the scratch space allocation is based on the number of
threads in the base native POR configuration". However we currently
use the subslice count from devinfo->num_subslices[0], which only
includes the subslices currently enabled by the platform fusing. This
leads to scratch space underallocation and occasional hangs.
The problem is likely to affect most Gen12 GPUs with less than 96 EUs.
GFXBench5 Aztec Ruins is able to reproduce the issue fairly reliably.
Fixes: 9e5ce30da7fa3f1cc3badf "intel: fix the gen 12 compute shader scratch IDs"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8636>
(cherry picked from commit e2c5ef6cd6571a8522b9b75a99d245a538cf6183)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=85bb7eff533156e2c87560288236be1ae60ff0ba
Author: Icecream95 <ixn at disroot.org>
Date: Sun Jan 24 20:53:36 2021 +1300
panfrost: Use normal malloc/free instead of ralloc for surfaces
Fixes a double-free in some Qt5 WebEngine apps (e.g. ghostwriter).
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8678>
(cherry picked from commit 1d967132f3c4aefa72224d1029aa64a34053bf6b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=90f8855080f427011acbe9059883d32ec0aa4d22
Author: Sagar Ghuge <sagar.ghuge at intel.com>
Date: Sat Jan 23 17:21:17 2021 -0800
anv: Invalidate the correct AUX-TT entry
While invalidating the AUX-TT entries, we have to consider the surface
offset as well otherwise, we will end up invalidating another surface's
CCS portion.
For eg. when we have HiZ+CCS and STC_CCS enabled, both will use the CCS
portion allocated at the end of BO. While invalidating the CCS portion
of stencil buffer, we will end up invalidating the CCS portion that
belongs to the depth main surface and vice-versa, if the surface offset
is not considered.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4123
Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
Acked-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8677>
(cherry picked from commit dab229ef69656179e1786eb097705c8d5505ade9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a9faff69f6ea4f6c29eb78ef563fb3fdcbd672d7
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Jan 25 13:23:08 2021 +0200
anv: fix invalid programming of BLEND_STATE
We can't enable Logic Op & Color Buffer Blend. The Vulkan spec seems
to say Logic Op discards blending.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3767
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8691>
(cherry picked from commit 998f38bd9934e9eff156505244032c28df9fba31)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd5c91e656ac5857ab9309dce6c8d310e5f45ba4
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sat Jan 23 02:36:29 2021 +0100
radv: Use stricter HW resolve swizzle compat check.
D and linear are both DISPLAY micro tiling according to ac_surface
but don't work together. This fixes an issue with GFX9+.
This fixes the SkQP WritePixelsNonTexture_Gpu test.
Fixes: 69ea473eeb9 ("amd/addrlib: update to the latest version")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8665>
(cherry picked from commit 12ce72fcfcd07a1da4eb1b8bb2b3ebb1c2e651a7)
Conflicts:
src/amd/vulkan/radv_meta_resolve.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fcb61d4b46005fa9a2f37b4d0342d6bb6bda8001
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date: Sat Jan 23 16:15:38 2021 +0100
etnaviv: handle NULL views in set_sampler_views
Passing NULL for the views parameter should be the same as passing an
array of NULL, according to the documentation. So let's respect that
detail.
This fixes a crash when using GALLIUM_HUD. The wrong handling of views
parameter was causing problems starting with
2813688f8db ("gallium/hud: don't use cso_context to restore VBs, constbuf 0 and sampler views").
Cc: <mesa-stable at lists.freedesktop.org>
Fixes: c9e8b49b885 ("etnaviv: gallium driver for Vivante GPUs")
Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8670>
(cherry picked from commit 81ab9fe2d0c2c2d9961107c88209f2fff1f136c4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dacf8a517b095ca3978b796ddb4bf2f17f51900b
Author: Eric Anholt <eric at anholt.net>
Date: Tue Dec 1 14:05:30 2020 -0800
gallium: Fix leak of shader images on context destruction.
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit efff70e73ff6fbb1f73ace016c8eb53920629fe8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a132e464f8af105ceaa6665ad47f435cd1d14b3c
Author: Eric Anholt <eric at anholt.net>
Date: Wed Jan 20 10:29:38 2021 -0800
panfrost: Stub out set_shader_images().
If PAN_MESA_DEBUG=deqp is set to enable testing, then we advertise shader
images to get GLES3.1, even though we don't have any of the shader image
funcs hooked up. This caused breakage when cso started unbinding shader
images at context destruction.
Just stub out the function for now, you'll still segfault when creating an
image.
Cc: mesa-stable (for the next commit)
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit f259fcae83c12e4df10ec2415a1660cc44810eb7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9a332e1a2933373eeed004eee2b9401eac2ee894
Author: Eric Anholt <eric at anholt.net>
Date: Fri Jan 22 11:23:35 2021 -0800
swr: Don't report support for shader images.
gallivm has images support, but this driver doesn't.
Cc: mesa-stable (for the upcoming shader image leak fix)
Acked-by: Jan Zielinski <jan.zielinski at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit 9445c3d59ff25e61e94f3fa888dd2ac16126b4ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=80302b96f446252424320b9c34c48687b17d5af9
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Mon Jan 25 09:40:50 2021 -0500
zink: flag gfx pipeline dirty using newer mechanism
this wasn't updated during rebases
Fixes: 334759d8509 ("zink: implement passthrough tcs shader injection")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8696>
(cherry picked from commit c3719f3b9ba06fa557d7e8ed6b94ad5db3d7baca)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e721f4c8f1474371cb408cc7c14b659afc6be165
Author: Ryan Neph <ryanneph at google.com>
Date: Sat Jan 23 01:02:06 2021 +0000
Revert "virgl: fix BGRA emulation artifacts during window resize"
This reverts commit accc2222174a90fd24ee56ce751feb6022ecc0c7.
The change in accc2222 caused a regression in gameplay for a few valve
games such as Portal 2 where textures were rendered darker than
expected.
Reverting to restore normal gameplay at the smaller cost of
re-introducing the issue described in !8119.
Fixes: accc2222 ("virgl: fix BGRA emulation artifacts during window resize")
Signed-off-by: Ryan Neph <ryanneph at google.com>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8664>
(cherry picked from commit 6fb66d18bea060151eb0483ae7135489245da910)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=54f2af0770c0a385d898012d515f6178b61065b1
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Jan 26 09:05:06 2021 -0800
.pick_status.json: Update to f01ea0aef8a50d2732eb0c64153903e52ed2a757
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f6ae40f9e72c0c158f0ad19ebd004af36ce4006
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Wed Aug 26 18:40:02 2020 +0200
mesa/main: remove leftover bumpmap code
This variable is only ever written as NULL, so we can omit it entirely.
Fixes: 4000c0112a4 ("Remove the ATI_envmap_bumpmap extension")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6473>
(cherry picked from commit 92ff89f6f50c773f6d3531623db2997315d63c22)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51ff50ef3098bb5b9efaeb1580f1749ab32b71a0
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Jan 25 13:42:35 2021 +0100
radv,aco: fix shifting input VGPRs for the LS VGPR init bug on GFX9
We were incorrectly shifting the input VGPRs for the instance ID
for chips affected by the LS VGPR init bug (ie. Vega10 and Raven).
When there is no HS threads, the hardware loads the LS VGPR
starting from VGPR 0, so they should be shifted by two.
This fixes some sort of vertex explosion with Squad, Visage, Barn
Finders and probably more titles that use tessellation. Note that
only Vega10 and Raven were affected by this bug.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4129
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3311
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Tested-by: Diego Viola <diego.viola at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8694>
(cherry picked from commit bb8f87088cb2868d267f83c537b33c9f3e0ed36e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f59b95c7b39a95da71b90065041d88fece811dcf
Author: Keith Packard <keithp at keithp.com>
Date: Thu Jan 21 12:19:12 2021 -0800
glx: Provide glvnd wrapper for glXSwapIntervalEXT
When using glvnd, this function needs to be exposed through
getDispatchAddress or libglvnd will not find it.
Signed-off-by: Keith Packard <keithp at keithp.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Fixes: 60ebeb4608a8 "glx: Implement GLX_EXT_swap_control for DRI2 and DRI3"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8621>
(cherry picked from commit d548d781eee91842695cf54a3161348bf6a06a2e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a4e04f3f8b912a4cb6f559a6d33cf7e3f507e41
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Jan 25 10:01:43 2021 -0800
.pick_status.json: Update to 9052819ebbff07d82c3eb9adf414144df4868644
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=219407fd0138d5e5febcf9b2d0595d5b6b2cdeb3
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 16:14:32 2021 +0100
zink: clone shader before lowering clip_halfz
If we don't clone the shader before lowering clip_halfz, we risk ending
up performing the same lowering multiple times, each time we compile a
new variant.
This fixes rendering in Neverball.
Fixes: 15f478fe840 ("zink: only run nir_lower_clip_halfz for last vertex processing stage")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4147
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8652>
(cherry picked from commit 92ec7b577c8cb47b308bba1d21b4c2ec05f35f9f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=88a5bbb3419c3eff7b4cfb894f585a2d69c6feef
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Oct 27 00:36:53 2020 -0500
intel/fs: QUAD_SWIZZLE requires packed data
We could probably support some strides if we tried hard enough but the
whole point of this opcode is to accelerate things with crazy Align16 or
crazy regions. It's ok if we have to emit an extra MOV to get a packed
source.
Fixes: 8b4a5e641bc3 "intel/fs: Add support for subgroup quad operations"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
(cherry picked from commit 58bcb5401d85b4a21f6d9ea4eb7bff8e1ed7110f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b01aa90cabf56027f30665b6637f3a7332e80e47
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Oct 26 20:53:37 2020 -0500
intel/compiler: Return 1 for immediates in regs_read
Previously, we were returning 2 whenever the source was a Q type. As
far as I can tell, the only reason why this hasn't blown up before is
that it was only ever used for VGRFs until the SWSB pass landed which
uses it for everything. This wasn't a problem because Q types generally
aren't a thing on TGL. However, they are for a small handful of
instructions.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
(cherry picked from commit 4c8cbe9b1340db826fa21eec5fcbee6e6fc35efe)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9bbb5639b473b22efc6175d5fd24770ead9612a9
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 22 14:13:18 2021 -0800
.pick_status.json: Mark 45bebc7a9c73f3add08c2290fa1eac237edf5a34 as backported
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a4e7e0e77a11eb7edebe2ce316ab9a7072f2aa4f
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 22 14:13:18 2021 -0800
.pick_status.json: Mark 8c7d9716669a74159d2eec86490c756c274f663c as backported
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5e5225dec808e15e49a7464d4bd3c16e278844e
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 22 14:13:16 2021 -0800
.pick_status.json: Update to d37124b065c2b6c99c042fb402c6a23ce16b034e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=72e527d534221894a2ecfe7cc6e83327defdcb6c
Author: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Date: Sun Dec 6 14:56:58 2020 +0100
frontends/va/context: don't set max_references with num_render_targets
For HEVC and VP9 template's max_references are tied to the number of
surfaces associated with context. Later, the decoder is created if
max_references is different to zero.
But vaCreateContext() doesn't really need an array of VASurfaceIDs (see
https://lists.01.org/pipermail/intel-vaapi-media/2017-July/000052.html and
https://github.com/intel/libva/issues/251).
This patch removes the validation of the max_references at decoder
creation and also remove the assignation of num_render_targets to
max_references.
Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Reviewed-by: Leo Liu <leo.liu at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7949>
(cherry picked from commit 925d701014c2ba084061eae131f4b5c75e595f29)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d50b941c4641846a11147b478f2fd411d51330c3
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 11:42:18 2021 +0100
zink: respect fragment-shader depth-layout
This is required by GLSL 1.30 and later, so we should also respect the
setting.
Fixes: 6785d8c4601 ("zink: expose GLSL 1.30")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8655>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c767383b23a7ea6b0f770d789dbb89e6259c2182
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 12:23:10 2021 +0100
zink: require vulkan memory model for tesselation
We enable the KHR_vulkan_memory_model extension whenever we use
tesselation, so right now this is a defacto requirement. So let's make
this requirement explicit.
Fixes: f815b87e188 ("zink: export tess shader pipe caps")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8655>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c849e15c44d1d3f5b327060b5c9f4c055998db84
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Jan 18 08:59:29 2021 +0100
radv: fix separate depth/stencil layout in render pass
We used to select the stencil layout even if we should have selected
the depth/stencil one.
Fixes: e4c8491bdf8 ("radv: implement VK_KHR_separate_depth_stencil_layouts")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8552>
(cherry picked from commit 3ef89b245e3e1ac4e67fea9c1b13ebeda75769d0)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=20fd3fb938e0a5333c7af0331b0e076e878db6d9
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 12:41:42 2021 +0100
zink: make all xfb caps depend on extension
Without this, we'll expose GL_ARB_transform_feedback2 and
GL_ARB_transform_feedback3 even without VK_EXT_transform_feedback,
because these caps are directly wired up without checking the pervious
extensions.
Fixes: e8ad52f7b0c ("zink: enable xfb extension in screen creation")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 855370bb620663b5e451e08046e4ddb4b6429c0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4146d84a1f6b1b68941db68e551930c3f54a1572
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 09:15:10 2021 +0100
zink: respect feature-cap for multi-draw indirect
Even in the presence of VK_KHR_draw_indirect_count, we still technically
need to respect the feature-cap when using a Vk 1.0 core-function.
Fixes: cef876910a0 ("zink: enable PIPE_CAP_MULTI_DRAW_INDIRECT(_PARAMS) caps")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit c9340744a3c6310f0f36c6c5576ea1bc87b65f03)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=442128549e57e6309310476232a0b27c30bc0976
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 09:11:51 2021 +0100
zink: respect feature-cap for sample-shading
Vulkan has a cap to enable this, we should check that one rather than
always claiming support.
Fixes: 0c70268ff73 ("zink: mark ARB_sample_shading as supported")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 6f6941e2dd8f1d1d1d6e52276485d41c7dd0b029)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=156edb5fea0d857f373979d43491e2628ed73823
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 09:09:03 2021 +0100
zink: respect feature-cap for independent blending
Vulkan has a cap to enable this, we should check that one rather than
always claiming support.
Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 612169859a3300879fa890a03a8693ab3c718d2c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=291eebfaa42c91b354b7289b36b7eecdea740ea5
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Jan 21 10:14:48 2021 +0100
radv: inhibit clock gating when tracing with SQTT
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8616>
(cherry picked from commit 5b5cd18853c1d5ff0b159ea6df78674532b78b18)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=acfd179fe341f1ec8ca8e0a1cda1c5cd9b6c4e24
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Jan 21 13:39:27 2021 +0100
radv: fix overflow when computing the SQTT buffer size
With RADV_THREAD_TRACE_BUFFER_SIZE=1073741824, the computed size
will overflow and be 4096 instead of 4294967296.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8616>
(cherry picked from commit c40ea24ee009d8c9816ff6327f65be3fbd45deb7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=31ef7441cd5cdf918ba3c88a5ec53bd890a0b412
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Jan 22 10:47:19 2021 +0000
aco: don't consider a phi trivial if same's register doesn't match the def
For example:
s2: %688:s[32-33] = p_linear_phi %3:s[10-11], %688:s[32-33]
would have been considered trivial.
This might happen due to parallelcopies when assigning phi registers.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 69b6069dd28 ("aco: refactor try_remove_trivial_phi() in RA")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8645>
(cherry picked from commit 824eba2148e56a75d0678011b4f546cabbd5d345)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=be80839ac5210c8dcd5ab2ff71044d8752bf1ce1
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Jan 20 14:10:49 2021 -0800
iris: Consider resolves after changing a resource's aux state
The intention of IRIS_DIRTY_{RENDER,COMPUTE}_RESOLVES_AND_FLUSHES
is to avoid considering resolves/flushes on back to back draw calls
where nothing of significance has changed with the resources. When
anything changes that could require a resolve, we must flag those.
Those situations are:
1. Texture/image/framebuffer bindings change
(as the set of images we need to look at is now different)
2. Depth writes are enabled/disabled (the resolve code uses this)
3. The aux state for a currently bound resource changes.
We were missing this last case. In particular, one example where
we missed this was:
1. Bind a texture.
2. Clear that texture (likely blits/copies/teximage would work too)
3. Draw and sample from that texture
Clear-then-Bind would work, as binding would flag resolves as dirty.
But Bind-then-Clear doesn't work, as clear can change the aux state
of the bound texture, but wasn't flagging that anything had changed.
Technically, we could consider whether the resource whose aux state
is changing is bound for compute (and only flag COMPUTE_RESOLVES),
or bound for a 3D stage (and only flag RENDER_RESOLVES), and flag
nothing at all if it isn't bound. But we don't track that well,
and it probably isn't worth bothering. So, flag unconditionally
for now.
This does not appear to impact Piglit's drawoverhead scores.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3994
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4019
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8603>
(cherry picked from commit e2500c02cc7bd429e035c5208e533e569c525b03)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b25f6bb63e2e82f93fff5cd48e02576028af53e8
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 22 09:01:38 2021 -0800
.pick_status.json: Update to 3ef89b245e3e1ac4e67fea9c1b13ebeda75769d0
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=20c0159608abe61ffb865da6d3247858f7bbb213
Author: Andres Gomez <agomez at igalia.com>
Date: Sat Jan 16 02:46:54 2021 +0200
ci: correct the trace image URLs in the piglit summary
Fixes: 09429fa85b6 ("ci: add piglit replay jobs and remove tracie ones")
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8531>
(cherry picked from commit 0773cd33c2bd14605eee471dd0dcc5306dd41cd4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb30e941fe7d84b10eb36c2b73434c8b866befc3
Author: Andres Gomez <agomez at igalia.com>
Date: Sat Jan 16 00:04:41 2021 +0200
ci: recover tracie dashboard URLs for failing traces
Tracie was including a direct link to the diff page in the resulting
JUnit XML file and the migration to piglit's replayer didn't, causing
a regression.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4027
Fixes: 09429fa85b6 ("ci: add piglit replay jobs and remove tracie ones")
Signed-off-by: Andres Gomez <agomez at igalia.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8531>
(cherry picked from commit 27f8c466486b6e25d301681d3610fbe57ad8c032)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e84c17c9daf126875392e3b8917519fc529543c3
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Tue Jan 19 05:17:45 2021 -0500
nvc0/ir: add fixup to deal with interpolateAtSample with non-MSAA
The spec calls to always use sample 0 in this case, whereas we can do
undefined things for invalid sample id's in the MSAA case.
Fixes
dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.non_multisample_buffer.sample_n_*
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8574>
(cherry picked from commit 245a696741d2a4cd5f2aade38c2194e3030d659b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a025e00d0ce318e25029f154298329395e1a70e3
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Jan 21 14:53:41 2021 -0800
.pick_status.json: Update to 64f55b82c7f1652e4fae478c0af325fc38b9b53b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=83bb5dee16da55c890e78d906e286977b0dc5552
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Fri Jan 15 17:01:27 2021 -0500
nv50/ir: clear dnz flag when converting mul/mad to simpler ops
Fixes some assertion failures in the GM107 emitter with the game
'tansei', noticed while debugging gitlab issue 4101.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8534>
(cherry picked from commit 6638b58ccf17ce3a00a8ecbf5f39b5bedef238ed)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4956c6bfc57b28de5c844ed35cc88ea555d43b0f
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Jan 13 02:14:07 2021 -0500
st/mesa: fix broken moves for u2i64 and related ops
These ops just put out mov's directly, which screws up the assignment
logic -- it just tries to only process the "last" mov. Don't try to do
the more optimized thing for 64-bit types, where this is just much
trickier.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8463>
(cherry picked from commit 55c42b7885701098cff9cc0fd0ffe08b0a90ea8b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f76e0d4b22b3a276d1cc6fd2f5bf7a1d0e9cbda
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Wed Jan 20 10:19:32 2021 +0100
zink: fix vertex-stride wrangling
Because Gallium and Vulkan disagree on what kind of state strides is, we
need to wrangle this state a bit, and up until now, we've been simply
fixing this up while binding the vertex-buffers.
But this isn't robust, because the vertex element state might be bound
after the vertex-buffer state was bound. We also need to take
binding-map into account, which we're currently missing as well.
Instead, w need to deal with this at a place where we know what's being
used for both of these. So let's do this during draw instead.
Ideally, we'd also do some dirty-tracking to know if this is needed or
not, but I believe Mike has some patches in this areas lined up, so it
might be easier to wait for those.
Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3661
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4125
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8588>
(cherry picked from commit d74b01226004fe7e245f108f69747c184b3ac044)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eaefaa9610a291a0c06a5c31d90aa84cce437f2d
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jan 20 17:29:14 2021 +0100
radv: fix a sync issue with geometry shader primitives query on GFX10+
When NGG is used, the hw can't know the number of geometry shader
primitives. To fix that, the NGG geometry shader accumulates itself
the number of primitives by using an atomic operation directly to GDS.
Then, begin/query copy the start/stop values from GDS to the
query pool buffer using a PS_DONE event. This was actually wrong
because PS_DONE is completely asynchronous to everything and executed
when the preceding draws finish pixel shaders.
Fix this by using a COPY_DATA packet which is synced with CP. This
fixes random failures on Sienna Cichlid with
dEQP-VK.query_pool.statistics_query.*.geometry_shader_primitives.*.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8590>
(cherry picked from commit 085e2ce3d49c36ad2c119313e47c0ac685828a61)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d47d44e4f666fdc52fd376fb5b89f329351cac1e
Author: Icecream95 <ixn at disroot.org>
Date: Wed Jan 20 10:46:05 2021 +1300
pan/decode: Free mapped memory objects on BO unreference
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8583>
(cherry picked from commit 0d0536c1a7662e2c1d99d221c444bc19ca3ab566)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e60e3ef8410b5d7cb03cda8c4f2a393f58b22709
Author: Jesse Natalie <jenatali at microsoft.com>
Date: Tue Jan 19 11:23:39 2021 -0800
nir: Work around MSVC x86 internal compiler error
Fixes: 1fd8b466 ("nir,spirv: add sparse image loads")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4108
Acked-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8581>
(cherry picked from commit 13b21156e47daba7545fe7c171ebd5f444692f70)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=06c9ae6d3fe17124a6beb6e90788d6a11ee97f9f
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Jan 13 16:09:18 2021 +0200
anv: Fix stencil layout in render passes
We incorrectly utilize the stencil layouts structures even if we
should stick to the depth_stencil ones if the layout includes stencil.
v2: Don't forget stencil only layout (Nanley)
Simplify callers of new helper functions (Nanley)
v3: Store VK_IMAGE_LAYOUT_UNDEFINED when no stencil is available (Nanley)
Use a switch statement (Nanley)
v4: Consider all layouts but depth only to be potential stencil layouts (Lionel)
v5: Refactor helper in vk_image_layout_depth_only() and discard
VkAttachmentDescriptionStencilLayoutKHR in
VkAttachmentDescription2KHR if format is not depth/stencil.
v5: s/LAYOUT_COLOR_ATTACHMENT_OPTIMAL/LAYOUT_DEPTH_ATTACHMENT_OPTIMAL/ (Nanley)
v6: Fix overly harsh assert()
Fixes: c1c346f1667375 ("anv: implement VK_KHR_separate_depth_stencil_layouts")
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4084
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8475>
(cherry picked from commit 28207669d03a7e4829169790dde332e90b6e0209)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ba9bb139ca2e07f9131389c5e7d468f8ff212ee
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Nov 30 15:29:31 2020 +0000
radv,aco: don't use MUBUF for multi-channel loads on GFX8 with robustness2
Fixes several dEQP-VK.robustness.robustness2.* tests on GFX8. Generations
other than GFX8 don't fail the tests because bounds-checking is done using
the index (making it per-vertex).
fossil-db (Polaris):
Totals from 1387 (0.99% of 140385) affected shaders:
(no statistics affected)
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Fixes: 03a0d39366d ("aco: use MUBUF in some situations instead of splitting vertex fetches")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7834>
(cherry picked from commit 914c61d6c0910fba0ba917aee12fc0a10aecfb32)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a19201a497ed5c2c7cb986b52e96b8e4b2cb95f
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Jan 21 13:26:30 2021 -0800
.pick_status.json: Update to c3dbc4df194a15aa1cf09493a3100b59e37e48fe
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b1408b95261174a029c0cb6e2a7b92f4d47862f
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Mon Jan 18 14:42:05 2021 +0200
st/mesa: fix pbo upload/download for arrays of textures with only 1 layer
Having only one layer we can put 0 as third texture coordinate
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4115
Fixes: 36097fc7 ("st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT and skip gs")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8576>
(cherry picked from commit e87b59f68779a7c838f35323fd9f4dddf146381d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f16cb1c5c98f32ac2e21098c5d3313aabff75212
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jan 20 10:09:33 2021 +0100
ci: exclude one CTS test that timeout most of the time for RADV CI
dEQP is too slow.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8587>
(cherry picked from commit 13f7224dbf31e602b0cdea37d7a2dca07a01da0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e63774d093b79b3ca86e37660b2f3c4104ec9b8a
Author: Gert Wollny <gert.wollny at collabora.com>
Date: Sun Jan 17 17:55:56 2021 +0100
r600/sfn: fix use of b32all/and
Fixes: f79b7fcf7c7f5db626efdb63f27e8bc64d0aed77
r600/sfn: use 32 bit bools
Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8563>
(cherry picked from commit 198c3acacf43389822c1cafd436eabd7127a199d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ddf994791fe63d7a7092067fb938bc231e803539
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Jan 12 13:59:14 2021 -0800
Revert "mesa: allow half float textures based on ARB_half_float_pixel"
This reverts commit aca67a555c011f59c37b05544eecbeea9aa42f3e, which
regressed the following Piglit test on i915 (and presumably r200):
piglit/spec/!opengl 1.1/sized-texture-format-channels
Specifically, it begins testing glTexImage2D with format GL_RGBA,
type GL_FLOAT, and internalFormat GL_RGB16F, which leads to the
following error:
Mesa 21.0.0-devel implementation error: unexpected format GL_RGB16F in _mesa_choose_tex_format()
Please report at https://gitlab.freedesktop.org/mesa/mesa/-/issues
sized-texture-format-channels: ../../src/mesa/main/teximage.c:2836: _mesa_choose_texture_format: Assertion `f != MESA_FORMAT_NONE' failed.
i915 and r200 unconditionally support ARB_half_float_pixel, but neither
support RGB16F as an internal format. According to Ian's rationale
in the commit message for 1edca151a00134778b959366d5e7c0a3b63cc8f7
(which enabled that extension for all drivers):
"This extension only adds data types that can be passed to, for
example, glTexImage2D. It does not add internal formats. Since
you can already pass GL_FLOAT to glTexImage2D this shouldn't pose
any additional issues with those drivers. Note that r200 and i915
already supported this extension, and they don't support
floating-point textures either."
So, commit aca67a55c011 enabled half-float internal formats on hardware
that cannot support them. We should revert the change.
v2: Don't reintroduce the _mesa_is_gles3() condition, as that shouldn't
be necessary (feedback from Erik Faye-Lund).
Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Reviewed-by: Erico Nunes <nunes.erico at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8458>
(cherry picked from commit 07473321a2b09283ac819e014b89c3535cee756b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ffa16bee6a3c6f0ff9f3984dfbf7edfc474af4f
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Jan 15 01:02:35 2021 -0800
tnl: Reset nr_bos to 0 between map/unmap cycles.
_tnl_draw_prims loops over the prims, and for each one, maps the VBOs,
draws, and unmaps them. But it failed to reset nr_bos = 0 between each
loop iteration, which meant that when processing prim[n], the BO list
had all BOs for prior primitives too. Assuming each primitive used the
same VBOs, that means the same VBO would appear in the list multiple
times, and it would try to unmap the same BO multiple times. This
triggered asserts on the second unmap, as it had already been unmapped.
Fixes Piglit's oes_draw_elements_base_vertex-multidrawelements on i915.
Fixes: e99e7aa4c1d ("mesa: switch Draw(Range)Elements(BaseVertex) calls to DrawGallium")
Acked-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8522>
(cherry picked from commit 9fb5d7acbbab04af3c85f7b6188af16eda824b43)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=14e0ee347917018b5350df786c16bbb7a35fe49b
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Jan 15 00:40:18 2021 -0800
tnl: Respect `start` when converting indices to GLuint
Prior to commit e99e7aa4c1ddd7b8c2c4388f4f8e4fa1955ca771 (mesa: switch
Draw(Range)Elements(BaseVertex) calls to DrawGallium), the indices
parameter of glDrawElements (an offset into the VBO) was handled by
setting ib->ptr. With that commit, it instead began binding the
index buffer with offset 0, and adding the offset to draw->start,
which eventually becomes prim->start.
t_draw.c's bind_indices() was trying to convert the relevant section of
the index buffer to GLuints, but was failing to account for start, so
it nabbed the wrong portion of the index buffer.
Fixes: e99e7aa4c1d ("mesa: switch Draw(Range)Elements(BaseVertex) calls to DrawGallium")
Acked-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8522>
(cherry picked from commit 376c8f750b9766d9704ced167dfaf00f521a92f4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f2fdb35f393b426d876773df2effe19e30349b8f
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Jan 14 15:45:20 2021 -0800
tnl: Try not to botch index buffer munging when start > 0.
Commit 4c751ad67aa2bbde5897030495f86e31c9e1fda7 (vbo/dlist: use a shared
index buffer) caused multiple draws to use the same index buffer, and
began setting the primitive's `start` field to the offset needed to
access the right portion of the index buffer.
Unfortunately, t_rebase_prims completely botches handling this case.
Say for example we had start = 40, min_index = 6, max_index = 11.
The actual indexes in the buffer are ib[40..45]. t_rebase_prims,
however, would allocate an index buffer containing only 6 elements,
and populate them with <ib[0..5] - min_index>. For one, this reads
the wrong source data, leading to garbage index values. For another,
it stores the new index buffer in the wrong spot, so drawing will try
and read elements [40..45] of an array of length 6, and crash.
This patch makes t_rebase_prims allocate a larger index buffer, with
the blank space at the beginning, and try to copy the correct section
of index buffer data over. This only works if `start` is the same for
all primitives, however, so if we detect different ones, we recurse
to rebase and call draw() separately for each different start value.
Fixes: 4c751ad67aa ("vbo/dlist: use a shared index buffer")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4082
Acked-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8522>
(cherry picked from commit bd6120f562d57e150aa2071f9108f538858311a6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8c31e03677f121dfca7c31ce0237be23a530434
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Jan 14 17:29:14 2021 -0800
vbo: Only mark merged line strips as lines when actually converting them
We only convert line strips to lines in certain cases, but were flagging
node->merged.prim as GL_LINES even if we simply copied a GL_LINE_STRIP
prim[0] over without modifying it.
Fixes Piglit's lineloop test (which triggers loop -> strip conversion
earlier in this path, then was incorrectly triggering strip -> list
mode modification with no changes to the underlying data).
Fixes: 310991415ee ("vbo/dlist: implement primitive merging")
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8522>
(cherry picked from commit 14ae5069da896cc93953e935051a76884800cac9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d07282a200bdd28c46b642c51ef00f065293826
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Jan 14 15:42:01 2021 -0800
vbo: Don't set node->min_index = max_index = indices_offset when merging
I'm can't see why this is necessary. There are already new fields
(node->merged.{min,max}_index) for the new values in the merged case.
But in vbo_save_draw.c, in the !draw_using_merged_prim case, we would
try and use the original node...with the now destroyed min/max index.
Fixes some assert failures when running with swtnl and forcing the
non-merged path (though it takes the merged path by default).
Fixes: 4c751ad67aa ("vbo/dlist: use a shared index buffer")
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8522>
(cherry picked from commit 44bdd5225c48d266e42d93defbb7ca9ae74aa21b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=664f6976b24d2374e5b6f674ec72bfa0fdfbb65c
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Mon Jan 18 11:19:20 2021 +0100
radv: flush L2 for images affected by the pipe misaligned issue on GFX10+
In some rare cases, L2 needs to be flushed if an image is affected
by the pipe misaligned issue. This is roughly based on AMDVLK.
I confirmed that disabling TC-compat HTILE, and respectively DCC,
for the relevant images also fixes the regressions below.
This fixes some regressions introduced with L2 coherency for
dEQP-VK.renderpass2.depth_stencil_resolve.image_2d_* and for
dEQP-VK.renderpass2.suballocation.multisample_resolve.*.
Fixes: 4a783a3c784 ("radv: Use L2 coherency on GFX9+.")
Co-Authored-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8557>
(cherry picked from commit 4c99d6ff54b2614b46d7e2252aa6c71c46045c16)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0acff8c6f22cc82995018b329f8f277241cd0b0e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Jan 19 10:16:37 2021 +0100
radv: restore invalidating the vector cache for internal meta operations
The driver used to invalidate the vector cache for meta operations
but this has been removed and I think it should be restored to fix
a bunch of regressions on GFX8.
This probably needs to be cleaned up but this is a hotfix.
This fixes a bunch of regressions and flakes on GFX8 like
dEQP-VK.pipeline.multisample.sample_locations_ext.draw.color.samples_4.*.
Fixes: 8f8d72af555 ("radv: Use access helpers for flushing with meta operations.")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8573>
(cherry picked from commit 8882abe47eb79f2975762343ed1dc596f45d2602)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=70e8dafb642743dc77b801ac33bbcfd5aab42b93
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jan 20 11:10:46 2021 -0800
.pick_status.json: Update to af9977a3d5f3378c297965e21389e36491f47e1b
More information about the mesa-commit
mailing list