Mesa (20.3): 56 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Jan 29 18:32:57 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6d8c68603f9496b12723216c15bf69976de57e97
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 29 10:12:53 2021 -0800
VERSION: bump version to 20.3.4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6562bda3f004ecc989b390b2dc2c5f9ee6169b8
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 29 10:12:48 2021 -0800
docs: add release notes for 20.3.4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=62dc4fedeb236011c168c1ec085a81010d0759a0
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Tue Jan 19 17:14:28 2021 -0800
compiler: Use util/bitset.h for system_values_read
It is currently a bitset on top of a uint64_t but there are already
more than 64 values. Change to use BITSET to cover all the
SYSTEM_VALUE_MAX bits.
Backported from 9f3d5e99ea6 ("compiler: Use util/bitset.h for
system_values_read").
Cc: mesa-stable
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Acked-by: Jesse Natalie <jenatali at microsoft.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Acked-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8728>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=74b1a83cab00168861e4098e234649e741a2c54d
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Thu Jan 21 08:41:15 2021 -0800
nir: Add a data pointer to the callback in nir_remove_dead_variables
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8706>
(cherry picked from commit cb7352ae95a48ba4f20286a59bea184072f52785)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c8245aebb5b9221ebfa7fb39a145d91e6f718f55
Author: David McFarland <corngood at gmail.com>
Date: Mon Nov 30 20:48:50 2020 -0400
radv: fix divide by zero with no tesselation params
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7878>
(cherry picked from commit e3f56601e0c00380748bbf0039b82a2212e405b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=918c550950d1a3c66f98ace532e52634b8c86d76
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Thu Jan 21 10:14:36 2021 -0800
spirv: Don't remove variables used by resource indexing intrinsics
In Vulkan, for some variable modes, the generated NIR will have derefs
pointing to resource index intrinsics instead of the variable. This
was letting nir_remove_dead_variables pass remove those variables,
which would lose information relevant for later passes after
spirv2nir.
Add a set to keep track of such variables and prevent them to be
removed when producing the NIR output.
Issue reported by Rhys.
Fixes: c4c9c780b13 ("spirv: Remove more dead variables")
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8706>
(cherry picked from commit 10b3eecd361af465e0e207fb18553ae37b924c45)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=daa0d8668b68b7ea0a732bbfd517769d50a40e3b
Author: Sagar Ghuge <sagar.ghuge at intel.com>
Date: Mon Jan 25 13:23:32 2021 -0800
anv: Skip CCS ambiguate which preceed fast-clears
We can skip CCS ambiguate if followed by a fast clear within render
pass.
v2: (Jason)
- Check array layer as well since we only fast clear first layer and
first LOD.
- Don't drop fast clear check while doing resolve operation.
Fixes: d5849bc840e "anv: Skip HiZ and CCS ambiguates which preceed fast-clears"
Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6988>
(cherry picked from commit 001722b3a301312d2ec16c939376098dc11fab98)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c2a6bbc712b345eb9683b90c239d50381bd36c12
Author: Francisco Jerez <currojerez at riseup.net>
Date: Thu Jan 21 14:21:50 2021 -0800
intel/gen12: Fix memory corruption issues in fused Gen12 parts.
According to the BSpec page for MEDIA_VFE_STATE, on Gen12 platforms
"if a fused configuration has fewer threads than the native POR
configuration, the scratch space allocation is based on the number of
threads in the base native POR configuration". However we currently
use the subslice count from devinfo->num_subslices[0], which only
includes the subslices currently enabled by the platform fusing. This
leads to scratch space underallocation and occasional hangs.
The problem is likely to affect most Gen12 GPUs with less than 96 EUs.
GFXBench5 Aztec Ruins is able to reproduce the issue fairly reliably.
Fixes: 9e5ce30da7fa3f1cc3badf "intel: fix the gen 12 compute shader scratch IDs"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8636>
(cherry picked from commit e2c5ef6cd6571a8522b9b75a99d245a538cf6183)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8b4805248c596f2d6391c0c4d9713ed3166ffff
Author: Icecream95 <ixn at disroot.org>
Date: Sun Jan 24 20:53:36 2021 +1300
panfrost: Use normal malloc/free instead of ralloc for surfaces
Fixes a double-free in some Qt5 WebEngine apps (e.g. ghostwriter).
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8678>
(cherry picked from commit 1d967132f3c4aefa72224d1029aa64a34053bf6b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=79eb7c245d1f2695a602e02136f3dbe51f9626ae
Author: Sagar Ghuge <sagar.ghuge at intel.com>
Date: Sat Jan 23 17:21:17 2021 -0800
anv: Invalidate the correct AUX-TT entry
While invalidating the AUX-TT entries, we have to consider the surface
offset as well otherwise, we will end up invalidating another surface's
CCS portion.
For eg. when we have HiZ+CCS and STC_CCS enabled, both will use the CCS
portion allocated at the end of BO. While invalidating the CCS portion
of stencil buffer, we will end up invalidating the CCS portion that
belongs to the depth main surface and vice-versa, if the surface offset
is not considered.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4123
Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
Acked-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8677>
(cherry picked from commit dab229ef69656179e1786eb097705c8d5505ade9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8031d0f78315ff62af2459f7482bbe75bc92b3b
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Jan 25 13:23:08 2021 +0200
anv: fix invalid programming of BLEND_STATE
We can't enable Logic Op & Color Buffer Blend. The Vulkan spec seems
to say Logic Op discards blending.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3767
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8691>
(cherry picked from commit 998f38bd9934e9eff156505244032c28df9fba31)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b6310c5225e9d7659e7ad20dc8d92604a11ec9de
Author: Christian Gmeiner <christian.gmeiner at gmail.com>
Date: Sat Jan 23 16:15:38 2021 +0100
etnaviv: handle NULL views in set_sampler_views
Passing NULL for the views parameter should be the same as passing an
array of NULL, according to the documentation. So let's respect that
detail.
This fixes a crash when using GALLIUM_HUD. The wrong handling of views
parameter was causing problems starting with
2813688f8db ("gallium/hud: don't use cso_context to restore VBs, constbuf 0 and sampler views").
Cc: <mesa-stable at lists.freedesktop.org>
Fixes: c9e8b49b885 ("etnaviv: gallium driver for Vivante GPUs")
Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8670>
(cherry picked from commit 81ab9fe2d0c2c2d9961107c88209f2fff1f136c4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=753f5bba85fea872db9643ba83622d18b765b44b
Author: Eric Anholt <eric at anholt.net>
Date: Tue Dec 1 14:05:30 2020 -0800
gallium: Fix leak of shader images on context destruction.
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit efff70e73ff6fbb1f73ace016c8eb53920629fe8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=70e586cd0e4ef3ebb6ed9e82d166edec7fb54757
Author: Eric Anholt <eric at anholt.net>
Date: Wed Jan 20 10:29:38 2021 -0800
panfrost: Stub out set_shader_images().
If PAN_MESA_DEBUG=deqp is set to enable testing, then we advertise shader
images to get GLES3.1, even though we don't have any of the shader image
funcs hooked up. This caused breakage when cso started unbinding shader
images at context destruction.
Just stub out the function for now, you'll still segfault when creating an
image.
Cc: mesa-stable (for the next commit)
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit f259fcae83c12e4df10ec2415a1660cc44810eb7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7918844eea4d2a2785ab492de9d78f0471ba58f
Author: Eric Anholt <eric at anholt.net>
Date: Fri Jan 22 11:23:35 2021 -0800
swr: Don't report support for shader images.
gallivm has images support, but this driver doesn't.
Cc: mesa-stable (for the upcoming shader image leak fix)
Acked-by: Jan Zielinski <jan.zielinski at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8530>
(cherry picked from commit 9445c3d59ff25e61e94f3fa888dd2ac16126b4ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e1c91eb68e257e9d796ebfcfc32264cf8e39e5e
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Jan 15 18:54:01 2021 +0100
aco/optimizer: don't copy-prop logical phis
This is dangerous w.r.t. LCSSA-phis.
Totals from 746 (0.54% of 139391) affected shaders (Navi10):
CodeSize: 8592160 -> 8568156 (-0.28%); split: -0.30%, +0.02%
MaxWaves: 5172 -> 5171 (-0.02%); split: +0.02%, -0.04%
Instrs: 1653949 -> 1648489 (-0.33%); split: -0.36%, +0.03%
Cycles: 49474892 -> 49329224 (-0.29%); split: -0.33%, +0.03%
VMEM: 137574 -> 137421 (-0.11%); split: +0.18%, -0.29%
SMEM: 42391 -> 42439 (+0.11%); split: +0.12%, -0.01%
VClause: 26946 -> 26943 (-0.01%)
Copies: 130902 -> 126176 (-3.61%); split: -4.05%, +0.43%
Branches: 54891 -> 54556 (-0.61%); split: -0.64%, +0.03%
PreVGPRs: 53941 -> 53939 (-0.00%)
This has a slight effect on RA due to affinity changes.
Cc: 20.3
Cc: 21.0
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8260>
(cherry picked from commit cd870d1b6aa43daa65f1e6c9763e5bdd7139acc9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4257b87367017755832068b5409025f975b4cc57
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Mon Dec 28 19:15:17 2020 +0000
aco/optimizer: don't propagate subdword temps of different size
It could happen that due to inconsistent copy-propagation
v1 = p_parallelcopy v2b
instructions were left after optimization on GFX8.
Cc: 20.3
Cc: 21.0
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8260>
(cherry picked from commit 856fd4750daf23ac3f8f40278cf685f36661c19f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=773a46157ed5c3b8419c0815754ce5256e9c4e4a
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Jan 26 09:20:26 2021 -0800
.pick_status.json: Update to f01ea0aef8a50d2732eb0c64153903e52ed2a757
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=431541e79135dc8da4d2d8bad7428013038c65b5
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Wed Aug 26 18:40:02 2020 +0200
mesa/main: remove leftover bumpmap code
This variable is only ever written as NULL, so we can omit it entirely.
Fixes: 4000c0112a4 ("Remove the ATI_envmap_bumpmap extension")
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6473>
(cherry picked from commit 92ff89f6f50c773f6d3531623db2997315d63c22)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b28e674f3f3b3ce08bf75266dee74c16bcc9cbb0
Author: Keith Packard <keithp at keithp.com>
Date: Thu Jan 21 12:19:12 2021 -0800
glx: Provide glvnd wrapper for glXSwapIntervalEXT
When using glvnd, this function needs to be exposed through
getDispatchAddress or libglvnd will not find it.
Signed-off-by: Keith Packard <keithp at keithp.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Fixes: 60ebeb4608a8 "glx: Implement GLX_EXT_swap_control for DRI2 and DRI3"
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8621>
(cherry picked from commit d548d781eee91842695cf54a3161348bf6a06a2e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f155875446fc0e43f47f939982fea8b84f63564c
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Tue Oct 27 00:36:53 2020 -0500
intel/fs: QUAD_SWIZZLE requires packed data
We could probably support some strides if we tried hard enough but the
whole point of this opcode is to accelerate things with crazy Align16 or
crazy regions. It's ok if we have to emit an extra MOV to get a packed
source.
Fixes: 8b4a5e641bc3 "intel/fs: Add support for subgroup quad operations"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
(cherry picked from commit 58bcb5401d85b4a21f6d9ea4eb7bff8e1ed7110f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=92f23b657cd7f8aecd28fc57c3d43c647ec5b39a
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Oct 26 20:53:37 2020 -0500
intel/compiler: Return 1 for immediates in regs_read
Previously, we were returning 2 whenever the source was a Q type. As
far as I can tell, the only reason why this hasn't blown up before is
that it was only ever used for VGRFs until the SWSB pass landed which
uses it for everything. This wasn't a problem because Q types generally
aren't a thing on TGL. However, they are for a small handful of
instructions.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7329>
(cherry picked from commit 4c8cbe9b1340db826fa21eec5fcbee6e6fc35efe)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fc1fe85482c9270e848d15a61a360cc5e1cd9d9
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Mon Jan 25 10:09:06 2021 -0800
.pick_status.json: Update to 9052819ebbff07d82c3eb9adf414144df4868644
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c5577bed0e8577c49abde9c51806dd77387a101a
Author: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Date: Sun Dec 6 14:56:58 2020 +0100
frontends/va/context: don't set max_references with num_render_targets
For HEVC and VP9 template's max_references are tied to the number of
surfaces associated with context. Later, the decoder is created if
max_references is different to zero.
But vaCreateContext() doesn't really need an array of VASurfaceIDs (see
https://lists.01.org/pipermail/intel-vaapi-media/2017-July/000052.html and
https://github.com/intel/libva/issues/251).
This patch removes the validation of the max_references at decoder
creation and also remove the assignation of num_render_targets to
max_references.
Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
Reviewed-by: Leo Liu <leo.liu at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7949>
(cherry picked from commit 925d701014c2ba084061eae131f4b5c75e595f29)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=06fadeeda7b6d3e465959c16ae4c886319bb9aca
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 12:41:42 2021 +0100
zink: make all xfb caps depend on extension
Without this, we'll expose GL_ARB_transform_feedback2 and
GL_ARB_transform_feedback3 even without VK_EXT_transform_feedback,
because these caps are directly wired up without checking the pervious
extensions.
Fixes: e8ad52f7b0c ("zink: enable xfb extension in screen creation")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 855370bb620663b5e451e08046e4ddb4b6429c0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=199fb00815f2cf87fd18b539192e5ce0e81fc28c
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 09:11:51 2021 +0100
zink: respect feature-cap for sample-shading
Vulkan has a cap to enable this, we should check that one rather than
always claiming support.
Fixes: 0c70268ff73 ("zink: mark ARB_sample_shading as supported")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 6f6941e2dd8f1d1d1d6e52276485d41c7dd0b029)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3efcf3b34f77339f388f1814767252eb05500ff1
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Fri Jan 22 09:09:03 2021 +0100
zink: respect feature-cap for independent blending
Vulkan has a cap to enable this, we should check that one rather than
always claiming support.
Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan")
Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8640>
(cherry picked from commit 612169859a3300879fa890a03a8693ab3c718d2c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=613251e8519a115af8a8755f31f91f67c44b85e1
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Jan 22 10:47:19 2021 +0000
aco: don't consider a phi trivial if same's register doesn't match the def
For example:
s2: %688:s[32-33] = p_linear_phi %3:s[10-11], %688:s[32-33]
would have been considered trivial.
This might happen due to parallelcopies when assigning phi registers.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 69b6069dd28 ("aco: refactor try_remove_trivial_phi() in RA")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8645>
(cherry picked from commit 824eba2148e56a75d0678011b4f546cabbd5d345)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=127e9ef456326fbc31cb1dd5621a43c8e2598a75
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Jan 20 14:10:49 2021 -0800
iris: Consider resolves after changing a resource's aux state
The intention of IRIS_DIRTY_{RENDER,COMPUTE}_RESOLVES_AND_FLUSHES
is to avoid considering resolves/flushes on back to back draw calls
where nothing of significance has changed with the resources. When
anything changes that could require a resolve, we must flag those.
Those situations are:
1. Texture/image/framebuffer bindings change
(as the set of images we need to look at is now different)
2. Depth writes are enabled/disabled (the resolve code uses this)
3. The aux state for a currently bound resource changes.
We were missing this last case. In particular, one example where
we missed this was:
1. Bind a texture.
2. Clear that texture (likely blits/copies/teximage would work too)
3. Draw and sample from that texture
Clear-then-Bind would work, as binding would flag resolves as dirty.
But Bind-then-Clear doesn't work, as clear can change the aux state
of the bound texture, but wasn't flagging that anything had changed.
Technically, we could consider whether the resource whose aux state
is changing is bound for compute (and only flag COMPUTE_RESOLVES),
or bound for a 3D stage (and only flag RENDER_RESOLVES), and flag
nothing at all if it isn't bound. But we don't track that well,
and it probably isn't worth bothering. So, flag unconditionally
for now.
This does not appear to impact Piglit's drawoverhead scores.
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3994
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4019
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8603>
(cherry picked from commit e2500c02cc7bd429e035c5208e533e569c525b03)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c2932690c6366a58922daea9b75e2b27d30dce2e
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jan 20 17:29:14 2021 +0100
radv: fix a sync issue with geometry shader primitives query on GFX10+
When NGG is used, the hw can't know the number of geometry shader
primitives. To fix that, the NGG geometry shader accumulates itself
the number of primitives by using an atomic operation directly to GDS.
Then, begin/query copy the start/stop values from GDS to the
query pool buffer using a PS_DONE event. This was actually wrong
because PS_DONE is completely asynchronous to everything and executed
when the preceding draws finish pixel shaders.
Fix this by using a COPY_DATA packet which is synced with CP. This
fixes random failures on Sienna Cichlid with
dEQP-VK.query_pool.statistics_query.*.geometry_shader_primitives.*.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8590>
(cherry picked from commit 085e2ce3d49c36ad2c119313e47c0ac685828a61)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d038bd7b3ed729bcc3be120dbdaf53dc0a3484cf
Author: Icecream95 <ixn at disroot.org>
Date: Wed Jan 20 10:46:05 2021 +1300
pan/decode: Free mapped memory objects on BO unreference
Cc: mesa-stable
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8583>
(cherry picked from commit 0d0536c1a7662e2c1d99d221c444bc19ca3ab566)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fc12bcbc009d09868da63ac9502b62f715bfe9b
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Jan 13 16:09:18 2021 +0200
anv: Fix stencil layout in render passes
We incorrectly utilize the stencil layouts structures even if we
should stick to the depth_stencil ones if the layout includes stencil.
v2: Don't forget stencil only layout (Nanley)
Simplify callers of new helper functions (Nanley)
v3: Store VK_IMAGE_LAYOUT_UNDEFINED when no stencil is available (Nanley)
Use a switch statement (Nanley)
v4: Consider all layouts but depth only to be potential stencil layouts (Lionel)
v5: Refactor helper in vk_image_layout_depth_only() and discard
VkAttachmentDescriptionStencilLayoutKHR in
VkAttachmentDescription2KHR if format is not depth/stencil.
v5: s/LAYOUT_COLOR_ATTACHMENT_OPTIMAL/LAYOUT_DEPTH_ATTACHMENT_OPTIMAL/ (Nanley)
v6: Fix overly harsh assert()
Fixes: c1c346f1667375 ("anv: implement VK_KHR_separate_depth_stencil_layouts")
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4084
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8475>
(cherry picked from commit 28207669d03a7e4829169790dde332e90b6e0209)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d168e8f24fc58cb00a7a144b073c437e5d86a12
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 22 09:06:48 2021 -0800
.pick_status.json: Update to 3ef89b245e3e1ac4e67fea9c1b13ebeda75769d0
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a098a704a41e98a3b5e694d8801820fc795567c6
Author: Andrii Simiklit <andrii.simiklit at globallogic.com>
Date: Mon Jan 18 14:42:05 2021 +0200
st/mesa: fix pbo upload/download for arrays of textures with only 1 layer
Having only one layer we can put 0 as third texture coordinate
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4115
Fixes: 36097fc7 ("st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT and skip gs")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8576>
(cherry picked from commit e87b59f68779a7c838f35323fd9f4dddf146381d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ed63e74616909a7487015ca7db500848e85207f
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jan 20 10:09:33 2021 +0100
ci: exclude one CTS test that timeout most of the time for RADV CI
dEQP is too slow.
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8587>
(cherry picked from commit 13f7224dbf31e602b0cdea37d7a2dca07a01da0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=44d9a7f6fba15b690290753e16231985083b5ca2
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Jan 20 09:07:15 2021 -0800
.pick_status.json: Update to af9977a3d5f3378c297965e21389e36491f47e1b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fab4ed028d6dee40b47aa8967075b6ad4081529
Author: jzielins <jan.zielinski at intel.com>
Date: Thu Dec 10 12:15:33 2020 +0100
swr: fix crashes caused by incorrectly reporting SSBO support
Reviewed-by: Krzysztof Raszkowski <krzysztof.raszkowski at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8597>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=79b792e46184764262c8a46d643a83c425383a94
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Jan 19 14:34:40 2021 +0000
aco: fix convert_to_SDWA() check in add_subdword_definition()
v_or_b32 with a v2b definition should use SDWA if is_partial=true.
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 56345b8c610 ("aco: allow reading/writing upper halves/bytes when possible")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8577>
(cherry picked from commit fcda9b67374e7c98c7a84b916bb32a8aaa84d414)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d1920b6c57ba1959d872bc57f28059bb8914f0d
Author: Marek Olšák <marek.olsak at amd.com>
Date: Fri Jan 15 16:43:57 2021 -0500
mesa: fix alpha channel of ETC2_SRGB8 decompression for !bgra
If software decompression is used for ETC2, the alpha channel
for sRGB8 textures would be set only if BGRA is true.
Fixes: e5604ef78bd "st/mesa/i965: Allow decompressing ETC2 to GL_RGBA"
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8529>
(cherry picked from commit 290dcb26aec583eb00be611b7b69e3f3f9667781)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=381a5de3eaa2083bccef456a405a2fe6d3e0d854
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date: Mon Jan 18 17:48:27 2021 +0100
zink: handle NULL views in zink_set_sampler_views
Passing NULL for the views parameter should be the same as passing an
array of NULL, according to the documentation. So let's respect that
detail.
This fixes a crash when using GALLIUM_HUD.
Fixes: 8d46e35d16e ("zink: introduce opengl over vulkan")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8564>
(cherry picked from commit 333730405de28153f2378d498e45cb82024fc230)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e2e95a318d3de8edecc7c4933f75ffc4f34c4f7
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Sat Jan 16 01:10:24 2021 -0500
glsl: only expose int64 atomics when extension is enabled
This limits the exposure of these functions to when the extension is
available. Prevents crashes otherwise, as the rest of the infrastructure
doesn't necessarily expect these functions when the extension is not
available.
Fixes: 40c1f9883e5 ("mesa,glsl: add support for GL_NV_shader_atomic_int64")
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8533>
(cherry picked from commit a0f4affcf64cfd13a27f1e3cc24f98ef220b691b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0aa060c5b41a57cecc39cff7b8a9f611c95958ca
Author: Dave Airlie <airlied at gmail.com>
Date: Fri Jan 15 09:57:52 2021 +1000
lavapipe: fix missing piece of VK_KHR_get_physical_device_properties2
I missed two parts of the APIs for this, so add them, should fix
crashes in gstreamer vulkan when it tries to load lvp.
Cc: <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3989
Reviewed-by: Adam Jackson <ajax at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8511>
(cherry picked from commit 7b48d5d36e0177a9346b75af6f41031e4c7b1220)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8eb3a0b6cb77004ea6ec5efa9c2b2c7928ea332e
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date: Tue Jan 12 16:44:34 2021 -0800
Fall back on clock_gettime when timespec_get() is unavailable
Fixes: e3a8013de8ca "util/u_queue: add util_queue_fence_wait_timeout"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/1020
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4088
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Signed-off-by: Yurii Kolesnykov <root at yurikoles.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8482>
(cherry picked from commit 68a785e63fe848c7bcd48bce2095670926f97eea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=affb8eebe405854b93452eeca54b4ad0289542c2
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Jan 15 09:19:03 2021 +1000
device-select-layer: update for vulkan 1.2
The vulkan loader doesn't load layers for apps that require a newer
version of vulkan, so this layer didn't get loaded for vulkan 1.2 apps.
I would like to just stick 1.09 in there but it might be worth
validating it works at new version of vulkan I suppose and the major
doesn't revise that often
Fixes: 9bc5b2d169d3 ("vulkan: add initial device selection layer. (v6)")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8508>
(cherry picked from commit ca834d0b2dcf347e062e33c1bf930632b76d3025)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8755481ce13cd187d04469058d0a1db3ff0b6d5
Author: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Date: Thu Jan 14 10:16:15 2021 -0800
util: Fix pointer to integer conversion error when using libunwind
../src/util/u_debug_stack.c:97:20: error: incompatible pointer to integer conversion assigning to 'unw_word_t' (aka 'unsigned long') from 'void *' [-Werror,-Wint-conversion]
pip.unwind_info = NULL;
^ ~~~~
1 error generated.
Fixes: 70c272004f72 "gallium/util: libunwind support"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4094
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8507>
(cherry picked from commit 08ac7b52e7814540e92d5add29049324f6841bb5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a6e9b3644aa90927fb23a95fda0bff3b24f619c2
Author: Eric Anholt <eric at anholt.net>
Date: Thu Jan 14 16:17:21 2021 -0800
util/format: Fix pack/unpack of A1R5G5B5_UINT.
Avoids regressing KHR-GL33.packed_pixels.pbo_rectangle.* when
transitioning from mesa/main pack/unpack codegen to util/format's.
Fixes: b28eb044cdc1 ("gallium: Add equivalents of packed MESA_FORMAT_*UINT formats.")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6297>
(cherry picked from commit e5e75b714d7a386cbdd0956ee4e9a5b4c70c963e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fb89e0f381bee931365c97d819db8986cea09b4
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Jan 19 09:39:58 2021 -0800
.pick_status.json: Update to 3e13c1f8dfef4a4c0fd5e79bbc364f9e5f998856
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1d0a7bb520358c9bfd059c83925cdfea618fc35d
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Aug 31 16:42:32 2020 +0300
intel/mi_builder: fix self modifying batches
So far we only write a maximum of 4 dwords further into the batch and
it seems just going over the CS prefetch was enough.
Turns out writing more dwords can delay the writes and we start
prefetching stuff that hasn't landed in memory yet.
This fixes the issue by stalling the CS to ensure the writes have
landed before we go over the prefetch.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 796fccce631bf8 ("intel/mi-builder: add framework for self modifying batches")
Reviewed-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8525>
(cherry picked from commit d8154c40063d0d6114370c30c800676039e358ee)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d4a0136e268702ba1aa431298cf002d967b32e50
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date: Tue Jan 12 18:45:49 2021 +0100
v3d: fix dest offset in TFU setup
It is using the source level instead of the destiny level (base_level)
to compute the dest offset.
This fixes `framebuffer-blit-levels draw rgba -auto -fbo` piglit test.
Fixes: 976ea90bdca ("v3d: Add support for using the TFU to do some blits.")
Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8491>
(cherry picked from commit 08b16cfe0bc4eb86c166440f70435224b9f44244)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d5ee8416e2724a1b9f3e207ab5ac15e1bfc99f32
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date: Thu Oct 15 17:21:14 2020 +0300
iris: only set point sprite overrides if actually using points
Fixes black screen in some FNA games.
Cc: <mesa-stable at lists.freedesktop.org>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3431
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7218>
(cherry picked from commit 0c08a66ce526913ed2691f982f600285206248b8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=851d753c1b668a2fa7ad988550a05a953d83caa4
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Jan 15 09:17:39 2021 -0800
.pick_status.json: Update to c27347b2e1883a30e023347a36bdcf86cdec4a7c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=205e8cd09354422a8f1b80aaea49e3e0c770f972
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date: Mon Jan 11 20:40:09 2021 +0100
radeonsi: invalidate compute sgprs in si_rebind_buffer
If we don't tag compute sgpr as dirty they will point to the
ol buffer location.
This fixes arb_compute_shader-dlist with mcbp enabled.
Fixes: 85a6bcca615 ("radeonsi: pass at most 3 images and/or shader buffers via user SGPRs for compute")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8433>
(cherry picked from commit 17f8e56c96ca6cfafa90c87564441b4fb7fa1b23)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfb6f66934f5881c94d0d2044a5db12a23306df8
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Jan 4 13:47:37 2021 +0100
anv: add transfer usage for color/depth/stencil attachments
We sometimes use anv_layout_to_aux_state() to compute the aux state of
an image during the resolve operations at the end of a render
(sub)pass.
If we're dealing with a multisampled image that is created without a
transfer usage, our internal code might trigger a resolve using the
transfer layout (see genX_cmd_buffer.c:cmd_buffer_end_subpass), for
which the image doesn't the usage bit. The current code tries to AND
the 2 usages which won't have any bit in common, thus skipping all
checks below.
v2: Add the transfer usages depending on attachment usage (Lionel)
v3: Limit to samples > 1 (Jason) && DEPTH_STENCIL_ATTACHMENT_BIT (Lionel)
v4: Add transfer usage at image creation (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: 54b525caf0aa99 ("anv: Rework anv_layout_to_aux_state")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4037
Reviewed-by: Reviewed-by: Tapani Pälli <tapani.palli at intel.com> (v1)
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8307>
(cherry picked from commit d4b4d69d4dc387a3d999f4d820fe9471dd9cf8b9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cb24282b01faea949baa9d10a5d007aa683d6fcf
Author: Witold Baryluk <witold.baryluk+freedesktop at gmail.com>
Date: Fri Jan 8 10:16:53 2021 +0000
lavapipe: Defer lavapipe warning to CreateDevice
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4055
Fixes: b38879f8c5f57b7f1802e433e33181bdf5e72aef
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8377>
(cherry picked from commit 9c54928f7762a59da4638a563e6c852ecbb9c76f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3398f1c862a38071d9715faf903eba733926f985
Author: Thong Thai <thong.thai at amd.com>
Date: Mon Jan 4 15:53:02 2021 -0500
frontends/va: Return an error if non-interlaced buffer is not supported
Add a check to vaDeriveImage to see if a non-interlaced buffer was
created successfully. Otherwise, return an error, since we won't be able
to derive an image from the interlaced buffer.
Prevents a null pointer dereference from occuring on some nVidia cards,
reported by Alexander Kapshuk.
v2: Check for PIPE_VIDEO_CAP_SUPPORTS_PROGRESSIVE support (Ilia)
Fixes: fcb558321e6 ("frontends/va: Derive image from interlaced buffers")
Signed-off-by: Thong Thai <thong.thai at amd.com>
Tested-by: Alexander Kapshuk <alexander.kapshuk at gmail.com>
Reviewed-by: Leo Liu <leo.liu at amd.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8320>
(cherry picked from commit 4b208cc503ddf0c4ed81e24cf4bf68403072c7d1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d20fc6a8554a856f7ca264eee0c634123bbec72
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Thu Jan 14 09:18:46 2021 -0800
.pick_status.json: Update to 184bbef33d1fff3520958c130f2b8e4fce17379c
More information about the mesa-commit
mailing list