Mesa (master): v3dv: Fix assert.

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: c897f7a72272e19002f2bff25b3ef9ed865fa3d6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c897f7a72272e19002f2bff25b3ef9ed865fa3d6

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Fri Jan 22 18:49:12 2021 -0800

v3dv: Fix assert.

Fix defect reported by Coverity Scan.

Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment job->ez_state =
VC5_EZ_DISABLED has a side effect. This code will work differently in a
non-debug build.

Fixes: cec2ed7c80f ("v3dv: fix disabling Early Z for the whole frame")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8666>

---

 src/broadcom/vulkan/v3dv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c
index 93de64c2752..e390305b218 100644
--- a/src/broadcom/vulkan/v3dv_cmd_buffer.c
+++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c
@@ -3005,7 +3005,7 @@ job_update_ez_state(struct v3dv_job *job,
     * packet, so ez_state must also be VC5_EZ_DISABLED;
     */
    if (job->first_ez_state == VC5_EZ_DISABLED) {
-      assert(job->ez_state = VC5_EZ_DISABLED);
+      assert(job->ez_state == VC5_EZ_DISABLED);
       return;
    }