Mesa (main): zinK: tweak shader module update -> pipeline combined_dirty conditional

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: fd2d463a987f89df985e2c8b3365849792c2d649
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd2d463a987f89df985e2c8b3365849792c2d649

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri May 14 17:44:29 2021 -0400

zinK: tweak shader module update -> pipeline combined_dirty conditional

make this more explicit

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11691>

---

 src/gallium/drivers/zink/zink_program.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/gallium/drivers/zink/zink_program.c b/src/gallium/drivers/zink/zink_program.c
index b1a6fcdc84a..3339884823d 100644
--- a/src/gallium/drivers/zink/zink_program.c
+++ b/src/gallium/drivers/zink/zink_program.c
@@ -317,11 +317,12 @@ update_shader_modules(struct zink_context *ctx, struct zink_shader *stages[ZINK_
          struct zink_shader_module *zm;
          zm = get_shader_module_for_stage(ctx, dirty[i] ? dirty[i] : stages[type], prog);
          zink_shader_module_reference(zink_screen(ctx->base.screen), &prog->modules[type], zm);
+         ctx->gfx_pipeline_state.combined_dirty |= zm->shader != ctx->gfx_pipeline_state.modules[type];
+         ctx->gfx_pipeline_state.modules[type] = zm->shader;
+      } else if (!stages[type]) {
+         ctx->gfx_pipeline_state.combined_dirty |= ctx->gfx_pipeline_state.modules[type] != VK_NULL_HANDLE;
+         ctx->gfx_pipeline_state.modules[type] = VK_NULL_HANDLE;
       }
-      if (ctx->gfx_pipeline_state.modules[type] !=
-          (prog->modules[type] ? prog->modules[type]->shader : VK_NULL_HANDLE))
-         ctx->gfx_pipeline_state.combined_dirty = true;
-      ctx->gfx_pipeline_state.modules[type] = prog->modules[type] ? prog->modules[type]->shader : VK_NULL_HANDLE;
    }
    ctx->gfx_pipeline_state.module_hash = _mesa_hash_data(ctx->gfx_pipeline_state.modules, sizeof(ctx->gfx_pipeline_state.modules));
    unsigned clean = u_bit_consecutive(PIPE_SHADER_VERTEX, 5);