Mesa (main): lavapipe: only apply pipeline state for depth bias if it's enabled

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 7 02:44:20 UTC 2021


Module: Mesa
Branch: main
Commit: e0fbaac24261fec03c57f1b94615c03fc1b4567b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0fbaac24261fec03c57f1b94615c03fc1b4567b

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Tue Jul  6 12:20:54 2021 -0400

lavapipe: only apply pipeline state for depth bias if it's enabled

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11736>

---

 src/gallium/frontends/lavapipe/lvp_execute.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/gallium/frontends/lavapipe/lvp_execute.c b/src/gallium/frontends/lavapipe/lvp_execute.c
index d0cdcbd6c25..81694cea4d5 100644
--- a/src/gallium/frontends/lavapipe/lvp_execute.c
+++ b/src/gallium/frontends/lavapipe/lvp_execute.c
@@ -466,9 +466,13 @@ static void handle_graphics_pipeline(struct lvp_cmd_buffer_entry *cmd,
       }
 
       if (!dynamic_states[VK_DYNAMIC_STATE_DEPTH_BIAS]) {
-         state->rs_state.offset_units = rsc->depthBiasConstantFactor;
-         state->rs_state.offset_scale = rsc->depthBiasSlopeFactor;
-         state->rs_state.offset_clamp = rsc->depthBiasClamp;
+         if (pipeline->graphics_create_info.pRasterizationState->depthBiasEnable) {
+            state->rs_state.offset_units = rsc->depthBiasConstantFactor;
+            state->rs_state.offset_scale = rsc->depthBiasSlopeFactor;
+            state->rs_state.offset_clamp = rsc->depthBiasClamp;
+         } else {
+            state->rs_state.offset_clamp = state->rs_state.offset_scale = state->rs_state.offset_units = 0.0;
+         }
       }
 
       if (!dynamic_states[conv_dynamic_state_idx(VK_DYNAMIC_STATE_CULL_MODE_EXT)])



More information about the mesa-commit mailing list