Mesa (main): st/xa: Mark default xa_get_pipe_format case unreachable.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jul 12 19:11:51 UTC 2021
Module: Mesa
Branch: main
Commit: a8628fb32e13439bd63e9abc0079ca28a4822645
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8628fb32e13439bd63e9abc0079ca28a4822645
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sat Feb 13 20:56:43 2021 -0800
st/xa: Mark default xa_get_pipe_format case unreachable.
Fix defect reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value fdesc. Field fdesc.format is uninitialized.
Fixes: 9f2f5b3d7fd ("st/xa: Initial import of the xa state-tracker and the xa-vmwgfx target.")
Suggested-by: Adam Jackson <ajax at redhat.com>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9035>
---
src/gallium/frontends/xa/xa_tracker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/frontends/xa/xa_tracker.c b/src/gallium/frontends/xa/xa_tracker.c
index 31162606375..c802a40edb4 100644
--- a/src/gallium/frontends/xa/xa_tracker.c
+++ b/src/gallium/frontends/xa/xa_tracker.c
@@ -155,7 +155,7 @@ xa_get_pipe_format(struct xa_tracker *xa, enum xa_formats xa_format)
fdesc.format = PIPE_FORMAT_L8_UNORM;
break;
default:
- fdesc.xa_format = xa_format_unknown;
+ unreachable("Unexpected format");
break;
}
return fdesc;
More information about the mesa-commit
mailing list