Mesa (staging/21.1): 23 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Jul 12 23:30:51 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fcd2fdc0f91c3f7acadc043c9b841c20ddfac55
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sat Feb 13 20:56:43 2021 -0800
st/xa: Mark default xa_get_pipe_format case unreachable.
Fix defect reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value fdesc. Field fdesc.format is uninitialized.
Fixes: 9f2f5b3d7fd ("st/xa: Initial import of the xa state-tracker and the xa-vmwgfx target.")
Suggested-by: Adam Jackson <ajax at redhat.com>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9035>
(cherry picked from commit a8628fb32e13439bd63e9abc0079ca28a4822645)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f4bcc955e8e4e6accf252ec355fe7662cc27995b
Author: Thomas H.P. Andersen <phomes at gmail.com>
Date: Wed Jul 7 16:50:05 2021 +0200
broadcom/compiler: fix add vs. mul
Spotted by a compile warning
Fixes: 7f61ff7b4d1 ("broadcom/compiler: Merge instructions more efficiently")
Reviewed-by: Iago Torral Quiroga <itoral at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11764>
(cherry picked from commit cf05a7e66fa3e0ff2003cf419bc93f8a69225a03)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=30e517afb2bedff0db7a43588a91c40e8e0d394b
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 6 23:06:43 2021 -0400
radeonsi,radv: fix a late alloc deadlock with <= 6 CUs per SA
We should always prevent 1 CU from executing VS and GS waves
to prevent a deadlock.
Fixes: c377f45c1833052 "radeonsi/gfx10: rewrite late alloc computation"
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11754>
(cherry picked from commit 66f254b4e6ca604c9e866248659dbd1d4a6de0b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b506aa0db4349f6f85efe3e24c5f70bd4ec5d742
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 6 13:15:12 2021 -0400
ac/surface/tests: fix the ARM build
Fixes: 8771d45a "ac/surface/tests: fix a random segfault in the modifier test"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4655
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11754>
(cherry picked from commit c4644bf3e6f6de951d7adc64cb7c4809fb28dc24)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3c766d45b63c59bce9b32f80a597a65aa499732d
Author: Connor Abbott <cwabbott0 at gmail.com>
Date: Mon Jun 28 18:41:41 2021 +0200
ir3: Fix infinite loop in scheduler when splitting
When we go to split e.g. a p0.x producer, the only other instructions
ready to schedule are often only p0.x producers. It could happen that
they all have a lower priority than the split instruction. Then we would
immediately schedule the split instruction again, then again try to
schedule one of the other producers, be blocked, and split it, around
and around again, leading to an infinite loop. The following commit
triggered this with
dEQP-GLES3.functional.shaders.discard.dynamic_loop_always on a3xx.
Fixes: d2f4d33 ("freedreno/ir3: new pre-RA scheduler")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6752>
(cherry picked from commit bb3212dd4d80fd945654f3ca5380fd472fba92a4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=00e4af664bc0847caddaeb30b2371dfb025fa77f
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Jul 8 09:09:25 2021 +0200
aco: fix shared_atomic_comp_swap if the second source isn't a VGPR
Only VGPRs are valid with DS instructions.
Cc: 21.1 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11777>
(cherry picked from commit 74a221bcfd8dd8a1badbb44c71c38485d6c05ec2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8fcdf489522eb814f8054998fcbaed224657c3c8
Author: Qiang Yu <yuq825 at gmail.com>
Date: Wed Jul 7 15:00:50 2021 +0800
st/mesa: fix size miss match for some check
While we shrink some variable from "GLuint" to "ubyte",
need to update the check from "x != ~0U" to "x != 0xff" too.
This fixes the crash for SPECviewperf 13 benchmark medical
case.
Fixes: d947e3e2c8c2 "st/mesa: decrease the size of st_vertex_program"
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11757>
(cherry picked from commit cf66ccf3f0ca7c71576d2ff675ac61d2a9f295e3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=eb522f287173508d5a33f2138a3cee034f31f37f
Author: Heinrich Fink <hfink at snap.com>
Date: Tue Jul 6 20:37:52 2021 +0200
softpipe: add missing sentinel to debug option array
Add DEBUG_NAMED_VALUE_END to finalize debug option array (see
lp_screen.c). Otherwise debug_get_flags_option might attempt to read
debug_named_value::name at an offset and SIGSEGV.
Signed-off-by: Heinrich Fink <hfink at snap.com>
Fixes: 991def0edc8 ("softpipe: Convert to comma-separated SOFTPIPE_DEBUG for debug options.")
Reviewed-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11742>
(cherry picked from commit a2c92da9a1d333737c3483714de5334c33d4062f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ed5eec1ab11e637beec3431175272620de9c095
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Sun Jul 4 21:20:59 2021 +1000
util/radeonsi: add radeonsi workaround for Nuclear Throne
Without radeonsi_sync_compile the game crashes at startup. The
game engine uses a custom global new operator which doesn't
play well with multithreading.
Fixes: f1cc13727c68 ("radeonsi: enable workarounds for YoYo engine based games")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5023
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11701>
(cherry picked from commit 80a377ad81ce7b94b4d3a84fc103962e96d204d8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=52c1e3075324d803472862bebaf8ab4f89bdb338
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Mon Jun 28 19:11:46 2021 -0500
iris: Don't leak the surface if uncompressed re-interp fails
Fixes: a032a9665f27 "iris: Enable PIPE_CAP_SURFACE_REINTERPRET_BLOCKS"
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11647>
(cherry picked from commit 98faa09bb5a0828762bc5e7834a434797d9aa86f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fa1babdea9e5e5039f6c73e10fe270a88fba3a5
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun May 2 03:51:29 2021 +0200
ac/surface: Handle non-retiled displayable DCC correctly for modifiers.
There is some hardware with num_render_backends == 1, but the number
of render backends in GB_ADDR_CFG > 1. Turns out this can be turned
off by making them rb unaligned which is valid with only 1 render
backend.
Fixes: 0833dd7d124 ("amd/common: Add support for modifiers.")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10575>
(cherry picked from commit e2e9dd44f42261445d1af87624cedb3d09d63600)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=864781a8742ec41992d8156ec9b98dbe0ff4e1ba
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Wed Apr 29 14:08:48 2020 +0300
glsl: Prohibit implicit conversion of mem parameter in atomicOP functions
Per OpenGL Shading Language, section 8.11. "Atomic Memory Functions"
first argument "mem" of all atomicOP functions is inout.
The same is true for ARB_shader_storage_buffer_object and
GL_INTEL_shader_atomic_float_minmax
For implicit conversion of inout parameters it is required for type
to support bi-directional conversion, since there is no such types
in glsl - implicit conversion is effectively prohibited.
Alternatively we could have marked atomic_var parameter of built-in
atomicOP functions as inout, however it opens another can of worms
during NIR lowerings.
Fixes: ea0a1f5beb22982a886ba862ba95f92c9e35165a
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2837
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4887>
(cherry picked from commit c0f623e62fb02faf24dc43179222b289a0e03683)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0978c00427a8ce6ce6aefbd1e7b578d2276ca94
Author: Dave Airlie <airlied at redhat.com>
Date: Wed May 26 14:27:14 2021 +1000
draw: fix tessellation output vertex size calculation
This ensures space for the extra outputs is calculated in the
tes vertex outputs.
dEQP-VK.pipeline.misc.primitive_id_from_tess
Fixes: dacf8f5f5c82 ("draw: hook up final bits of tessellation")
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11000>
(cherry picked from commit 45d9e8bb99ffb6ec5babec063e4665c323d56073)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e09d3077f71fde8fa254afc1258efc482a722c1
Author: Thomas H.P. Andersen <phomes at gmail.com>
Date: Tue Jun 29 00:54:40 2021 +0200
nir/ifind_msb_rev: fix input check
ifind_msb_rev was introduced in a5747f8ab357ff00c630b937b221e5fb59d90289.
ifind_msb_rev guards against src0 being both 0 or -1 at the same time.
That is always true. This patch changes it to check for those values
individually.
Spotted from a compile warning.
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Fixes: a5747f8ab35 (\"nir: add opcodes for *find_msb_rev and lowering\")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11630>
(cherry picked from commit ffea62260415c9e1b5c8fa076ac0285c0145447e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=05409f7b2c6759df39ec664cd1fdcd83dd96015c
Author: Michel Dänzer <mdaenzer at redhat.com>
Date: Thu Jul 1 16:40:16 2021 +0200
Fix up leftover "state_trackers" references to "frontends"
Fixes: d6287a94b69 "gallium: rename 'state tracker' to 'frontend'"
Reviewed-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11676>
(cherry picked from commit 61a2cfc302b57efcb6df829f303d363fef73631f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=768deb86b9d000132a0ad194929fa91ca6aa8374
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Wed Jun 30 18:16:55 2021 -0400
nir: Fix constant folding for irhadd/urhadd
This should be a subtract, not an add. The comment's proof is correct,
but the (wrong) expression we actually use isn't what it's in the
comment! Correct the discrepancy.
The lowering in nir_opt_algebraic was correctly typed.
Fixes: 272e927d0e9 ("nir/spirv: initial handling of OpenCL.std extension opcodes")
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Karol Herbst <kherbst at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11671>
(cherry picked from commit 3da23a9c7e6f34ea50c1ba415991c7ff1b443ef6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cb32d5403207b7cf0629ed1b6a1eb3e7e1af56b9
Author: Rob Clark <robdclark at chromium.org>
Date: Wed Jun 30 09:49:40 2021 -0700
freedreno/a6xx: Fix framebuffer_barrier crash
This is emitting cmdstream, it should take the submit lock to (a) ensure
we actually have a batch, and (b) prevent it from being flushed from
under it. This was overlooked in the conversion.
Fixes: 02298ed1fc6 ("freedreno: Add submit lock")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11658>
(cherry picked from commit 525be273266fb78073286d8544e10f6d20f2d3a6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b47926649af4dce18a8347002f46bf86970adbd0
Author: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Date: Tue Jun 29 18:49:42 2021 +0300
intel: fix leaking memory on shader creation
ralloc_adopt takes care of all the shader's children, but shader itsel ends up
orphaned and never gets free'd.
Fixes: ef5bce9253e ("intel: Drop the last uses of a mem_ctx in nir_builder_init_simple_shader().")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4951
Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov at globallogic.com>
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11651>
(cherry picked from commit 974c58b317d1185a53c6753faf24bedae859fa0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f5518143d33a168c5de5444b89bb1e052425e537
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Fri Jun 25 20:30:32 2021 +1000
glsl: force_glsl_version to shaders with no defined version
If a shader has no defined version force_glsl_version was
previous ignored and the shader would default to 110. This updates
the code so that those shaders are forced to a new level also.
We reused the existing code to make sure a sensible value is set
for the version.
Cc: mesa-stable
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11602>
(cherry picked from commit e607205af06ed22a4ac8e32a9b92fe0d7197aac9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4432c2c1c35c5748775ca633f3f07aad17e4d266
Author: Michel Dänzer <mdaenzer at redhat.com>
Date: Sat Apr 10 17:11:58 2021 +0200
Convert most remaining free-form fall-through comments to FALLTHROUGH
One exception is src/amd/addrlib/, for which -Wimplicit-fallthrough is
explicitly disabled.
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Reviewed-by: Gert Wollny <gert.wollny at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10220>
(cherry picked from commit 2928c21eb73b66d22d1f383abf62de583547f81f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=143bd1fd32d6f70562ea1e7bb743b35a82819e2e
Author: Eric Engestrom <eric at engestrom.ch>
Date: Mon Jul 12 22:46:13 2021 +0100
.pick_status.json: Mark e5d158881b3e12270521d7081b4bba0ac2108d2e as denominated
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5007e7fcf08c391f0c7646675460eadf6986d068
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Jun 30 17:32:25 2021 +0200
radv: disable DCC for DOOM 2016 and Wolfenstein II
Both games perform two image layout transitions with the same image
in the same pipeline barrier with UNDEFINED and this re-initializes
DCC to the uncompressed state. No ideal solution sadly. Note that
both games declare all images as CONCURRENT.
This fixes rendering issues on GFX10+ because DCC for stores is
supported and this implicitly enables DCC for concurrent.
Fixes: da166f648f6 ("radv: enable DCC for concurrent images on GFX10")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4927
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4607
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11656>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=007f8a8a58bac28825ed127908bed761adc806f3
Author: Eric Engestrom <eric at engestrom.ch>
Date: Mon Jul 12 21:22:48 2021 +0100
.pick_status.json: Update to c704bb630d21e0a30500e9d8f42493ede3cc55ae
More information about the mesa-commit
mailing list