Mesa (main): pan/gen_pack: Use 1U for unpacking log2 to avoid undefined behaviour

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jul 14 23:39:02 UTC 2021


Module: Mesa
Branch: main
Commit: bedbe35d6bb176475dbe9c4d8345e5774270a196
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bedbe35d6bb176475dbe9c4d8345e5774270a196

Author: Icecream95 <ixn at disroot.org>
Date:   Wed Jul 14 12:48:11 2021 +1200

pan/gen_pack: Use 1U for unpacking log2 to avoid undefined behaviour

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11869>

---

 src/panfrost/lib/gen_pack.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/panfrost/lib/gen_pack.py b/src/panfrost/lib/gen_pack.py
index 8f9411a0f7d..72cc644b87f 100644
--- a/src/panfrost/lib/gen_pack.py
+++ b/src/panfrost/lib/gen_pack.py
@@ -613,7 +613,7 @@ class Group(object):
                 elif field.modifier[0] == "shr":
                     suffix = " << {}".format(field.modifier[1])
                 if field.modifier[0] == "log2":
-                    prefix = "1 << "
+                    prefix = "1U << "
 
             decoded = '{}{}({}){}'.format(prefix, convert, ', '.join(args), suffix)
 



More information about the mesa-commit mailing list