Mesa (main): radeonsi: document a missing synchronization for bindless textures

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Jul 16 23:21:51 UTC 2021


Module: Mesa
Branch: main
Commit: 1abc480b5a00e3707370caf6cdd1f8774c99d724
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1abc480b5a00e3707370caf6cdd1f8774c99d724

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Thu Jul 15 11:39:20 2021 -0400

radeonsi: document a missing synchronization for bindless textures

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11900>

---

 src/gallium/drivers/radeonsi/si_compute.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c
index 4a4e40333e0..37dc9cd0cb5 100644
--- a/src/gallium/drivers/radeonsi/si_compute.c
+++ b/src/gallium/drivers/radeonsi/si_compute.c
@@ -857,6 +857,8 @@ static bool si_check_needs_implicit_sync(struct si_context *sctx)
     *
     *    buffer object and texture stores performed by shaders are not
     *    automatically synchronized
+    *
+    * TODO: Bindless textures are not handled, and thus are not synchronized.
     */
    struct si_shader_info *info = &sctx->cs_shader_state.program->sel.info;
    struct si_samplers *samplers = &sctx->samplers[PIPE_SHADER_COMPUTE];



More information about the mesa-commit mailing list