Mesa (staging/21.2): 25 new commits

Wed Jul 21 18:56:45 UTC 2021

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9d0be7b61320ab107150f08fe8aea01decad99b8
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Tue Jul 20 13:37:31 2021 -0700

    nir/gcm: Clear out pass_flags before starting

    With this pass enabled in Intel drivers, running shader-db on
    shaders/unity/38.shader_test resulted in

    Program received signal SIGSEGV, Segmentation fault.
    gcm_schedule_early_src (src=0x555555d45348, void_state=0x7fffffffba40) at ../../SOURCE/master/src/compiler/nir/nir_opt_gcm.c:297
    297	   if (info->early_block->index < src_info->early_block->index)
    (gdb) print src_info->early_block
    $1 = (nir_block *) 0x0

    I tracked this down to an early exit from gcm_schedule_early_instr on
    the parent instruction because instr->pass_flags was 0x1c.  That
    should be an impossible value for this pass, so I inferred that
    pass_flags must have dirt left from some previous pass.

    Fixes: 8dfe6f672f4 ("nir/GCM: Use pass_flags instead of bitsets for tracking visited/pinned")

    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/597>
    (cherry picked from commit 436668874a1508edf127be16873c6811fe13a3e6)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f2bdec9ecd9221d410015dc30e175564c86e223a
Author: Daniel Schürmann <daniel at schuermann.dev>
Date:   Mon Jul 19 09:11:36 2021 +0200

    aco: include <cstddef> in aco_util.h

    It's needed for ptrdiff.

    Fixes: 59fdaa1985f9269c40f0ca4704fbeb3fb05c4c2f ('aco: reorder and cleanup #includes')
    Closes: #5076
    Reviewed-by: Tony Wasserka <tony.wasserka at gmx.de>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11947>
    (cherry picked from commit 1d8e9430d267d872941fe2af7c1336e58f089101)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=83d94cfe718e29d242862990ad93082efa7e4775
Author: Daniel Stone <daniels at collabora.com>
Date:   Tue Jul 20 13:54:16 2021 +0100

    egl/wayland: Allow EGLSurface to outlive wl_egl_window

    According to the EGL spec, it is entirely valid for an EGLSurface to
    outlive the native_window it was created from, provided that SwapBuffers
    and MakeCurrent return EGL_BAD_NATIVE_WINDOW.

    We don't have any facility to error on MakeCurrent, so just make sure we
    can bundle on safely through rendering for now, then return
    EGL_BAD_NATIVE_WINDOW from SwapBuffers.

    Signed-off-by: Daniel Stone <daniels at collabora.com>
    Reviewed-by: Simon Ser <contact at emersion.fr>
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2251
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4902
    Cc: mesa-stable
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11979>
    (cherry picked from commit 6455ab6e5ac5b1ad815d3e67e72d9adef7ffd21c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8447b1d52b73febefcd1fcecee1669dfc20a4369
Author: Daniel Stone <daniels at collabora.com>
Date:   Tue Jul 20 13:40:00 2021 +0100

    egl/wayland: Error on invalid native window

    We unconditionally require a wl_egl_window to be passed as the native
    window type, and do not permit a default window. The spec requires us to
    return EGL_BAD_NATIVE_WINDOW when doing this, rather than crashing.

    Further, if an EGLSurface has already been created for an existing
    native window, we are required to return EGL_BAD_ALLOC.

    Signed-off-by: Daniel Stone <daniels at collabora.com>
    Reviewed-by: Simon Ser <contact at emersion.fr>
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2251
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4902
    Cc: mesa-stable
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11979>
    (cherry picked from commit 0e2464d26bace803aad575c117686412be82388a)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba9e463c657dabfd260e97e5d9b9fb0cd851687a
Author: Corentin Noël <corentin.noel at collabora.com>
Date:   Wed Jul 21 08:50:01 2021 +0200

    ci: actually run piglit tests with virgl

    Make sure that the host is using llvmpipe while the guest is using virgl as driver.

    Note that the neverball/neverball.trace trace actually regressed in a way that the
    foreground is missing.

    Fixes: f1b952fa ("ci: Run tests inside Crosvm")

    Signed-off-by: Corentin Noël <corentin.noel at collabora.com>
    Reviewed-by: Tomeu Vizoso <tomeu.vizoso at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11986>
    (cherry picked from commit 18fa8205063b5dc07d1e253806070ba008793e1b)

    Conflicts:
    	src/gallium/drivers/virgl/ci/traces-virgl.yml

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f62606c825099773b74887b566bcae6262136f96
Author: Dave Airlie <airlied at redhat.com>
Date:   Wed Jul 21 14:55:41 2021 +1000

    crocus/gen4-5: fix ff gs emit on VS vue map change.

    This should fix some texturing problems seen on gen4/5, I reproduced it
    with a minecraft.trace file

    Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11993>
    (cherry picked from commit 8c6196e7e88a51a87f62d28e9f34197ff57cf5b8)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=25b8c5e4b0df249e46b197a716a8d0572e81e5ce
Author: Michel Zou <xantares09 at hotmail.com>
Date:   Fri Jul 16 08:51:47 2021 +0200

    zink: Fix unused-variable warning

    Fixes: 9b40fc48
    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11920>
    (cherry picked from commit 4c36224f95b61c71a79e00ddf8ef0f02dd1085eb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=00b732a5662b3280ed8d97cd1a5b4090d2242064
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Mon Jul 19 12:18:11 2021 +0200

    broadcom/compiler: emit TMU flush before a jump

    Like in the case of emitting a block, process pending TMU operations
    before a jump is executed.

    Fixes dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional.

    Fixes: 197090a3fca ("broadcom/compiler: implement pipelining for general
    TMU operations")

    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11971>
    (cherry picked from commit dc40157888a8825fe5c411f20029466c7c2f1d47)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cea26a98132b463e814f2ef1769efb64f21e92ac
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Tue Jul 20 05:23:25 2021 -0400

    st/mesa: always use PIPE_USAGE_STAGING for GL_MAP_READ_BIT usage

    This fixes CPU read performance.

    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5091
    Cc: mesa-stable at lists.freedesktop.org

    Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11974>
    (cherry picked from commit 54e1ec017d7852bfc4ba46b54c3ab516f96102f7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3b1f5b2d5ad4b119d86b544c9d34e341c29e642a
Author: Olivier Fourdan <ofourdan at redhat.com>
Date:   Mon Jul 19 09:29:46 2021 +0200

    radeonsi: Check aux_context on si_destroy_screen()

    The function radeonsi_screen_create_impl() tries to create the
    aux_context but doesn't actually check for the returned value from
    si_create_context().

    Then, on si_destroy_screen() the aux_context is used without actually
    checking whether it's a thing or not.

    As a result, if for any reason si_create_context() failed, we shall
    crash in si_destroy_screen() with a NULL pointer dereference trying to
    access ((struct si_context *)sscreen->aux_context)->log.

    Simply check for aux_context not being NULL to avoid that crash.

    Cc: mesa-stable
    Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
    Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11948>
    (cherry picked from commit 5bfd1a7e19ec1c510c2ba4adadad98d78f712eaf)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=400c224efe3f21e6118d543952c9dcb9133c6b55
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Fri Jul 16 18:43:32 2021 +0200

    mesa: fix bindless uniform samplers update

    According to the comment below some extra magic is needed
    for bindless samplers, so don't do an early return in this
    case.

    Fixes: 736f1f70ab8 ("mesa: skip redundant uniform updates for glUniform")
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4806
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11930>
    (cherry picked from commit 8be61e8a9e49190593e0c90077a8ce100b5743de)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d341882e13251e58e265848cef792c5a90128b07
Author: Daniel Schürmann <daniel at schuermann.dev>
Date:   Mon Jul 19 15:01:09 2021 +0200

    aco/optimizer: ensure to not erase high bits when propagating packed constants

    Packed constants with non-zero values in the high half
    might have been propagated as 16 bit, dropping the high half.

    Cc: mesa-stable
    Closes: #5070
    Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11954>
    (cherry picked from commit 9b1a296172df38561d650abf98ee2e1c77ac6fc2)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=588ee0fd3fa20edbbd31434c34a139c4f911e7a9
Author: Jose Maria Casanova Crespo <jmcasanova at igalia.com>
Date:   Fri Jul 16 14:30:51 2021 +0200

    v3d/driconf: Expose non-MSAA texture limits for mutter and gnome-shell

    To enable dual 4k displays on mutter or gnome-shell under X11 we need to
    expose the non-MSAA texture limit as we did for Xorg at 60a64f028d75ad6
    ("v3d: Use driconf to expose non-MSAA texture limits for Xorg.")

    https://gitlab.gnome.org/GNOME/mutter/-/issues/1874

    Cc: 21.1 21.2 mesa-stable
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11926>
    (cherry picked from commit fd5fa73e6c8deeb8e09062e412d7d05fe57d0c59)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e00c1956d7df4754115badf344f42b2150e7214
Author: Karol Herbst <kherbst at redhat.com>
Date:   Thu May 27 18:59:37 2021 +0200

    nv50/ir/nir: fix smem size for GL

    Originally I fixed the case where the nir itself has a shared mem size of
    0, but the frontend (e.g. clover) set it to some other value.

    But st/mesa sets the shared mem size on the state object as well and we
    end up actually doubling the value in the driver as we set smemSize to the
    value from the state object before calling into the compiler.

    So just max the value instead.

    Fixes the compute_shader.shared-max CTS test.

    Fixes: dc667b1f192 ("nv50/ir/nir: fix smem size")
    Signed-off-by: Karol Herbst <kherbst at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11047>
    (cherry picked from commit ff55412f40a7d588e47e2c35d175aea0ac3cfe95)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4be9824dc90b9c258bc5cc4706fa7a50abe1852d
Author: Dave Airlie <airlied at redhat.com>
Date:   Fri Jul 16 12:28:57 2021 +1000

    softpipe/aniso: move DDQ calculation to after scaling.

    I've read the papers on EWA filters and it seems like the calculate
    DDQ = 2 * A after the scaling of A happens. This seems to make
    things less blurry and more like real aniso.

    Fixes: 2135aba8 ("softpipe: Constify variables")
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Reviewed-by: Roland Scheidegger <sroland at vmware.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11917>
    (cherry picked from commit 57dcfb4e55346ee2d7e3da79e93a7d36a8a5ca17)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3cb96be239a8315cb27bc6cdb2ee41b9f12e4f66
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Thu Jul 15 22:28:00 2021 +1000

    glsl: replace some C++ code with C

    This replaces some new/delete uses with malloc/free.

    This is more consistent with most of the other glsl IR code but
    more importantly it allows the game "Battle Block Theater" to
    start working on some mesa drivers. The game overrides new and
    ends up throwing an assert and crashing when it sees this
    function calling new [0].

    Note: The game still crashes with radeonsi due to similar conflicts
    with LLVM.

    CC: mesa-stable

    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11907>
    (cherry picked from commit 749251391d967ce5450a6adfeb64cb773cce2508)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=04e8aeac6d05611984ed79c6c288e136388ad517
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Sun Jun 13 23:00:44 2021 -0400

    mesa: fix incorrect comment in draw_gallium_multimode

    Fixes: 4566383ae4b ("gallium: move pipe_draw_info::index_bias to pipe_draw_start_count_bias")

    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11939>
    (cherry picked from commit ed57666a5c10a601b89868fa986d9ef215b908ed)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=742c35d17c22456f5d2c5780971bef37adc903c1
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri Jul 16 12:50:21 2021 -0400

    util/foz: stop crashing on destroy if prepare hasn't been called

    Fixes: eca6bb9540d ("util/fossilize_db: add basic fossilize db util to read/write shader caches")

    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11931>
    (cherry picked from commit 2850db0a9ef3751b1b3429d9b7e75ed22dc4e59e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3c5987e2b4ab18288c1a6f3e07223d9042e38f5b
Author: Iván Briano <ivan.briano at intel.com>
Date:   Wed Jul 14 19:38:28 2021 -0700

    anv: fix feature/property/sizes reported for fragment shading rate

    Fixes: 790ff1ceac8 ("anv: fixup physical device properties of fragment shading rate")

    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11897>
    (cherry picked from commit d27f7fa1b334f799bcb75d185bf359a4c5091572)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2193a19631bd54f78b677ea681c8a2aefe379cbb
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Wed Jul 14 08:27:40 2021 -0400

    radeonsi: don't expose no-attachment MSAA 16x on all 1 RB chips due to issues

    Cc: mesa-stable at lists.freedesktop.org

    Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11900>
    (cherry picked from commit 86ff5b7ddb60ee82b04eea143b9cc7efa3ff8183)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8653cbd0aac61cc8c9d949ec923c56f3d05fb656
Author: Dylan Baker <dylan.c.baker at intel.com>
Date:   Wed Jul 21 11:48:53 2021 -0700

    .pick_status.json: Update to 27534a49cf3872646cb8ef9371707d74a81b1986

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfd3fcd3aff79863f05e3866c2dc12386d92be02
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date:   Fri Jul 16 16:01:14 2021 +0300

    freedreno: fix wrong tile aligment for 3 CCU gpu

    Fixes: 78c8a8af80d5b0ccd68dd85ff7ecbb699be31f7d "freedreno: Generate device-info tables at build time"
    Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5060

    Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11928>
    (cherry picked from commit 53d4485a028525f9a041e527e50d79ecd3e999fc)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5be2d785ae2e839b6f692b7b349d69874de9fa6f
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Jul 7 14:36:38 2021 -0500

    iris: Use intel_i915_query for meminfo

    Error handling with DRM_IOCTL_I915_QUERY is tricky and we got it wrong
    in one of the two calls here.  Use the common helper instead.  This also
    fixes a theoretical bug where calloc() fails.  While we're here, inline
    iris_bufmgr_update_meminfo because we're not really benefiting from
    having it separate anymore.

    Fixes: e60114b2ae11 "iris/bufmgr: Query memory region info."
    Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11770>
    (cherry picked from commit 3fa6b8d0417f215a859386c9c41aca3cd4ec201e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9af1aa306fb4c0df636be9a523765d055878031e
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Jul 7 14:32:23 2021 -0500

    anv: Use intel_i915_query_alloc for memory regions

    Error handling with DRM_IOCTL_I915_QUERY is tricky and we got it wrong
    in one of the two calls here.  Use the common helper instead.  This also
    fixes a theoretical bug where calloc() fails.  While we're here, inline
    anv_track_meminfo because we're not really benefiting from having it
    separate anymore.

    Fixes: 65e8d72bc106 "anv: Query memory region info"
    Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11770>
    (cherry picked from commit 35ec1d9730cd1d0e3d8f212d5edcea53fe7cc518)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=22941ec612f9602a242b6bccc0d14ee67dbe989b
Author: Jason Ekstrand <jason at jlekstrand.net>
Date:   Wed Jul 7 14:27:12 2021 -0500

    intel: Pull anv_i915_query into common code

    We also add a helper which contains the standard query+alloc+query
    pattern used by anv_gem_get_engine_info().  The caller is required to
    free the pointer.

    These are declared static inline not because we care about the
    performance of these helpers but because we're going to use them in the
    intel_device_info code and we don't want a link dependency.

    Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11770>
    (cherry picked from commit ffdf4d76838b906030f17d7d1b50fddd1c8679f3)