Mesa (main): 30 new commits

Sat Jul 24 23:49:42 UTC 2021

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9cc0834ca604638081ae6c295050c657625086c6
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 18:00:39 2021 -0400

    asahi: Generalize src_offset for non-4byte formats
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a3e0b3b912b552f753a2af7c2357228f4ab98c7f
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 18:00:07 2021 -0400

    asahi: Add integers to agx_vertex_formats
    
    Handles all the easy cases.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3cd6f6238839fda454870dd8b6db0e84bf6944f6
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:57:19 2021 -0400

    agx: Shift vertex buffer stride in the compiler
    
    Required to support non-32-bit vertex formats efficiently.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c7ba0fb04dbaa6896741b6aef1130166127a40f0
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:45:38 2021 -0400

    agx: Add agx_format_shift routine
    
    Required to calculate alignments for vertex buffers correctly.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b329fe826413ad8cbc6f2884cafb25f8ea975c71
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:26:02 2021 -0400

    asahi: Pass instance_divisor to the compiler
    
    Passes dEQP-GLES3.functional.instanced.*
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=96c98e0d2516ddbd4aa76e397d533a46a48bbdcc
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:25:40 2021 -0400

    agx: Define p_extract for type converts
    
    Useful for grabbing the high 32-bit word of a 64-bit value.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3417ecb4d7ce947936ab3bb1007d7016a5d38197
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:25:11 2021 -0400

    agx: Implement instanced arrays
    
    Divide by instance divisor if needed. Same strategy as ACO.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=538e3a31003b257de71ad7c1230c59c37783ae26
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:24:47 2021 -0400

    agx: Include divisors in the vertex shader key
    
    Needed to lower the divisions.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c353d47be5d0c45ed72b09084ed66d3c99b4998
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:24:02 2021 -0400

    agx: Add udiv-by-constant routine
    
    Uses the ridiculousfish algorithm, will be used to lower instanced
    arrays into something efficient.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=50a4c993fd5638267d7f06e130b573a455a0891c
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 17:23:42 2021 -0400

    agx: Add agx_ushr helper
    
    Syntax sugar for the underlying bitfield manipulation instruction.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3c1f754a7174b7d64de0cb5ad752012332e993a9
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 15:12:18 2021 -0400

    agx: Handle load_instance_id
    
    Preloaded into r6, as predicted.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3f5eebe5e6a434193be1968f2646911f19b4d84d
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 15:12:03 2021 -0400

    agx: Drop dated /* TODO: RA */
    
    We skip over vertex ID in RA now, it's fine.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b1dd2e5221332110f7ad24d3a7e34b5d05c0661
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 15:04:25 2021 -0400

    asahi: Enable instancing
    
    Passes dEQP-GLES3.functional.draw.draw_arrays_instanced.lines.single_attribute
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=465224379c319dc42cc533ae53542cdf01dd7650
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 14:56:52 2021 -0400

    agx: Plug memory leak in register allocator
    
    Fixes: 85e18deb18a ("agx: Assign registers locally")
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Reported-by: Coverity
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7848100f270b2b917b7d6b853bd0784f658bcaa0
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 14:55:16 2021 -0400

    agx: Use consistent ncomps
    
    Fixes register allocation failure in:
    dEQP-GLES3.functional.ubo.single_basic_array.shared.row_major_mat4_fragment
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cce1a2fc196e917be5de07d20d48f300b053195c
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 14:54:34 2021 -0400

    agx: Dump register file when failing to allocate
    
    Usually shows a bug.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5fb9159eb97e439e67145107b11512a66fe86cc8
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 14:39:44 2021 -0400

    agx: Fix mismatched units in load_ubo
    
    Fixes assertion failure in
    dEQP-GLES3.functional.ubo.single_basic_type.shared.highp_float_fragment
    
       Assertion failed: ((value & 1) == 0), function agx_print_sized, file
       ../src/asahi/compiler/agx_print.c, line 39.
    
    Fixes: 033d4d09fc7 ("agx: Implement load_ubo/kernel_input")
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5deb7c26d67bcb37daaeb1d5132393d81555f63c
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 14:27:35 2021 -0400

    agx: Don't set helper invocation kill bit
    
    In the future we'll need data flow analysis similar to what we do in
    panfrost.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8aa5ba4012b2b8fb5ca8fb615a917ea3fd76ba64
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:55:19 2021 -0400

    asahi: Assert texture layer is nonzero
    
    The app shouldn't do funny things with layers... currently unsupported,
    one issue at a time...
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=41417a99497b2a27353cd3360456c80d76871bde
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:06:32 2021 -0400

    asahi: Require tiling for cube maps
    
    Makes my dEQP happy.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ecc14a7477ab82a9087537b416908b5b57ccc19
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:06:11 2021 -0400

    asahi: Simplify can_tile type signature
    
    dev parameter inherited from panfrost.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=904ce664335b78f332dfa7c44821eaae8a32f4d1
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:56:29 2021 -0400

    asahi: Allow tiled cube maps
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b4eb731f1d819d4fdaa31fa1a736cdcd31a8818
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:01:08 2021 -0400

    asahi: Use agx_rsrc_offset for linear transfer_map
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=695fe3897dc450a8b97f8cd11cf94e9bfd93cfb7
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:52:41 2021 -0400

    asahi: Implement cube map tiling transfers
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=143783538a01ea04227c343f9a2ee4902f541e03
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:52:15 2021 -0400

    asahi: Calculate resource offsets for cube maps
    
    Needed to transfer.
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=be3d4ce8c4b6503253247d4cabe737c3a78f6816
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:51:00 2021 -0400

    asahi: Calculate cube map stride
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=db6d5a0860ba3cd09f4b06807d014f4f9a63eb77
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:23:56 2021 -0400

    asahi: Set texture dimension field
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1671022bf25d1985ec4a7770f420d06229f5d358
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 12:20:17 2021 -0400

    asahi: Identify texture dimension field
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=23f5ad668f1220e905a6f35d947c04b126c457e0
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:20:13 2021 -0400

    asahi: Fix sampler filtering flag
    
    Typo in the XML. Fixes broken filtering. Still chasing an off-by-one.
    
    Fixes: cad54e2721d ("asahi: Add command buffer XML definitions")
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f376a90d21f878ac57a836bab5b3a3a97870c323
Author: Alyssa Rosenzweig <alyssa at rosenzweig.io>
Date:   Sat Jul 24 13:55:05 2021 -0400

    asahi: Identify texture address field
    
    Signed-off-by: Alyssa Rosenzweig <alyssa at rosenzweig.io>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053>