Mesa (main): nv30: fix emulated vertex index buffers

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 1387d1d41103b3120d40f93f66a7cfe00304bfd7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1387d1d41103b3120d40f93f66a7cfe00304bfd7

Author: Karol Herbst <kherbst at redhat.com>
Date:   Sun Jul 25 02:10:29 2021 +0200

nv30: fix emulated vertex index buffers

We ended up applying the offset twice. Quite embarrassing.

This fixes a bunch of vertex shader related issues like the gnome desktop
is less broken and probably a lot of other applications.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5061
Cc: mesa-stable
Signed-off-by: Karol Herbst <kherbst at redhat.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12054>

---

 src/gallium/drivers/nouveau/nv30/nv30_vbo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c
index 78f442a7c0e..3e24e90c735 100644
--- a/src/gallium/drivers/nouveau/nv30/nv30_vbo.c
+++ b/src/gallium/drivers/nouveau/nv30/nv30_vbo.c
@@ -514,9 +514,9 @@ nv30_draw_elements(struct nv30_context *nv30, bool shorten,
       if (!info->has_user_indices)
          data = nouveau_resource_map_offset(&nv30->base,
                                             nv04_resource(info->index.resource),
-                                            start * index_size, NOUVEAU_BO_RD);
+                                            0, NOUVEAU_BO_RD);
       else
-         data = (char*)info->index.user + start * index_size;
+         data = info->index.user;
       if (!data)
          return;